* lib: sw842: select crc32
@ 2016-01-13 22:24 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-01-13 22:24 UTC (permalink / raw)
To: Herbert Xu; +Cc: Dan Streetman, linux-crypto, linux-kernel, linux-arm-kernel
The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
failure when CONFIG_CRC32 is not set:
lib/built-in.o: In function `sw842_compress':
oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
lib/built-in.o: In function `sw842_decompress':
oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
This adds an explict 'select CRC32' statement, similar to what the other users
of the crc32 code have. In practice, CRC32 is always enabled anyway because
over 100 other symbols select it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
diff --git a/lib/Kconfig b/lib/Kconfig
index 1ce5af9cc418..ee38a3fd2814 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -217,9 +217,11 @@ config RANDOM32_SELFTEST
# compression support is select'ed if needed
#
config 842_COMPRESS
+ select CRC32
tristate
config 842_DECOMPRESS
+ select CRC32
tristate
config ZLIB_INFLATE
^ permalink raw reply related [flat|nested] 6+ messages in thread
* lib: sw842: select crc32
@ 2016-01-13 22:24 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-01-13 22:24 UTC (permalink / raw)
To: linux-arm-kernel
The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
failure when CONFIG_CRC32 is not set:
lib/built-in.o: In function `sw842_compress':
oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
lib/built-in.o: In function `sw842_decompress':
oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
This adds an explict 'select CRC32' statement, similar to what the other users
of the crc32 code have. In practice, CRC32 is always enabled anyway because
over 100 other symbols select it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
diff --git a/lib/Kconfig b/lib/Kconfig
index 1ce5af9cc418..ee38a3fd2814 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -217,9 +217,11 @@ config RANDOM32_SELFTEST
# compression support is select'ed if needed
#
config 842_COMPRESS
+ select CRC32
tristate
config 842_DECOMPRESS
+ select CRC32
tristate
config ZLIB_INFLATE
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: lib: sw842: select crc32
2016-01-13 22:24 ` Arnd Bergmann
@ 2016-01-14 3:36 ` Dan Streetman
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Streetman @ 2016-01-14 3:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Herbert Xu, Linux Crypto Mailing List, linux-kernel, linux-arm-kernel
On Wed, Jan 13, 2016 at 5:24 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
> failure when CONFIG_CRC32 is not set:
>
> lib/built-in.o: In function `sw842_compress':
> oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
> lib/built-in.o: In function `sw842_decompress':
> oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
>
> This adds an explict 'select CRC32' statement, similar to what the other users
> of the crc32 code have. In practice, CRC32 is always enabled anyway because
> over 100 other symbols select it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
Acked-by: Dan Streetman <ddstreet@ieee.org>
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 1ce5af9cc418..ee38a3fd2814 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -217,9 +217,11 @@ config RANDOM32_SELFTEST
> # compression support is select'ed if needed
> #
> config 842_COMPRESS
> + select CRC32
> tristate
>
> config 842_DECOMPRESS
> + select CRC32
> tristate
>
> config ZLIB_INFLATE
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* lib: sw842: select crc32
@ 2016-01-14 3:36 ` Dan Streetman
0 siblings, 0 replies; 6+ messages in thread
From: Dan Streetman @ 2016-01-14 3:36 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 13, 2016 at 5:24 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
> failure when CONFIG_CRC32 is not set:
>
> lib/built-in.o: In function `sw842_compress':
> oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
> lib/built-in.o: In function `sw842_decompress':
> oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
>
> This adds an explict 'select CRC32' statement, similar to what the other users
> of the crc32 code have. In practice, CRC32 is always enabled anyway because
> over 100 other symbols select it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
Acked-by: Dan Streetman <ddstreet@ieee.org>
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 1ce5af9cc418..ee38a3fd2814 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -217,9 +217,11 @@ config RANDOM32_SELFTEST
> # compression support is select'ed if needed
> #
> config 842_COMPRESS
> + select CRC32
> tristate
>
> config 842_DECOMPRESS
> + select CRC32
> tristate
>
> config ZLIB_INFLATE
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: lib: sw842: select crc32
2016-01-13 22:24 ` Arnd Bergmann
@ 2016-01-18 15:24 ` Herbert Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2016-01-18 15:24 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Dan Streetman, linux-crypto, linux-kernel, linux-arm-kernel
On Wed, Jan 13, 2016 at 11:24:02PM +0100, Arnd Bergmann wrote:
> The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
> failure when CONFIG_CRC32 is not set:
>
> lib/built-in.o: In function `sw842_compress':
> oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
> lib/built-in.o: In function `sw842_decompress':
> oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
>
> This adds an explict 'select CRC32' statement, similar to what the other users
> of the crc32 code have. In practice, CRC32 is always enabled anyway because
> over 100 other symbols select it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* lib: sw842: select crc32
@ 2016-01-18 15:24 ` Herbert Xu
0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2016-01-18 15:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 13, 2016 at 11:24:02PM +0100, Arnd Bergmann wrote:
> The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
> failure when CONFIG_CRC32 is not set:
>
> lib/built-in.o: In function `sw842_compress':
> oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
> lib/built-in.o: In function `sw842_decompress':
> oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
>
> This adds an explict 'select CRC32' statement, similar to what the other users
> of the crc32 code have. In practice, CRC32 is always enabled anyway because
> over 100 other symbols select it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-18 15:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-13 22:24 lib: sw842: select crc32 Arnd Bergmann
2016-01-13 22:24 ` Arnd Bergmann
2016-01-14 3:36 ` Dan Streetman
2016-01-14 3:36 ` Dan Streetman
2016-01-18 15:24 ` Herbert Xu
2016-01-18 15:24 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.