* Re: [PATCH] zswap: get swapper address_space by using swap_address_space macro
2013-07-12 4:42 [PATCH] zswap: get swapper address_space by using swap_address_space macro Sunghan Suh
@ 2013-07-12 4:58 ` Bob Liu
2013-07-12 5:47 ` Wanpeng Li
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Bob Liu @ 2013-07-12 4:58 UTC (permalink / raw)
To: Sunghan Suh; +Cc: sjenning, linux-mm
On 07/12/2013 12:42 PM, Sunghan Suh wrote:
> Signed-off-by: Sunghan Suh <sunghan.suh@samsung.com>
> ---
> mm/zswap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index deda2b6..efed4c8 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -409,7 +409,7 @@ static int zswap_get_swap_cache_page(swp_entry_t entry,
> struct page **retpage)
> {
> struct page *found_page, *new_page = NULL;
> - struct address_space *swapper_space = &swapper_spaces[swp_type(entry)];
> + struct address_space *swapper_space = swap_address_space(entry);
> int err;
>
> *retpage = NULL;
>
Reviewed-by: Bob Liu <bob.liu@oracle.com>
--
Regards,
-Bob
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] zswap: get swapper address_space by using swap_address_space macro
2013-07-12 4:42 [PATCH] zswap: get swapper address_space by using swap_address_space macro Sunghan Suh
2013-07-12 4:58 ` Bob Liu
@ 2013-07-12 5:47 ` Wanpeng Li
2013-07-12 5:47 ` Wanpeng Li
2013-07-12 18:00 ` Seth Jennings
3 siblings, 0 replies; 5+ messages in thread
From: Wanpeng Li @ 2013-07-12 5:47 UTC (permalink / raw)
To: Sunghan Suh; +Cc: sjenning, linux-mm
On Fri, Jul 12, 2013 at 01:42:55PM +0900, Sunghan Suh wrote:
>Signed-off-by: Sunghan Suh <sunghan.suh@samsung.com>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>---
> mm/zswap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/zswap.c b/mm/zswap.c
>index deda2b6..efed4c8 100644
>--- a/mm/zswap.c
>+++ b/mm/zswap.c
>@@ -409,7 +409,7 @@ static int zswap_get_swap_cache_page(swp_entry_t entry,
> struct page **retpage)
> {
> struct page *found_page, *new_page = NULL;
>- struct address_space *swapper_space = &swapper_spaces[swp_type(entry)];
>+ struct address_space *swapper_space = swap_address_space(entry);
> int err;
>
> *retpage = NULL;
>--
>1.8.1.2
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] zswap: get swapper address_space by using swap_address_space macro
2013-07-12 4:42 [PATCH] zswap: get swapper address_space by using swap_address_space macro Sunghan Suh
2013-07-12 4:58 ` Bob Liu
2013-07-12 5:47 ` Wanpeng Li
@ 2013-07-12 5:47 ` Wanpeng Li
2013-07-12 18:00 ` Seth Jennings
3 siblings, 0 replies; 5+ messages in thread
From: Wanpeng Li @ 2013-07-12 5:47 UTC (permalink / raw)
To: Sunghan Suh; +Cc: sjenning, linux-mm
On Fri, Jul 12, 2013 at 01:42:55PM +0900, Sunghan Suh wrote:
>Signed-off-by: Sunghan Suh <sunghan.suh@samsung.com>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>---
> mm/zswap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/zswap.c b/mm/zswap.c
>index deda2b6..efed4c8 100644
>--- a/mm/zswap.c
>+++ b/mm/zswap.c
>@@ -409,7 +409,7 @@ static int zswap_get_swap_cache_page(swp_entry_t entry,
> struct page **retpage)
> {
> struct page *found_page, *new_page = NULL;
>- struct address_space *swapper_space = &swapper_spaces[swp_type(entry)];
>+ struct address_space *swapper_space = swap_address_space(entry);
> int err;
>
> *retpage = NULL;
>--
>1.8.1.2
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] zswap: get swapper address_space by using swap_address_space macro
2013-07-12 4:42 [PATCH] zswap: get swapper address_space by using swap_address_space macro Sunghan Suh
` (2 preceding siblings ...)
2013-07-12 5:47 ` Wanpeng Li
@ 2013-07-12 18:00 ` Seth Jennings
3 siblings, 0 replies; 5+ messages in thread
From: Seth Jennings @ 2013-07-12 18:00 UTC (permalink / raw)
To: Sunghan Suh; +Cc: linux-mm, Andrew Morton
On Fri, Jul 12, 2013 at 01:42:55PM +0900, Sunghan Suh wrote:
> Signed-off-by: Sunghan Suh <sunghan.suh@samsung.com>
> ---
> mm/zswap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index deda2b6..efed4c8 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -409,7 +409,7 @@ static int zswap_get_swap_cache_page(swp_entry_t entry,
> struct page **retpage)
> {
> struct page *found_page, *new_page = NULL;
> - struct address_space *swapper_space = &swapper_spaces[swp_type(entry)];
> + struct address_space *swapper_space = swap_address_space(entry);
> int err;
>
> *retpage = NULL;
Thanks Sunghan!
Please add a simple commit message and resend with Andrew Morton on Cc:
Andrew Morton <akpm@linux-foundation.org>
When you resend, include the Reviewed-by tags from Wanpeng and Bob,
as well as my:
Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Seth
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread