[PATCH] btrfs: remove overly verbose messages

[PATCH] btrfs: remove overly verbose messages

[Nikolay Borisov]

The message "flagging fs with big metadata" doesn't really convey any
useful information to users. Simply remove it.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 fs/btrfs/disk-io.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index c3d92aadc820..8c34d08e3c64 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3508,12 +3508,8 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 	 * Flag our filesystem as having big metadata blocks if they are bigger
 	 * than the page size.
 	 */
-	if (btrfs_super_nodesize(disk_super) > PAGE_SIZE) {
-		if (!(features & BTRFS_FEATURE_INCOMPAT_BIG_METADATA))
-			btrfs_info(fs_info,
-				"flagging fs with big metadata feature");
+	if (btrfs_super_nodesize(disk_super) > PAGE_SIZE)
 		features |= BTRFS_FEATURE_INCOMPAT_BIG_METADATA;
-	}
 
 	/*
 	 * mixed block groups end up with duplicate but slightly offset
-- 
2.25.1

Re: [PATCH] btrfs: remove overly verbose messages

[Nikolay Borisov]

On 23.06.22 г. 10:57 ч., Nikolay Borisov wrote:
> The message "flagging fs with big metadata" doesn't really convey any
> useful information to users. Simply remove it.
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Disregard this, I see you've sent a patch changing it to debug level.

Re: [PATCH] btrfs: remove overly verbose messages

[Qu Wenruo]

On 2022/6/23 15:57, Nikolay Borisov wrote:
> The message "flagging fs with big metadata" doesn't really convey any
> useful information to users. Simply remove it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

THanks,
Qu
> ---
>   fs/btrfs/disk-io.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index c3d92aadc820..8c34d08e3c64 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -3508,12 +3508,8 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
>   	 * Flag our filesystem as having big metadata blocks if they are bigger
>   	 * than the page size.
>   	 */
> -	if (btrfs_super_nodesize(disk_super) > PAGE_SIZE) {
> -		if (!(features & BTRFS_FEATURE_INCOMPAT_BIG_METADATA))
> -			btrfs_info(fs_info,
> -				"flagging fs with big metadata feature");
> +	if (btrfs_super_nodesize(disk_super) > PAGE_SIZE)
>   		features |= BTRFS_FEATURE_INCOMPAT_BIG_METADATA;
> -	}
>
>   	/*
>   	 * mixed block groups end up with duplicate but slightly offset

Re: [PATCH] btrfs: remove overly verbose messages

[David Sterba]

On Thu, Jun 23, 2022 at 10:57:52AM +0300, Nikolay Borisov wrote:
> The message "flagging fs with big metadata" doesn't really convey any
> useful information to users. Simply remove it.
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---

Added to misc-next, with changelog from my patch making it debug level.