[PATCH] it8212.c, kernel 2.6.9-ac16

[PATCH] it8212.c, kernel 2.6.9-ac16

[Philipp E, Imhof]

Hello!

I am using an ITE 8211 controller that did not work with
2.6.9-ac16, because of the PCI device ID.

I created a trivial (but useful) patch that adds the device
ID to the driver and a small comment for people grepping the
sources for the controller type.

I do not know whether the 8212 and the 8211 are fully
compatible, but in my computer, 8211 works fine with 8212's
driver.


diff -ur linux/drivers/ide/pci/it8212.c
linux-2.6.9-ite/drivers/ide/pci/it8212.c
--- linux/drivers/ide/pci/it8212.c	2004-12-17 14:43:39.000000000
+0100
+++ linux-2.6.9-ite/drivers/ide/pci/it8212.c	2004-12-17
14:48:43.000000000 +0100
@@ -16,6 +16,8 @@
   *  as an IDE controller. Smart mode only understands DMA
read/write and
   *  identify, none of the fancier commands apply.
   *
+ *  This driver also supports ITE8211.
+ *
   *  Errata:
   *  o	Rev 0x10 also requires master/slave hold the same DMA
timings and
   *	cannot do ATAPI MWDMA.
@@ -831,6 +833,7 @@
  }

  static struct pci_device_id it8212_pci_tbl[] = {
+	{ PCI_VENDOR_ID_ITE, PCI_DEVICE_ID_ITE_8211,  PCI_ANY_ID,
PCI_ANY_ID, 0, 0, 0},
  	{ PCI_VENDOR_ID_ITE, PCI_DEVICE_ID_ITE_8212,  PCI_ANY_ID,
PCI_ANY_ID, 0, 0, 0},
  	{ 0, },
  };
diff -ur linux/include/linux/pci_ids.h
linux-2.6.9-ite/include/linux/pci_ids.h
--- linux/include/linux/pci_ids.h	2004-12-17 14:43:39.000000000 +0100
+++ linux-2.6.9-ite/include/linux/pci_ids.h	2004-12-17
14:30:01.000000000 +0100
@@ -1659,6 +1659,7 @@
  #define PCI_VENDOR_ID_ITE		0x1283
  #define PCI_DEVICE_ID_ITE_IT8172G	0x8172
  #define PCI_DEVICE_ID_ITE_IT8172G_AUDIO 0x0801
+#define PCI_DEVICE_ID_ITE_8211		0x8211
  #define PCI_DEVICE_ID_ITE_8212		0x8212
  #define PCI_DEVICE_ID_ITE_8872		0x8872
  #define PCI_DEVICE_ID_ITE_IT8330G_0	0xe886


--- END ---

Thank you very much for all your work.

Kind regards

Philipp Imhof, fippu@fippu.ch

PS: Please cc: me for comments, feedback or flames, as I
am not subscribed to the list (shame!) due to my lack
of knowledge...

Re: [PATCH] it8212.c, kernel 2.6.9-ac16

[Alan Cox]

On Gwe, 2004-12-17 at 14:01, Philipp E, Imhof wrote:
> I do not know whether the 8212 and the 8211 are fully
> compatible, but in my computer, 8211 works fine with 8212's
> driver.

Reading the datasheet I believe they are except that for IT8211 we
should not be checking for smart mode perhaps ?

RE: [PATCH] it8212.c, kernel 2.6.9-ac16

[Donald.Huang]

IT8211 and IT8212 are the same , if you use it as a normal IDE device.
But IT8212 has a hardware raid fuction.
The first IT8211's product ID ,maybe also use IT8212's product ID.
I think it's ok to use the IT8212 driver.

-----Original Message-----
From: linux-kernel-owner@vger.kernel.org
[mailto:linux-kernel-owner@vger.kernel.org]On Behalf Of Alan Cox
Sent: Monday, December 20, 2004 10:56 PM
To: Philipp E, Imhof
Cc: Linux Kernel Mailing List
Subject: Re: [PATCH] it8212.c, kernel 2.6.9-ac16


On Gwe, 2004-12-17 at 14:01, Philipp E, Imhof wrote:
> I do not know whether the 8212 and the 8211 are fully
> compatible, but in my computer, 8211 works fine with 8212's
> driver.

Reading the datasheet I believe they are except that for IT8211 we
should not be checking for smart mode perhaps ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/