[KJ] [PATCH 6/53] radeonfb: Clean up printk()'s in

[KJ] [PATCH 6/53] radeonfb: Clean up printk()'s in

[James Nelson]

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]

This patch adds KERN_ constants to all of the printk()'s that need them in
drivers/video/aty/radeon_base.c

Signed-off-by: James Nelson <james4765@gmail.com>

diff -urN --exclude='*~' linux-2.6.11-rc2-mm1-original/drivers/video/aty/radeon_base.c linux-2.6.11-rc2-mm1/drivers/video/aty/radeon_base.c
--- linux-2.6.11-rc2-mm1-original/drivers/video/aty/radeon_base.c	2005-01-24 17:15:49.000000000 -0500
+++ linux-2.6.11-rc2-mm1/drivers/video/aty/radeon_base.c	2005-01-24 19:07:02.367262774 -0500
@@ -710,12 +710,12 @@
 	if (rinfo->pll.sclk == 0)
 		rinfo->pll.sclk = 20000;
 
-	printk("radeonfb: Reference=%d.%02d MHz (RefDiv=%d) Memory=%d.%02d Mhz, System=%d.%02d MHz\n",
+	pr_info("radeonfb: Reference=%d.%02d MHz (RefDiv=%d) Memory=%d.%02d Mhz, System=%d.%02d MHz\n",
 	       rinfo->pll.ref_clk / 100, rinfo->pll.ref_clk % 100,
 	       rinfo->pll.ref_div,
 	       rinfo->pll.mclk / 100, rinfo->pll.mclk % 100,
 	       rinfo->pll.sclk / 100, rinfo->pll.sclk % 100);
-	printk("radeonfb: PLL min %d max %d\n", rinfo->pll.ppll_min, rinfo->pll.ppll_max);
+	pr_info("radeonfb: PLL min %d max %d\n", rinfo->pll.ppll_min, rinfo->pll.ppll_max);
 }
 
 static int radeonfb_check_var (struct fb_var_screeninfo *var, struct fb_info *info)
@@ -795,7 +795,7 @@
                         v.transp.length = 8;
                         break;
                 default:
-                        printk ("radeonfb: mode %dx%dx%d rejected, color depth invalid\n",
+                        printk (KERN_ERR "radeonfb: mode %dx%dx%d rejected, color depth invalid\n",
                                 var->xres, var->yres, var->bits_per_pixel);
                         return -EINVAL;
         }
@@ -2391,7 +2391,7 @@
 	}
 #endif
 
-	printk ("radeonfb (%s): %s\n", pci_name(rinfo->pdev), rinfo->name);
+	pr_info ("radeonfb (%s): %s\n", pci_name(rinfo->pdev), rinfo->name);
 
 	if (rinfo->bios_seg)
 		radeon_unmap_ROM(rinfo, pdev);

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 6/53] radeonfb: Clean up printk()'s in

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

On Wednesday 26 January 2005 01:09, James Nelson wrote:

> --- linux-2.6.11-rc2-mm1-original/drivers/video/aty/radeon_base.c
> +++ linux-2.6.11-rc2-mm1/drivers/video/aty/radeon_base.c

> -                        printk ("radeonfb: mode %dx%dx%d rejected, color depth invalid\n",
> +                        printk (KERN_ERR "radeonfb: mode %dx%dx%d rejected, color depth invalid\n",

> -	printk ("radeonfb (%s): %s\n", pci_name(rinfo->pdev), rinfo->name);
> +	pr_info ("radeonfb (%s): %s\n", pci_name(rinfo->pdev), rinfo->name);

"f(x)" (without space between "f" and "(") style is dominant in this file. I'd remove
these spaces.

	Alexey

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 6/53] radeonfb: Clean up printk()'s

[Jim Nelson]

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

Alexey Dobriyan wrote:
> On Wednesday 26 January 2005 01:09, James Nelson wrote:
> 
> 
>>--- linux-2.6.11-rc2-mm1-original/drivers/video/aty/radeon_base.c
>>+++ linux-2.6.11-rc2-mm1/drivers/video/aty/radeon_base.c
> 
> 
>>-                        printk ("radeonfb: mode %dx%dx%d rejected, color depth invalid\n",
>>+                        printk (KERN_ERR "radeonfb: mode %dx%dx%d rejected, color depth invalid\n",
> 
> 
>>-	printk ("radeonfb (%s): %s\n", pci_name(rinfo->pdev), rinfo->name);
>>+	pr_info ("radeonfb (%s): %s\n", pci_name(rinfo->pdev), rinfo->name);
> 
> 
> "f(x)" (without space between "f" and "(") style is dominant in this file. I'd remove
> these spaces.
> 
> 	Alexey
> 


This driver needs a thorough whitespace cleanup - I was trying to minimize 
changes. I'll add this to my "needs a Lindent patch submitted later" list.

Jim

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors