All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] button: adc: fix treshold typo
@ 2021-02-23 15:10   ` Neil Armstrong
  0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2021-02-23 15:10 UTC (permalink / raw)
  To: u-boot

Fix the treshold typo in code by threshold.

Fixes: c0165c85c3 ("button: add a simple Analog to Digital Converter device based button driver")
Suggested-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/button/button-adc.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/button/button-adc.c b/drivers/button/button-adc.c
index eed86564fb..fd896c76f9 100644
--- a/drivers/button/button-adc.c
+++ b/drivers/button/button-adc.c
@@ -55,7 +55,7 @@ static int button_adc_of_to_plat(struct udevice *dev)
 	struct button_uc_plat *uc_plat = dev_get_uclass_plat(dev);
 	struct button_adc_priv *priv = dev_get_priv(dev);
 	struct ofnode_phandle_args args;
-	u32 treshold, up_treshold, t;
+	u32 threshold, up_threshold, t;
 	ofnode node;
 	int ret;
 
@@ -73,12 +73,12 @@ static int button_adc_of_to_plat(struct udevice *dev)
 		return ret;
 
 	ret = ofnode_read_u32(dev_ofnode(dev->parent),
-			      "keyup-threshold-microvolt", &up_treshold);
+			      "keyup-threshold-microvolt", &up_threshold);
 	if (ret)
 		return ret;
 
 	ret = ofnode_read_u32(dev_ofnode(dev), "press-threshold-microvolt",
-			      &treshold);
+			      &threshold);
 	if (ret)
 		return ret;
 
@@ -87,13 +87,13 @@ static int button_adc_of_to_plat(struct udevice *dev)
 		if (ret)
 			return ret;
 
-		if (t > treshold)
-			up_treshold = t;
+		if (t > threshold)
+			up_threshold = t;
 	}
 
 	priv->channel = args.args[0];
-	priv->min = treshold;
-	priv->max = up_treshold;
+	priv->min = threshold;
+	priv->max = up_threshold;
 
 	return ret;
 }
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] button: adc: fix treshold typo
@ 2021-02-23 15:10   ` Neil Armstrong
  0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2021-02-23 15:10 UTC (permalink / raw)
  To: trini; +Cc: u-boot, m.szyprowski, u-boot-amlogic, Neil Armstrong

Fix the treshold typo in code by threshold.

Fixes: c0165c85c3 ("button: add a simple Analog to Digital Converter device based button driver")
Suggested-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/button/button-adc.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/button/button-adc.c b/drivers/button/button-adc.c
index eed86564fb..fd896c76f9 100644
--- a/drivers/button/button-adc.c
+++ b/drivers/button/button-adc.c
@@ -55,7 +55,7 @@ static int button_adc_of_to_plat(struct udevice *dev)
 	struct button_uc_plat *uc_plat = dev_get_uclass_plat(dev);
 	struct button_adc_priv *priv = dev_get_priv(dev);
 	struct ofnode_phandle_args args;
-	u32 treshold, up_treshold, t;
+	u32 threshold, up_threshold, t;
 	ofnode node;
 	int ret;
 
@@ -73,12 +73,12 @@ static int button_adc_of_to_plat(struct udevice *dev)
 		return ret;
 
 	ret = ofnode_read_u32(dev_ofnode(dev->parent),
-			      "keyup-threshold-microvolt", &up_treshold);
+			      "keyup-threshold-microvolt", &up_threshold);
 	if (ret)
 		return ret;
 
 	ret = ofnode_read_u32(dev_ofnode(dev), "press-threshold-microvolt",
-			      &treshold);
+			      &threshold);
 	if (ret)
 		return ret;
 
@@ -87,13 +87,13 @@ static int button_adc_of_to_plat(struct udevice *dev)
 		if (ret)
 			return ret;
 
-		if (t > treshold)
-			up_treshold = t;
+		if (t > threshold)
+			up_threshold = t;
 	}
 
 	priv->channel = args.args[0];
-	priv->min = treshold;
-	priv->max = up_treshold;
+	priv->min = threshold;
+	priv->max = up_threshold;
 
 	return ret;
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] button: adc: fix treshold typo
  2021-02-23 15:10   ` Neil Armstrong
  (?)
@ 2021-02-23 18:18   ` Marek Szyprowski
  2021-03-08  9:44       ` Neil Armstrong
  -1 siblings, 1 reply; 5+ messages in thread
From: Marek Szyprowski @ 2021-02-23 18:18 UTC (permalink / raw)
  To: u-boot

On 23.02.2021 16:10, Neil Armstrong wrote:
> Fix the treshold typo in code by threshold.
>
> Fixes: c0165c85c3 ("button: add a simple Analog to Digital Converter device based button driver")
> Suggested-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>   drivers/button/button-adc.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/button/button-adc.c b/drivers/button/button-adc.c
> index eed86564fb..fd896c76f9 100644
> --- a/drivers/button/button-adc.c
> +++ b/drivers/button/button-adc.c
> @@ -55,7 +55,7 @@ static int button_adc_of_to_plat(struct udevice *dev)
>   	struct button_uc_plat *uc_plat = dev_get_uclass_plat(dev);
>   	struct button_adc_priv *priv = dev_get_priv(dev);
>   	struct ofnode_phandle_args args;
> -	u32 treshold, up_treshold, t;
> +	u32 threshold, up_threshold, t;
>   	ofnode node;
>   	int ret;
>   
> @@ -73,12 +73,12 @@ static int button_adc_of_to_plat(struct udevice *dev)
>   		return ret;
>   
>   	ret = ofnode_read_u32(dev_ofnode(dev->parent),
> -			      "keyup-threshold-microvolt", &up_treshold);
> +			      "keyup-threshold-microvolt", &up_threshold);
>   	if (ret)
>   		return ret;
>   
>   	ret = ofnode_read_u32(dev_ofnode(dev), "press-threshold-microvolt",
> -			      &treshold);
> +			      &threshold);
>   	if (ret)
>   		return ret;
>   
> @@ -87,13 +87,13 @@ static int button_adc_of_to_plat(struct udevice *dev)
>   		if (ret)
>   			return ret;
>   
> -		if (t > treshold)
> -			up_treshold = t;
> +		if (t > threshold)
> +			up_threshold = t;
>   	}
>   
>   	priv->channel = args.args[0];
> -	priv->min = treshold;
> -	priv->max = up_treshold;
> +	priv->min = threshold;
> +	priv->max = up_threshold;
>   
>   	return ret;
>   }

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] button: adc: fix treshold typo
  2021-02-23 18:18   ` Marek Szyprowski
@ 2021-03-08  9:44       ` Neil Armstrong
  0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2021-03-08  9:44 UTC (permalink / raw)
  To: u-boot

On 23/02/2021 19:18, Marek Szyprowski wrote:
> On 23.02.2021 16:10, Neil Armstrong wrote:
>> Fix the treshold typo in code by threshold.
>>
>> Fixes: c0165c85c3 ("button: add a simple Analog to Digital Converter device based button driver")
>> Suggested-by: Tom Rini <trini@konsulko.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>>   drivers/button/button-adc.c | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/button/button-adc.c b/drivers/button/button-adc.c
>> index eed86564fb..fd896c76f9 100644
>> --- a/drivers/button/button-adc.c
>> +++ b/drivers/button/button-adc.c
>> @@ -55,7 +55,7 @@ static int button_adc_of_to_plat(struct udevice *dev)
>>   	struct button_uc_plat *uc_plat = dev_get_uclass_plat(dev);
>>   	struct button_adc_priv *priv = dev_get_priv(dev);
>>   	struct ofnode_phandle_args args;
>> -	u32 treshold, up_treshold, t;
>> +	u32 threshold, up_threshold, t;
>>   	ofnode node;
>>   	int ret;
>>   
>> @@ -73,12 +73,12 @@ static int button_adc_of_to_plat(struct udevice *dev)
>>   		return ret;
>>   
>>   	ret = ofnode_read_u32(dev_ofnode(dev->parent),
>> -			      "keyup-threshold-microvolt", &up_treshold);
>> +			      "keyup-threshold-microvolt", &up_threshold);
>>   	if (ret)
>>   		return ret;
>>   
>>   	ret = ofnode_read_u32(dev_ofnode(dev), "press-threshold-microvolt",
>> -			      &treshold);
>> +			      &threshold);
>>   	if (ret)
>>   		return ret;
>>   
>> @@ -87,13 +87,13 @@ static int button_adc_of_to_plat(struct udevice *dev)
>>   		if (ret)
>>   			return ret;
>>   
>> -		if (t > treshold)
>> -			up_treshold = t;
>> +		if (t > threshold)
>> +			up_threshold = t;
>>   	}
>>   
>>   	priv->channel = args.args[0];
>> -	priv->min = treshold;
>> -	priv->max = up_treshold;
>> +	priv->min = threshold;
>> +	priv->max = up_threshold;
>>   
>>   	return ret;
>>   }
> 
> Best regards
> 


Applied to u-boot-amlogic

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] button: adc: fix treshold typo
@ 2021-03-08  9:44       ` Neil Armstrong
  0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2021-03-08  9:44 UTC (permalink / raw)
  To: Marek Szyprowski, trini; +Cc: u-boot, u-boot-amlogic

On 23/02/2021 19:18, Marek Szyprowski wrote:
> On 23.02.2021 16:10, Neil Armstrong wrote:
>> Fix the treshold typo in code by threshold.
>>
>> Fixes: c0165c85c3 ("button: add a simple Analog to Digital Converter device based button driver")
>> Suggested-by: Tom Rini <trini@konsulko.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>>   drivers/button/button-adc.c | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/button/button-adc.c b/drivers/button/button-adc.c
>> index eed86564fb..fd896c76f9 100644
>> --- a/drivers/button/button-adc.c
>> +++ b/drivers/button/button-adc.c
>> @@ -55,7 +55,7 @@ static int button_adc_of_to_plat(struct udevice *dev)
>>   	struct button_uc_plat *uc_plat = dev_get_uclass_plat(dev);
>>   	struct button_adc_priv *priv = dev_get_priv(dev);
>>   	struct ofnode_phandle_args args;
>> -	u32 treshold, up_treshold, t;
>> +	u32 threshold, up_threshold, t;
>>   	ofnode node;
>>   	int ret;
>>   
>> @@ -73,12 +73,12 @@ static int button_adc_of_to_plat(struct udevice *dev)
>>   		return ret;
>>   
>>   	ret = ofnode_read_u32(dev_ofnode(dev->parent),
>> -			      "keyup-threshold-microvolt", &up_treshold);
>> +			      "keyup-threshold-microvolt", &up_threshold);
>>   	if (ret)
>>   		return ret;
>>   
>>   	ret = ofnode_read_u32(dev_ofnode(dev), "press-threshold-microvolt",
>> -			      &treshold);
>> +			      &threshold);
>>   	if (ret)
>>   		return ret;
>>   
>> @@ -87,13 +87,13 @@ static int button_adc_of_to_plat(struct udevice *dev)
>>   		if (ret)
>>   			return ret;
>>   
>> -		if (t > treshold)
>> -			up_treshold = t;
>> +		if (t > threshold)
>> +			up_threshold = t;
>>   	}
>>   
>>   	priv->channel = args.args[0];
>> -	priv->min = treshold;
>> -	priv->max = up_treshold;
>> +	priv->min = threshold;
>> +	priv->max = up_threshold;
>>   
>>   	return ret;
>>   }
> 
> Best regards
> 


Applied to u-boot-amlogic

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-08  9:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210223151049eucas1p2f45c23f278c93b83e1a0812e4370b090@eucas1p2.samsung.com>
2021-02-23 15:10 ` [PATCH] button: adc: fix treshold typo Neil Armstrong
2021-02-23 15:10   ` Neil Armstrong
2021-02-23 18:18   ` Marek Szyprowski
2021-03-08  9:44     ` Neil Armstrong
2021-03-08  9:44       ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.