Re: [Buildroot] [PATCH v2 1/4] support: utils: use python3 explicitly

[Romain Naour <romain.naour@gmail.com>]

Hello Petr,

Le 15/09/2021 à 21:48, Petr Vorel a écrit :
> Python 2 is EOL sice 2020 [1], it's still available on distros, but may not
> be installed by default (as being replaced by python3).
> 
> Thus remove compatibility imports:
> from __future__ import print_function
> from __future__ import absolute_import
> 
> Tested with python3 -m py_compile.
> 
> [1] https://www.python.org/doc/sunset-python-2/
> 
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---

> diff --git a/utils/get-developers b/utils/get-developers
> index 9182b2d85f..22accaf181 100755
> --- a/utils/get-developers
> +++ b/utils/get-developers
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
>  
>  import argparse
>  import getdeveloperlib

There is one remaining __future__ to remove:

utils/getdeveloperlib.py:from __future__ import print_function

It was removed by your patch 3/4 but it was rejected:
http://patchwork.ozlabs.org/project/buildroot/patch/20210915194839.22122-4-petr.vorel@gmail.com/

Maybe it can be removed directly from this patch.

Best regards,
Romain


> diff --git a/utils/size-stats-compare b/utils/size-stats-compare
> index a3d7f250c6..422972e488 100755
> --- a/utils/size-stats-compare
> +++ b/utils/size-stats-compare
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
>  
>  # Copyright (C) 2016 Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>  
> 

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot