From: Petr Vorel <petr.vorel@gmail.com>
To: Romain Naour <romain.naour@gmail.com>
Cc: David Laight <David.Laight@aculab.com>,
Edgar Bonet <bonet@grenoble.cnrs.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/4] support: utils: use python3 explicitly
Date: Tue, 21 Sep 2021 22:57:52 +0200 [thread overview]
Message-ID: <YUpHUKClwm4frUx9@pevik> (raw)
In-Reply-To: <41cb0bdf-845d-ab94-0322-c4d1393f40b8@gmail.com>
Hi Romain,
> Hello Petr,
> Le 15/09/2021 à 21:48, Petr Vorel a écrit :
> > Python 2 is EOL sice 2020 [1], it's still available on distros, but may not
> > be installed by default (as being replaced by python3).
> > Thus remove compatibility imports:
> > from __future__ import print_function
> > from __future__ import absolute_import
> > Tested with python3 -m py_compile.
> > [1] https://www.python.org/doc/sunset-python-2/
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > ---
> > diff --git a/utils/get-developers b/utils/get-developers
> > index 9182b2d85f..22accaf181 100755
> > --- a/utils/get-developers
> > +++ b/utils/get-developers
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/env python3
> > import argparse
> > import getdeveloperlib
> There is one remaining __future__ to remove:
> utils/getdeveloperlib.py:from __future__ import print_function
Thanks!
> It was removed by your patch 3/4 but it was rejected:
> http://patchwork.ozlabs.org/project/buildroot/patch/20210915194839.22122-4-petr.vorel@gmail.com/
I set it as rejected.
> Maybe it can be removed directly from this patch.
Nah, I can send v3 with this fixed.
> Best regards,
> Romain
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-21 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 19:48 [Buildroot] [PATCH v2 0/4] use python3 explicitly Petr Vorel
2021-09-15 19:48 ` [Buildroot] [PATCH v2 1/4] support: utils: " Petr Vorel
2021-09-21 20:20 ` Romain Naour
2021-09-21 20:57 ` Petr Vorel [this message]
2021-09-15 19:48 ` [Buildroot] [PATCH v2 2/4] utils/scanpypi: remove python2 compatibility imports Petr Vorel
2021-09-15 19:48 ` [Buildroot] [PATCH v2 3/4] utils/getdeveloperlib.py: use python3 explicitly Petr Vorel
2021-09-16 18:42 ` Arnout Vandecappelle
2021-09-16 19:51 ` Petr Vorel
2021-09-15 19:48 ` [Buildroot] [PATCH v2 4/4] testing/tests/package: " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUpHUKClwm4frUx9@pevik \
--to=petr.vorel@gmail.com \
--cc=David.Laight@aculab.com \
--cc=bonet@grenoble.cnrs.fr \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.