From: Philippe Schenker <dev@pschenker.ch>
To: Deren Wu <deren.wu@mediatek.com>, Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
linux@leemhuis.info, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
YN Chen <YN.Chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
Date: Tue, 12 Apr 2022 14:30:34 +0200 [thread overview]
Message-ID: <420241bdd4fdbd1379f59e38571ec04c580eba41.camel@pschenker.ch> (raw)
In-Reply-To: <668f1310cc78b17c24ce7be10f5f907d5578e280.camel@mediatek.com>
On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
> On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
> > Philippe Schenker <dev@pschenker.ch> writes:
> >
> > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
> > >
> > > This commit introduces a regression on some systems where the
> > > kernel is
> > > crashing in different locations after a reboot was issued.
> > >
> > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest
> > > firmware.
> > >
> > > Link:
> > > https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/__;!!CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14J4iDycWA9cq36Y$
> > >
> > > Signed-off-by: Philippe Schenker <dev@pschenker.ch>
> >
> > Can I take this to wireless tree? Felix, ack?
> >
> > I'll also add:
> >
> > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
> >
>
> Hi Kalle,
>
> We have a patch for a similar problem. Can you wait for the
> verification by Philippe?
> Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure
> after
> reboot")
> Link:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76?id=602cc0c9618a819ab00ea3c9400742a0ca318380
>
> I can reproduce the problem in my v5.16-rc5 desktop. And the issue can
> be fixed when the patch applied.
>
>
> Hi Philippe,
>
> Can you please help to check the patch in your platform?
Aah, so I have been a bit late with my painful bisecting. Should have
checked -next before... Whatever, your patch works just fine. I cherry
picked your patch on top mainline v5.17 and it works just fine with that
one.
Thank you very much Deren!
Sorry Kalle for the overlapping revert, please do not apply it.
Best Regards,
Philippe
>
>
> Regards,
> Deren
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Philippe Schenker <dev@pschenker.ch>
To: Deren Wu <deren.wu@mediatek.com>, Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
linux@leemhuis.info, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
YN Chen <YN.Chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
Date: Tue, 12 Apr 2022 14:30:34 +0200 [thread overview]
Message-ID: <420241bdd4fdbd1379f59e38571ec04c580eba41.camel@pschenker.ch> (raw)
In-Reply-To: <668f1310cc78b17c24ce7be10f5f907d5578e280.camel@mediatek.com>
On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
> On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
> > Philippe Schenker <dev@pschenker.ch> writes:
> >
> > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
> > >
> > > This commit introduces a regression on some systems where the
> > > kernel is
> > > crashing in different locations after a reboot was issued.
> > >
> > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest
> > > firmware.
> > >
> > > Link:
> > > https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/__;!!CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14J4iDycWA9cq36Y$
> > >
> > > Signed-off-by: Philippe Schenker <dev@pschenker.ch>
> >
> > Can I take this to wireless tree? Felix, ack?
> >
> > I'll also add:
> >
> > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
> >
>
> Hi Kalle,
>
> We have a patch for a similar problem. Can you wait for the
> verification by Philippe?
> Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure
> after
> reboot")
> Link:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76?id=602cc0c9618a819ab00ea3c9400742a0ca318380
>
> I can reproduce the problem in my v5.16-rc5 desktop. And the issue can
> be fixed when the patch applied.
>
>
> Hi Philippe,
>
> Can you please help to check the patch in your platform?
Aah, so I have been a bit late with my painful bisecting. Should have
checked -next before... Whatever, your patch works just fine. I cherry
picked your patch on top mainline v5.17 and it works just fine with that
one.
Thank you very much Deren!
Sorry Kalle for the overlapping revert, please do not apply it.
Best Regards,
Philippe
>
>
> Regards,
> Deren
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Philippe Schenker <dev@pschenker.ch>
To: Deren Wu <deren.wu@mediatek.com>, Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
linux@leemhuis.info, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
YN Chen <YN.Chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
Date: Tue, 12 Apr 2022 14:30:34 +0200 [thread overview]
Message-ID: <420241bdd4fdbd1379f59e38571ec04c580eba41.camel@pschenker.ch> (raw)
In-Reply-To: <668f1310cc78b17c24ce7be10f5f907d5578e280.camel@mediatek.com>
On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
> On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
> > Philippe Schenker <dev@pschenker.ch> writes:
> >
> > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
> > >
> > > This commit introduces a regression on some systems where the
> > > kernel is
> > > crashing in different locations after a reboot was issued.
> > >
> > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest
> > > firmware.
> > >
> > > Link:
> > > https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/__;!!CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14J4iDycWA9cq36Y$
> > >
> > > Signed-off-by: Philippe Schenker <dev@pschenker.ch>
> >
> > Can I take this to wireless tree? Felix, ack?
> >
> > I'll also add:
> >
> > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
> >
>
> Hi Kalle,
>
> We have a patch for a similar problem. Can you wait for the
> verification by Philippe?
> Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure
> after
> reboot")
> Link:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76?id=602cc0c9618a819ab00ea3c9400742a0ca318380
>
> I can reproduce the problem in my v5.16-rc5 desktop. And the issue can
> be fixed when the patch applied.
>
>
> Hi Philippe,
>
> Can you please help to check the patch in your platform?
Aah, so I have been a bit late with my painful bisecting. Should have
checked -next before... Whatever, your patch works just fine. I cherry
picked your patch on top mainline v5.17 and it works just fine with that
one.
Thank you very much Deren!
Sorry Kalle for the overlapping revert, please do not apply it.
Best Regards,
Philippe
>
>
> Regards,
> Deren
>
next prev parent reply other threads:[~2022-04-12 12:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:04 [PATCH] Revert "mt76: mt7921: enable aspm by default" Philippe Schenker
2022-04-12 9:04 ` Philippe Schenker
2022-04-12 9:04 ` Philippe Schenker
2022-04-12 9:37 ` Kalle Valo
2022-04-12 9:37 ` Kalle Valo
2022-04-12 9:37 ` Kalle Valo
2022-04-12 9:55 ` Thorsten Leemhuis
2022-04-12 9:55 ` Thorsten Leemhuis
2022-04-12 9:55 ` Thorsten Leemhuis
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
2022-04-27 7:32 ` Thorsten Leemhuis
2022-04-27 7:32 ` Thorsten Leemhuis
2022-04-27 7:32 ` Thorsten Leemhuis
2022-04-12 11:06 ` Deren Wu
2022-04-12 11:06 ` Deren Wu
2022-04-12 11:06 ` Deren Wu
2022-04-12 12:30 ` Philippe Schenker [this message]
2022-04-12 12:30 ` Philippe Schenker
2022-04-12 12:30 ` Philippe Schenker
2022-04-12 12:45 ` Kalle Valo
2022-04-12 12:45 ` Kalle Valo
2022-04-12 12:45 ` Kalle Valo
2022-06-01 8:28 ` Philippe Schenker
2022-06-01 8:28 ` Philippe Schenker
2022-06-01 8:28 ` Philippe Schenker
2022-06-01 8:58 ` Kalle Valo
2022-06-01 8:58 ` Kalle Valo
2022-06-01 8:58 ` Kalle Valo
2022-06-01 16:55 ` Deren Wu
2022-06-01 16:55 ` Deren Wu
2022-06-01 16:55 ` Deren Wu
2022-06-02 10:00 ` Philippe Schenker
2022-06-02 10:00 ` Philippe Schenker
2022-06-02 10:00 ` Philippe Schenker
[not found] <e93aef5c9f8a97efe23cfb5892f78f919ce328e7.camel@pschenker.ch--annotate>
2022-06-01 22:23 ` sean.wang
2022-06-01 22:23 ` sean.wang
2022-06-01 22:23 ` sean.wang
2022-06-02 8:44 ` Philippe Schenker
2022-06-02 8:44 ` Philippe Schenker
2022-06-02 8:44 ` Philippe Schenker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420241bdd4fdbd1379f59e38571ec04c580eba41.camel@pschenker.ch \
--to=dev@pschenker.ch \
--cc=YN.Chen@mediatek.com \
--cc=davem@davemloft.net \
--cc=deren.wu@mediatek.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.