* [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix
@ 2017-01-01 16:48 ` Bhumika Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Bhumika Goyal @ 2017-01-01 16:36 UTC (permalink / raw)
To: linux-kernel, linux-fbdev; +Cc: julia.lawall, tomi.valkeinen, Bhumika Goyal
The object maxinefb_fix of type fb_fix_screeninfo is never referenced
after initialization by maxinefb_init. In the init function, the object
and one of its fields is only stored into another variable. So, the
object and its fields are never referenced anywhere after initialization
and therefore add __initdata to its declaration.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/video/fbdev/maxinefb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
index 5cf52d3..cab7333 100644
--- a/drivers/video/fbdev/maxinefb.c
+++ b/drivers/video/fbdev/maxinefb.c
@@ -51,7 +51,7 @@
.vmode = FB_VMODE_NONINTERLACED,
};
-static struct fb_fix_screeninfo maxinefb_fix = {
+static struct fb_fix_screeninfo maxinefb_fix __initdata = {
.id = "Maxine",
.smem_len = (1024*768),
.type = FB_TYPE_PACKED_PIXELS,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix
@ 2017-01-01 16:48 ` Bhumika Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Bhumika Goyal @ 2017-01-01 16:48 UTC (permalink / raw)
To: linux-kernel, linux-fbdev; +Cc: julia.lawall, tomi.valkeinen, Bhumika Goyal
The object maxinefb_fix of type fb_fix_screeninfo is never referenced
after initialization by maxinefb_init. In the init function, the object
and one of its fields is only stored into another variable. So, the
object and its fields are never referenced anywhere after initialization
and therefore add __initdata to its declaration.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/video/fbdev/maxinefb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
index 5cf52d3..cab7333 100644
--- a/drivers/video/fbdev/maxinefb.c
+++ b/drivers/video/fbdev/maxinefb.c
@@ -51,7 +51,7 @@
.vmode = FB_VMODE_NONINTERLACED,
};
-static struct fb_fix_screeninfo maxinefb_fix = {
+static struct fb_fix_screeninfo maxinefb_fix __initdata = {
.id = "Maxine",
.smem_len = (1024*768),
.type = FB_TYPE_PACKED_PIXELS,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix
[not found] ` <CGME20170111130145epcas1p395eef0ab42ede2c67604aa5a86c63618@epcas1p3.samsung.com>
@ 2017-01-11 13:01 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-01-11 13:01 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: linux-kernel, linux-fbdev, julia.lawall, tomi.valkeinen
Hi,
On Sunday, January 01, 2017 10:06:17 PM Bhumika Goyal wrote:
> The object maxinefb_fix of type fb_fix_screeninfo is never referenced
> after initialization by maxinefb_init. In the init function, the object
> and one of its fields is only stored into another variable. So, the
> object and its fields are never referenced anywhere after initialization
> and therefore add __initdata to its declaration.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Thanks, queued fpr 4.11.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/maxinefb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
> index 5cf52d3..cab7333 100644
> --- a/drivers/video/fbdev/maxinefb.c
> +++ b/drivers/video/fbdev/maxinefb.c
> @@ -51,7 +51,7 @@
> .vmode = FB_VMODE_NONINTERLACED,
> };
>
> -static struct fb_fix_screeninfo maxinefb_fix = {
> +static struct fb_fix_screeninfo maxinefb_fix __initdata = {
> .id = "Maxine",
> .smem_len = (1024*768),
> .type = FB_TYPE_PACKED_PIXELS,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix
@ 2017-01-11 13:01 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-01-11 13:01 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: linux-kernel, linux-fbdev, julia.lawall, tomi.valkeinen
Hi,
On Sunday, January 01, 2017 10:06:17 PM Bhumika Goyal wrote:
> The object maxinefb_fix of type fb_fix_screeninfo is never referenced
> after initialization by maxinefb_init. In the init function, the object
> and one of its fields is only stored into another variable. So, the
> object and its fields are never referenced anywhere after initialization
> and therefore add __initdata to its declaration.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Thanks, queued fpr 4.11.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/maxinefb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
> index 5cf52d3..cab7333 100644
> --- a/drivers/video/fbdev/maxinefb.c
> +++ b/drivers/video/fbdev/maxinefb.c
> @@ -51,7 +51,7 @@
> .vmode = FB_VMODE_NONINTERLACED,
> };
>
> -static struct fb_fix_screeninfo maxinefb_fix = {
> +static struct fb_fix_screeninfo maxinefb_fix __initdata = {
> .id = "Maxine",
> .smem_len = (1024*768),
> .type = FB_TYPE_PACKED_PIXELS,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-11 13:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-01 16:36 [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix Bhumika Goyal
2017-01-01 16:48 ` Bhumika Goyal
[not found] ` <CGME20170111130145epcas1p395eef0ab42ede2c67604aa5a86c63618@epcas1p3.samsung.com>
2017-01-11 13:01 ` Bartlomiej Zolnierkiewicz
2017-01-11 13:01 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.