All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/i915: correct the pitch check for NV12 framebuffer
@ 2018-12-12  0:39 Dongseong Hwang
  2018-12-12  1:06 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 15+ messages in thread
From: Dongseong Hwang @ 2018-12-12  0:39 UTC (permalink / raw)
  To: dri-devel, intel-gfx
  Cc: Vidya Srinivas, Juha-Pekka Heikkila, airlied, rodrigo.vivi,
	Chandra Konduru

framebuffer for NV12 requires the pitch to the multiplier of 4, instead
of the width. This patch corrects it.

For instance, a 480p video, whose width and pitch are 854 and 896
respectively, is excluded for NV12 plane so far.

Signed-off-by: Dongseong Hwang <dongseong.hwang@intel.com>
Cc: Chandra Konduru <chandra.konduru@intel.com>
Cc: Vidya Srinivas <vidya.srinivas@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 13e5650..8a3de12 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14600,7 +14600,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
 	if (fb->format->format == DRM_FORMAT_NV12 &&
 	    (fb->width < SKL_MIN_YUV_420_SRC_W ||
 	     fb->height < SKL_MIN_YUV_420_SRC_H ||
-	     (fb->width % 4) != 0 || (fb->height % 4) != 0)) {
+	     (fb->pitches[0] % 4) != 0 || (fb->height % 4) != 0)) {
 		DRM_DEBUG_KMS("src dimensions not correct for NV12\n");
 		goto err;
 	}
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-01-25 21:34 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12  0:39 [PATCH v2] drm/i915: correct the pitch check for NV12 framebuffer Dongseong Hwang
2018-12-12  1:06 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-12-12  4:59 ` ✓ Fi.CI.IGT: " Patchwork
2018-12-12 20:24 ` [PATCH v2] " Ville Syrjälä
2018-12-12 20:33   ` Daniel Vetter
2018-12-12 21:15     ` Ville Syrjälä
2018-12-12 21:18       ` [Intel-gfx] " Singaiah Chintalapudi
2018-12-13  0:51       ` Hwang, Dongseong
2018-12-19  8:29 ` [PATCH v3] " raviraj.p.sitaram
2019-01-22 16:39   ` Sitaram, Raviraj P
2019-01-25 21:34   ` Ville Syrjälä
2018-12-19  9:19 ` ✓ Fi.CI.BAT: success for drm/i915: correct the pitch check for NV12 framebuffer (rev2) Patchwork
2018-12-19 10:51 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-23  6:53 ` ✓ Fi.CI.BAT: success for drm/i915: correct the pitch check for NV12 framebuffer (rev3) Patchwork
2019-01-23  9:55 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.