* [bug report] scsi: aacraid: Reorder Adapter status check
@ 2017-02-27 15:31 Dan Carpenter
2017-03-02 19:39 ` Dave Carroll
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-02-27 15:31 UTC (permalink / raw)
To: RaghavaAditya.Renukunta; +Cc: linux-scsi
Hello Raghava Aditya Renukunta,
The patch c421530bf848: "scsi: aacraid: Reorder Adapter status check"
from Feb 16, 2017, leads to the following static checker warning:
drivers/scsi/aacraid/src.c:471 aac_src_check_health()
warn: was shift intended here '(status > 16)'
drivers/scsi/aacraid/src.c
464 */
465 return 0;
466
467 err_out:
468 return -1;
469
470 err_blink:
471 return (status > 16) & 0xFF;
^^^^^^^^^^^^^^^^^^^
Issue #1: This is obviously a typo.
472 }
Issue #2: The caller checks for if the return is greater than 2. It
never is. We can remove this dead code.
Issue #3: The caller passes "bled" to aac_send_iop_reset() which
ignores it. What's up with that? Either it's a bug or we
should delete that dead code.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [bug report] scsi: aacraid: Reorder Adapter status check
2017-02-27 15:31 [bug report] scsi: aacraid: Reorder Adapter status check Dan Carpenter
@ 2017-03-02 19:39 ` Dave Carroll
0 siblings, 0 replies; 2+ messages in thread
From: Dave Carroll @ 2017-03-02 19:39 UTC (permalink / raw)
To: Dan Carpenter, Raghava Aditya Renukunta; +Cc: linux-scsi
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> owner@vger.kernel.org] On Behalf Of Dan Carpenter
> Sent: Monday, February 27, 2017 8:32 AM
> To: Raghava Aditya Renukunta
> Cc: linux-scsi@vger.kernel.org
> Subject: [bug report] scsi: aacraid: Reorder Adapter status check
>
>
> The patch c421530bf848: "scsi: aacraid: Reorder Adapter status check"
> from Feb 16, 2017, leads to the following static checker warning:
>
> drivers/scsi/aacraid/src.c:471 aac_src_check_health()
> warn: was shift intended here '(status > 16)'
>
> drivers/scsi/aacraid/src.c
> 464 */
> 465 return 0;
> 466
> 467 err_out:
> 468 return -1;
> 469
> 470 err_blink:
> 471 return (status > 16) & 0xFF;
> ^^^^^^^^^^^^^^^^^^^ Issue #1: This is obviously a typo.
Agreed, will submit a correction ... should be >>
>
> 472 }
>
> Issue #2: The caller checks for if the return is greater than 2. It
> never is. We can remove this dead code.
That would be the blink led returned from the controller which would be greater than 2
>
> Issue #3: The caller passes "bled" to aac_send_iop_reset() which
> ignores it. What's up with that? Either it's a bug or we
> should delete that dead code.
When we have gotten all caught up, we will be printing the blink led as part of the iop_reset
Thanks, -Dave
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-02 23:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-27 15:31 [bug report] scsi: aacraid: Reorder Adapter status check Dan Carpenter
2017-03-02 19:39 ` Dave Carroll
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.