* [PATCH] ARM: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4
[not found] <CGME20201218104353eucas1p266e5210f6272fc60b316881e3fb3c210@eucas1p2.samsung.com>
@ 2020-12-18 10:43 ` Marek Szyprowski
0 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2020-12-18 10:43 UTC (permalink / raw)
To: u-boot
For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
pin to the high impedance mode, otherwise the board is stuck in the
middle of loading early stages of the bootloader from SD card.
This can be achieved by using the OPEN_DRAIN flag instead if the
ACTIVE_HIGH, what will leave the pin in input to achieve high state (pin
has the pull-up) and solve the issue.
Suggested-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
This is a result of the discussion in the "[PATCH/RFC] board: amlogic:
Fix Odroid-C4 SD card reboot issue" thread:
https://lists.denx.de/pipermail/u-boot/2020-December/435295.html
Patch for the upstream Linux DTS has been already submitted:
https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski at samsung.com/
---
arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
index c431988075..fbcc8287c5 100644
--- a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
+++ b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
@@ -11,3 +11,7 @@
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
};
+
+&tflash_vdd {
+ gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>;
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4
@ 2020-12-18 10:43 ` Marek Szyprowski
0 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2020-12-18 10:43 UTC (permalink / raw)
To: u-boot, u-boot-amlogic
Cc: Marek Szyprowski, Neil Armstrong, Jaehoon Chung,
Bartlomiej Zolnierkiewicz
For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
pin to the high impedance mode, otherwise the board is stuck in the
middle of loading early stages of the bootloader from SD card.
This can be achieved by using the OPEN_DRAIN flag instead if the
ACTIVE_HIGH, what will leave the pin in input to achieve high state (pin
has the pull-up) and solve the issue.
Suggested-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
This is a result of the discussion in the "[PATCH/RFC] board: amlogic:
Fix Odroid-C4 SD card reboot issue" thread:
https://lists.denx.de/pipermail/u-boot/2020-December/435295.html
Patch for the upstream Linux DTS has been already submitted:
https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski@samsung.com/
---
arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
index c431988075..fbcc8287c5 100644
--- a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
+++ b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
@@ -11,3 +11,7 @@
snps,reset-delays-us = <0 10000 1000000>;
snps,reset-active-low;
};
+
+&tflash_vdd {
+ gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>;
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4
2020-12-18 10:43 ` Marek Szyprowski
@ 2020-12-18 10:47 ` Neil Armstrong
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-12-18 10:47 UTC (permalink / raw)
To: u-boot
On 18/12/2020 11:43, Marek Szyprowski wrote:
> For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
> pin to the high impedance mode, otherwise the board is stuck in the
> middle of loading early stages of the bootloader from SD card.
>
> This can be achieved by using the OPEN_DRAIN flag instead if the
> ACTIVE_HIGH, what will leave the pin in input to achieve high state (pin
> has the pull-up) and solve the issue.
>
> Suggested-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> This is a result of the discussion in the "[PATCH/RFC] board: amlogic:
> Fix Odroid-C4 SD card reboot issue" thread:
> https://lists.denx.de/pipermail/u-boot/2020-December/435295.html
>
> Patch for the upstream Linux DTS has been already submitted:
> https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski at samsung.com/
> ---
> arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> index c431988075..fbcc8287c5 100644
> --- a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> +++ b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> @@ -11,3 +11,7 @@
> snps,reset-delays-us = <0 10000 1000000>;
> snps,reset-active-low;
> };
> +
> +&tflash_vdd {
> + gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>;
> +};
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applying it to u-boot-amlogic, and will send it asap so it's applied for v2020.10
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4
@ 2020-12-18 10:47 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-12-18 10:47 UTC (permalink / raw)
To: Marek Szyprowski, u-boot, u-boot-amlogic
Cc: Jaehoon Chung, Bartlomiej Zolnierkiewicz
On 18/12/2020 11:43, Marek Szyprowski wrote:
> For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
> pin to the high impedance mode, otherwise the board is stuck in the
> middle of loading early stages of the bootloader from SD card.
>
> This can be achieved by using the OPEN_DRAIN flag instead if the
> ACTIVE_HIGH, what will leave the pin in input to achieve high state (pin
> has the pull-up) and solve the issue.
>
> Suggested-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> This is a result of the discussion in the "[PATCH/RFC] board: amlogic:
> Fix Odroid-C4 SD card reboot issue" thread:
> https://lists.denx.de/pipermail/u-boot/2020-December/435295.html
>
> Patch for the upstream Linux DTS has been already submitted:
> https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski@samsung.com/
> ---
> arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> index c431988075..fbcc8287c5 100644
> --- a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> +++ b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> @@ -11,3 +11,7 @@
> snps,reset-delays-us = <0 10000 1000000>;
> snps,reset-active-low;
> };
> +
> +&tflash_vdd {
> + gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>;
> +};
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applying it to u-boot-amlogic, and will send it asap so it's applied for v2020.10
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4
2020-12-18 10:47 ` Neil Armstrong
@ 2020-12-18 10:59 ` Mark Kettenis
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Kettenis @ 2020-12-18 10:59 UTC (permalink / raw)
To: u-boot
> From: Neil Armstrong <narmstrong@baylibre.com>
> Date: Fri, 18 Dec 2020 11:47:02 +0100
>
> On 18/12/2020 11:43, Marek Szyprowski wrote:
> > For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
> > pin to the high impedance mode, otherwise the board is stuck in the
> > middle of loading early stages of the bootloader from SD card.
> >
> > This can be achieved by using the OPEN_DRAIN flag instead if the
> > ACTIVE_HIGH, what will leave the pin in input to achieve high state (pin
> > has the pull-up) and solve the issue.
> >
> > Suggested-by: Neil Armstrong <narmstrong@baylibre.com>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > This is a result of the discussion in the "[PATCH/RFC] board: amlogic:
> > Fix Odroid-C4 SD card reboot issue" thread:
> > https://lists.denx.de/pipermail/u-boot/2020-December/435295.html
> >
> > Patch for the upstream Linux DTS has been already submitted:
> > https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski at samsung.com/
> > ---
> > arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> > index c431988075..fbcc8287c5 100644
> > --- a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> > +++ b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> > @@ -11,3 +11,7 @@
> > snps,reset-delays-us = <0 10000 1000000>;
> > snps,reset-active-low;
> > };
> > +
> > +&tflash_vdd {
> > + gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>;
> > +};
> >
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Applying it to u-boot-amlogic, and will send it asap so it's applied for v2020.10
Cool. It works on the HC4 as well.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4
@ 2020-12-18 10:59 ` Mark Kettenis
0 siblings, 0 replies; 6+ messages in thread
From: Mark Kettenis @ 2020-12-18 10:59 UTC (permalink / raw)
To: Neil Armstrong
Cc: m.szyprowski, u-boot, u-boot-amlogic, jh80.chung, b.zolnierkie
> From: Neil Armstrong <narmstrong@baylibre.com>
> Date: Fri, 18 Dec 2020 11:47:02 +0100
>
> On 18/12/2020 11:43, Marek Szyprowski wrote:
> > For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
> > pin to the high impedance mode, otherwise the board is stuck in the
> > middle of loading early stages of the bootloader from SD card.
> >
> > This can be achieved by using the OPEN_DRAIN flag instead if the
> > ACTIVE_HIGH, what will leave the pin in input to achieve high state (pin
> > has the pull-up) and solve the issue.
> >
> > Suggested-by: Neil Armstrong <narmstrong@baylibre.com>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > This is a result of the discussion in the "[PATCH/RFC] board: amlogic:
> > Fix Odroid-C4 SD card reboot issue" thread:
> > https://lists.denx.de/pipermail/u-boot/2020-December/435295.html
> >
> > Patch for the upstream Linux DTS has been already submitted:
> > https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski@samsung.com/
> > ---
> > arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> > index c431988075..fbcc8287c5 100644
> > --- a/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> > +++ b/arch/arm/dts/meson-sm1-odroid-c4-u-boot.dtsi
> > @@ -11,3 +11,7 @@
> > snps,reset-delays-us = <0 10000 1000000>;
> > snps,reset-active-low;
> > };
> > +
> > +&tflash_vdd {
> > + gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>;
> > +};
> >
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Applying it to u-boot-amlogic, and will send it asap so it's applied for v2020.10
Cool. It works on the HC4 as well.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-18 10:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20201218104353eucas1p266e5210f6272fc60b316881e3fb3c210@eucas1p2.samsung.com>
2020-12-18 10:43 ` [PATCH] ARM: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4 Marek Szyprowski
2020-12-18 10:43 ` Marek Szyprowski
2020-12-18 10:47 ` Neil Armstrong
2020-12-18 10:47 ` Neil Armstrong
2020-12-18 10:59 ` Mark Kettenis
2020-12-18 10:59 ` Mark Kettenis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.