* [PATCH] bcache: Use PTR_ERR_OR_ZERO()
@ 2017-11-27 23:05 Vasyl Gomonovych
2017-11-28 3:38 ` Coly Li
2017-11-28 16:18 ` Michael Lyle
0 siblings, 2 replies; 3+ messages in thread
From: Vasyl Gomonovych @ 2017-11-27 23:05 UTC (permalink / raw)
To: kent.overstreet, shli, mingo, axboe, gregkh, kstewart,
linux-bcache, linux-raid
Cc: linux-kernel, gomonovych
Fix ptr_ret.cocci warnings:
drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/md/bcache/btree.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 658c54b3b07a..f43e49979cb2 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -1797,10 +1797,7 @@ static int bch_gc_thread(void *arg)
int bch_gc_thread_start(struct cache_set *c)
{
c->gc_thread = kthread_run(bch_gc_thread, c, "bcache_gc");
- if (IS_ERR(c->gc_thread))
- return PTR_ERR(c->gc_thread);
-
- return 0;
+ return PTR_ERR_OR_ZERO(c->gc_thread);
}
/* Initial partial gc */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bcache: Use PTR_ERR_OR_ZERO()
2017-11-27 23:05 [PATCH] bcache: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-11-28 3:38 ` Coly Li
2017-11-28 16:18 ` Michael Lyle
1 sibling, 0 replies; 3+ messages in thread
From: Coly Li @ 2017-11-28 3:38 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: kent.overstreet, shli, mingo, axboe, gregkh, kstewart,
linux-bcache, linux-raid, linux-kernel
On 28/11/2017 7:05 AM, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Looks good to me. Reviewed-by: Coly Li <colyli@suse.de>
Thanks.
Coly Li
> ---
> drivers/md/bcache/btree.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 658c54b3b07a..f43e49979cb2 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1797,10 +1797,7 @@ static int bch_gc_thread(void *arg)
> int bch_gc_thread_start(struct cache_set *c)
> {
> c->gc_thread = kthread_run(bch_gc_thread, c, "bcache_gc");
> - if (IS_ERR(c->gc_thread))
> - return PTR_ERR(c->gc_thread);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(c->gc_thread);
> }
>
> /* Initial partial gc */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bcache: Use PTR_ERR_OR_ZERO()
2017-11-27 23:05 [PATCH] bcache: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-28 3:38 ` Coly Li
@ 2017-11-28 16:18 ` Michael Lyle
1 sibling, 0 replies; 3+ messages in thread
From: Michael Lyle @ 2017-11-28 16:18 UTC (permalink / raw)
To: Vasyl Gomonovych, kent.overstreet, shli, mingo, axboe, gregkh,
kstewart, linux-bcache, linux-raid
Cc: linux-kernel
On 11/27/2017 03:05 PM, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
lgtm.
Reviewed-by: Michael Lyle <mlyle@lyle.org>
Will carry in my tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-28 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27 23:05 [PATCH] bcache: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-28 3:38 ` Coly Li
2017-11-28 16:18 ` Michael Lyle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.