All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/systemd: don't treat ld warnings as errors
@ 2022-02-06 10:37 Giulio Benetti
  2022-02-06 10:39 ` Giulio Benetti
  0 siblings, 1 reply; 2+ messages in thread
From: Giulio Benetti @ 2022-02-06 10:37 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Norbert Lange, Yann E . MORIN

Nios2 ld emits warnings like:
'
/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/nios2-linux-gnu/7.3.1/../../../../nios2-linux-gnu/bin/ld: FDE encoding in /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/nios2-linux-gnu/7.3.1/libgcc.a(_umoddi3.o)(.eh_frame) prevents .eh_frame_hdr table being created.
'
Since '-Wl,--fatal-warnings' is passed by default, build fails, so don't
treat warnings as errors by appending "-Wl,--no-fatal-warnings" to
SYSTEMD_LDFLAGS the same way I've done for Microblaze in commit:
https://git.buildroot.net/buildroot/commit/?id=cc53d5357d84ff9b78d76e45ce216061df8a37c1

Fixes:
http://autobuild.buildroot.net/results/5fc884e11e46ab165ea21c8e8f2901516d79ff80/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/systemd/systemd.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index 5626b54e8e..0f7da5cb28 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -90,6 +90,11 @@ SYSTEMD_CONF_OPTS += \
 	-Dumount-path=/usr/bin/umount \
 	-Dutmp=false
 
+ifeq ($(BR2_nios),y)
+# Nios2 ld emits warnings, make warnings not to be treated as errors
+SYSTEMD_LDFLAGS = $(TARGET_LDFLAGS) -Wl,--no-fatal-warnings
+endif
+
 ifeq ($(BR2_PACKAGE_ACL),y)
 SYSTEMD_DEPENDENCIES += acl
 SYSTEMD_CONF_OPTS += -Dacl=true
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH] package/systemd: don't treat ld warnings as errors
  2022-02-06 10:37 [Buildroot] [PATCH] package/systemd: don't treat ld warnings as errors Giulio Benetti
@ 2022-02-06 10:39 ` Giulio Benetti
  0 siblings, 0 replies; 2+ messages in thread
From: Giulio Benetti @ 2022-02-06 10:39 UTC (permalink / raw)
  To: buildroot; +Cc: Norbert Lange, Yann E . MORIN

On 06/02/22 11:37, Giulio Benetti wrote:
> Nios2 ld emits warnings like:
> '
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/nios2-linux-gnu/7.3.1/../../../../nios2-linux-gnu/bin/ld: FDE encoding in /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/nios2-linux-gnu/7.3.1/libgcc.a(_umoddi3.o)(.eh_frame) prevents .eh_frame_hdr table being created.
> '
> Since '-Wl,--fatal-warnings' is passed by default, build fails, so don't
> treat warnings as errors by appending "-Wl,--no-fatal-warnings" to
> SYSTEMD_LDFLAGS the same way I've done for Microblaze in commit:
> https://git.buildroot.net/buildroot/commit/?id=cc53d5357d84ff9b78d76e45ce216061df8a37c1
> 
> Fixes:
> http://autobuild.buildroot.net/results/5fc884e11e46ab165ea21c8e8f2901516d79ff80/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   package/systemd/systemd.mk | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 5626b54e8e..0f7da5cb28 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -90,6 +90,11 @@ SYSTEMD_CONF_OPTS += \
>   	-Dumount-path=/usr/bin/umount \
>   	-Dutmp=false
>   
> +ifeq ($(BR2_nios),y)

s/BR2_nios/BR2_nios2, I send a V2, please reject this patch

Sorry for the noise
-- 
Giulio Benetti
Benetti Engineering sas

> +# Nios2 ld emits warnings, make warnings not to be treated as errors
> +SYSTEMD_LDFLAGS = $(TARGET_LDFLAGS) -Wl,--no-fatal-warnings
> +endif
> +
>   ifeq ($(BR2_PACKAGE_ACL),y)
>   SYSTEMD_DEPENDENCIES += acl
>   SYSTEMD_CONF_OPTS += -Dacl=true

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-06 10:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-06 10:37 [Buildroot] [PATCH] package/systemd: don't treat ld warnings as errors Giulio Benetti
2022-02-06 10:39 ` Giulio Benetti

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.