* [PATCH v1] Bluetooth: btmtksdio: enable msft opcode
@ 2021-11-26 22:10 Lukasz Bartosik
2021-11-29 8:09 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: Lukasz Bartosik @ 2021-11-26 22:10 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz
Cc: linux-bluetooth, Sean Wang, upstream
From: Łukasz Bartosik <lb@semihalf.com>
Enable msft opcode for btmtksdio driver.
Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
---
drivers/bluetooth/btmtksdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index d9cf0c492e29..2a7a615663b9 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -887,6 +887,7 @@ static int btmtksdio_setup(struct hci_dev *hdev)
if (enable_autosuspend)
pm_runtime_allow(bdev->dev);
+ hci_set_msft_opcode(hdev, 0xFD30);
bt_dev_info(hdev, "Device setup in %llu usecs", duration);
return 0;
--
2.34.0.rc2.393.gf8c9666880-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] Bluetooth: btmtksdio: enable msft opcode
2021-11-26 22:10 [PATCH v1] Bluetooth: btmtksdio: enable msft opcode Lukasz Bartosik
@ 2021-11-29 8:09 ` Marcel Holtmann
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2021-11-29 8:09 UTC (permalink / raw)
To: Lukasz Bartosik
Cc: Johan Hedberg, Luiz Augusto von Dentz, linux-bluetooth,
Sean Wang, upstream
Hi Lukasz,
> Enable msft opcode for btmtksdio driver.
>
> Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> ---
> drivers/bluetooth/btmtksdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
> index d9cf0c492e29..2a7a615663b9 100644
> --- a/drivers/bluetooth/btmtksdio.c
> +++ b/drivers/bluetooth/btmtksdio.c
> @@ -887,6 +887,7 @@ static int btmtksdio_setup(struct hci_dev *hdev)
> if (enable_autosuspend)
> pm_runtime_allow(bdev->dev);
>
> + hci_set_msft_opcode(hdev, 0xFD30);
> bt_dev_info(hdev, "Device setup in %llu usecs", duration);
can we get someone from Mediatek to sign off on this and that all SDIO based device support the MSFT extension.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] Bluetooth: btmtksdio: enable msft opcode
2021-11-29 22:01 ` sean.wang
@ 2021-11-30 13:01 ` Łukasz Bartosik
0 siblings, 0 replies; 4+ messages in thread
From: Łukasz Bartosik @ 2021-11-30 13:01 UTC (permalink / raw)
To: Sean Wang
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, upstream,
linux-bluetooth, linux-mediatek, linux-kernel
pon., 29 lis 2021 o 22:01 <sean.wang@mediatek.com> napisał(a):
>
> From: Sean Wang <sean.wang@mediatek.com>
>
> >Enable msft opcode for btmtksdio driver.
> >
> >Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> >---
> > drivers/bluetooth/btmtksdio.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index d9cf0c492e29..2a7a615663b9 100644
> >--- a/drivers/bluetooth/btmtksdio.c
> >+++ b/drivers/bluetooth/btmtksdio.c
> >@@ -887,6 +887,7 @@ static int btmtksdio_setup(struct hci_dev *hdev)
> > if (enable_autosuspend)
> > pm_runtime_allow(bdev->dev);
> >
> >+ hci_set_msft_opcode(hdev, 0xFD30);
>
> Hi Łukasz,
>
> msft feature is supposed only supported on mt7921. Could you help rework the patch to enalbe msft opocde only for mt7921?
>
> Sean
>
Hi Sean,
Thanks for the input. I will update the patch so that msft opcode is
enabled only for mt7921.
Regards,
Lukasz
> > bt_dev_info(hdev, "Device setup in %llu usecs", duration);
> >
> > return 0;
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] Bluetooth: btmtksdio: enable msft opcode
@ 2021-11-30 13:01 ` Łukasz Bartosik
0 siblings, 0 replies; 4+ messages in thread
From: Łukasz Bartosik @ 2021-11-30 13:01 UTC (permalink / raw)
To: Sean Wang
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, upstream,
linux-bluetooth, linux-mediatek, linux-kernel
pon., 29 lis 2021 o 22:01 <sean.wang@mediatek.com> napisał(a):
>
> From: Sean Wang <sean.wang@mediatek.com>
>
> >Enable msft opcode for btmtksdio driver.
> >
> >Signed-off-by: Łukasz Bartosik <lb@semihalf.com>
> >---
> > drivers/bluetooth/btmtksdio.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index d9cf0c492e29..2a7a615663b9 100644
> >--- a/drivers/bluetooth/btmtksdio.c
> >+++ b/drivers/bluetooth/btmtksdio.c
> >@@ -887,6 +887,7 @@ static int btmtksdio_setup(struct hci_dev *hdev)
> > if (enable_autosuspend)
> > pm_runtime_allow(bdev->dev);
> >
> >+ hci_set_msft_opcode(hdev, 0xFD30);
>
> Hi Łukasz,
>
> msft feature is supposed only supported on mt7921. Could you help rework the patch to enalbe msft opocde only for mt7921?
>
> Sean
>
Hi Sean,
Thanks for the input. I will update the patch so that msft opcode is
enabled only for mt7921.
Regards,
Lukasz
> > bt_dev_info(hdev, "Device setup in %llu usecs", duration);
> >
> > return 0;
> >
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-30 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 22:10 [PATCH v1] Bluetooth: btmtksdio: enable msft opcode Lukasz Bartosik
2021-11-29 8:09 ` Marcel Holtmann
[not found] <20211126221034.21331-1-lukasz.bartosik@semihalf.com--annotate>
2021-11-29 22:01 ` sean.wang
2021-11-30 13:01 ` [PATCH " Łukasz Bartosik
2021-11-30 13:01 ` Łukasz Bartosik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.