All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: convert sysfs sprintf/snprintf family to sysfs_emit
Date: Thu, 4 Feb 2021 09:16:56 +0100 (CET)	[thread overview]
Message-ID: <429874131.360828.1612426616380.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20210204091215.38ca0f99@xps13>

----- Ursprüngliche Mail -----
>> Fix the following coccicheck warning:
>> 
>> ./drivers/mtd/mtdcore.c: WARNING: use scnprintf or sprintf.
> 
> That's not what you do in the below change :)

Well, sysfs_emit() is the sysfs equivalent of scnprintf().
But the patch fails to explain *why* it is needed. 

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: convert sysfs sprintf/snprintf family to sysfs_emit
Date: Thu, 4 Feb 2021 09:16:56 +0100 (CET)	[thread overview]
Message-ID: <429874131.360828.1612426616380.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20210204091215.38ca0f99@xps13>

----- Ursprüngliche Mail -----
>> Fix the following coccicheck warning:
>> 
>> ./drivers/mtd/mtdcore.c: WARNING: use scnprintf or sprintf.
> 
> That's not what you do in the below change :)

Well, sysfs_emit() is the sysfs equivalent of scnprintf().
But the patch fails to explain *why* it is needed. 

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-02-04  8:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  3:55 [PATCH] mtd: convert sysfs sprintf/snprintf family to sysfs_emit Jiapeng Chong
2021-02-04  3:55 ` Jiapeng Chong
2021-02-04  8:12 ` Miquel Raynal
2021-02-04  8:12   ` Miquel Raynal
2021-02-04  8:16   ` Richard Weinberger [this message]
2021-02-04  8:16     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=429874131.360828.1612426616380.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.