From: Daniel Borkmann <daniel@iogearbox.net>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org
Cc: shuah@kernel.org, netdev@vger.kernel.org,
alexei.starovoitov@gmail.com, ast@kernel.org
Subject: Re: [PATCH] selftests: bpf: test_kmod.sh: check the module path before insmod
Date: Wed, 7 Feb 2018 14:32:44 +0100 [thread overview]
Message-ID: <429eeaf2-06ba-3f50-1e3e-b0e32c60817b@iogearbox.net> (raw)
In-Reply-To: <1517951243-10003-1-git-send-email-naresh.kamboju@linaro.org>
Hi Naresh,
On 02/06/2018 10:07 PM, Naresh Kamboju wrote:
> test_kmod.sh reported false failure when module not present.
> Check test_bpf.ko is present in the path before loading it.
>
> Stop using "insmod $SRC_TREE/lib/test_bpf.ko" instead use
> "modprobe test_bpf"
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Thanks for looking into this! Could we have a way to be able to
support both? Say, when test_bpf.ko from SRC_TREE is not present,
we try with modprobe -q fallback? I would still like to support
the case where you can make local changes and add new tests to
test_bpf.c, recompile and then just rerun the test_kmod.sh w/o
having to install it first.
Thanks,
Daniel
> tools/testing/selftests/bpf/test_kmod.sh | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh
> index ed4774d..54177b1 100755
> --- a/tools/testing/selftests/bpf/test_kmod.sh
> +++ b/tools/testing/selftests/bpf/test_kmod.sh
> @@ -1,8 +1,6 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
>
> -SRC_TREE=../../../../
> -
> test_run()
> {
> sysctl -w net.core.bpf_jit_enable=$1 2>&1 > /dev/null
> @@ -10,8 +8,13 @@ test_run()
>
> echo "[ JIT enabled:$1 hardened:$2 ]"
> dmesg -C
> - insmod $SRC_TREE/lib/test_bpf.ko 2> /dev/null
> - if [ $? -ne 0 ]; then
> + # Use modprobe dry run to check for missing test_bpf module
> + if ! /sbin/modprobe -q -n test_bpf; then
> + echo "test_bpf: [SKIP]"
> + elif /sbin/modprobe -q test_bpf; then
> + echo "test_bpf: ok"
> + else
> + echo "test_bpf: [FAIL]"
> rc=1
> fi
> rmmod test_bpf 2> /dev/null
>
WARNING: multiple messages have this Message-ID (diff)
From: daniel at iogearbox.net (Daniel Borkmann)
Subject: [Linux-kselftest-mirror] [PATCH] selftests: bpf: test_kmod.sh: check the module path before insmod
Date: Wed, 7 Feb 2018 14:32:44 +0100 [thread overview]
Message-ID: <429eeaf2-06ba-3f50-1e3e-b0e32c60817b@iogearbox.net> (raw)
In-Reply-To: <1517951243-10003-1-git-send-email-naresh.kamboju@linaro.org>
Hi Naresh,
On 02/06/2018 10:07 PM, Naresh Kamboju wrote:
> test_kmod.sh reported false failure when module not present.
> Check test_bpf.ko is present in the path before loading it.
>
> Stop using "insmod $SRC_TREE/lib/test_bpf.ko" instead use
> "modprobe test_bpf"
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju at linaro.org>
Thanks for looking into this! Could we have a way to be able to
support both? Say, when test_bpf.ko from SRC_TREE is not present,
we try with modprobe -q fallback? I would still like to support
the case where you can make local changes and add new tests to
test_bpf.c, recompile and then just rerun the test_kmod.sh w/o
having to install it first.
Thanks,
Daniel
> tools/testing/selftests/bpf/test_kmod.sh | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh
> index ed4774d..54177b1 100755
> --- a/tools/testing/selftests/bpf/test_kmod.sh
> +++ b/tools/testing/selftests/bpf/test_kmod.sh
> @@ -1,8 +1,6 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
>
> -SRC_TREE=../../../../
> -
> test_run()
> {
> sysctl -w net.core.bpf_jit_enable=$1 2>&1 > /dev/null
> @@ -10,8 +8,13 @@ test_run()
>
> echo "[ JIT enabled:$1 hardened:$2 ]"
> dmesg -C
> - insmod $SRC_TREE/lib/test_bpf.ko 2> /dev/null
> - if [ $? -ne 0 ]; then
> + # Use modprobe dry run to check for missing test_bpf module
> + if ! /sbin/modprobe -q -n test_bpf; then
> + echo "test_bpf: [SKIP]"
> + elif /sbin/modprobe -q test_bpf; then
> + echo "test_bpf: ok"
> + else
> + echo "test_bpf: [FAIL]"
> rc=1
> fi
> rmmod test_bpf 2> /dev/null
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: daniel@iogearbox.net (Daniel Borkmann)
Subject: [Linux-kselftest-mirror] [PATCH] selftests: bpf: test_kmod.sh: check the module path before insmod
Date: Wed, 7 Feb 2018 14:32:44 +0100 [thread overview]
Message-ID: <429eeaf2-06ba-3f50-1e3e-b0e32c60817b@iogearbox.net> (raw)
Message-ID: <20180207133244.49usSXHHnBFySnP8bNAsWuzHH2IK-qv6khkX-t-_aUY@z> (raw)
In-Reply-To: <1517951243-10003-1-git-send-email-naresh.kamboju@linaro.org>
Hi Naresh,
On 02/06/2018 10:07 PM, Naresh Kamboju wrote:
> test_kmod.sh reported false failure when module not present.
> Check test_bpf.ko is present in the path before loading it.
>
> Stop using "insmod $SRC_TREE/lib/test_bpf.ko" instead use
> "modprobe test_bpf"
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju at linaro.org>
Thanks for looking into this! Could we have a way to be able to
support both? Say, when test_bpf.ko from SRC_TREE is not present,
we try with modprobe -q fallback? I would still like to support
the case where you can make local changes and add new tests to
test_bpf.c, recompile and then just rerun the test_kmod.sh w/o
having to install it first.
Thanks,
Daniel
> tools/testing/selftests/bpf/test_kmod.sh | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh
> index ed4774d..54177b1 100755
> --- a/tools/testing/selftests/bpf/test_kmod.sh
> +++ b/tools/testing/selftests/bpf/test_kmod.sh
> @@ -1,8 +1,6 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
>
> -SRC_TREE=../../../../
> -
> test_run()
> {
> sysctl -w net.core.bpf_jit_enable=$1 2>&1 > /dev/null
> @@ -10,8 +8,13 @@ test_run()
>
> echo "[ JIT enabled:$1 hardened:$2 ]"
> dmesg -C
> - insmod $SRC_TREE/lib/test_bpf.ko 2> /dev/null
> - if [ $? -ne 0 ]; then
> + # Use modprobe dry run to check for missing test_bpf module
> + if ! /sbin/modprobe -q -n test_bpf; then
> + echo "test_bpf: [SKIP]"
> + elif /sbin/modprobe -q test_bpf; then
> + echo "test_bpf: ok"
> + else
> + echo "test_bpf: [FAIL]"
> rc=1
> fi
> rmmod test_bpf 2> /dev/null
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-07 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 21:07 [PATCH] selftests: bpf: test_kmod.sh: check the module path before insmod Naresh Kamboju
2018-02-06 21:07 ` [Linux-kselftest-mirror] " Naresh Kamboju
2018-02-06 21:07 ` naresh.kamboju
2018-02-07 13:32 ` Daniel Borkmann [this message]
2018-02-07 13:32 ` Daniel Borkmann
2018-02-07 13:32 ` daniel
2018-02-07 18:17 ` Naresh Kamboju
2018-02-07 18:17 ` [Linux-kselftest-mirror] " Naresh Kamboju
2018-02-07 18:17 ` naresh.kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429eeaf2-06ba-3f50-1e3e-b0e32c60817b@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.