From: heyunlei <heyunlei@huawei.com> To: "Songyunlong (Euler)" <yunlong.song@huawei.com>, "jaegeuk@kernel.org" <jaegeuk@kernel.org>, "chao@kernel.org" <chao@kernel.org>, "Yuchao (T)" <yuchao0@huawei.com>, "yunlong.song@icloud.com" <yunlong.song@icloud.com> Cc: "miaoxie (A)" <miaoxie@huawei.com>, Wangbintian <bintian.wang@huawei.com>, "shengyong (A)" <shengyong1@huawei.com>, "linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH] f2fs: set_code_data in move_data_block Date: Sun, 11 Feb 2018 03:51:14 +0000 [thread overview] Message-ID: <42B685BFA705F94C860C6DD0752F05654832EB19@DGGEMA503-MBX.china.huawei.com> (raw) In-Reply-To: <a55bc2f7-fc46-4f4a-cb30-d6eb61b30785@huawei.com> >-----Original Message----- >From: Songyunlong (Euler) >Sent: Sunday, February 11, 2018 11:35 AM >To: jaegeuk@kernel.org; chao@kernel.org; Yuchao (T); yunlong.song@icloud.com >Cc: miaoxie (A); Wangbintian; shengyong (A); heyunlei; linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org >Subject: Re: [PATCH] f2fs: set_code_data in move_data_block > >Ping... > >move_data_block misses set_cold_data, then the F2FS_WB_CP_DATA will >lack these data pages in move_data_block, and write_checkpoint can >not make sure this pages committed to the flash. > Here, we write encrypted_page back, which belong to meta mapping. Thanks. >On 2018/2/8 20:33, Yunlong Song wrote: >> Signed-off-by: Yunlong Song <yunlong.song@huawei.com> >> --- >> fs/f2fs/gc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >> index b9d93fd..2095630 100644 >> --- a/fs/f2fs/gc.c >> +++ b/fs/f2fs/gc.c >> @@ -692,6 +692,7 @@ static void move_data_block(struct inode *inode, block_t bidx, >> fio.op = REQ_OP_WRITE; >> fio.op_flags = REQ_SYNC; >> fio.new_blkaddr = newaddr; >> + set_cold_data(fio.page); >> err = f2fs_submit_page_write(&fio); >> if (err) { >> if (PageWriteback(fio.encrypted_page)) >> > >-- >Thanks, >Yunlong Song
WARNING: multiple messages have this Message-ID (diff)
From: heyunlei <heyunlei@huawei.com> To: "Songyunlong (Euler)" <yunlong.song@huawei.com>, "jaegeuk@kernel.org" <jaegeuk@kernel.org>, "chao@kernel.org" <chao@kernel.org>, "Yuchao (T)" <yuchao0@huawei.com>, "yunlong.song@icloud.com" <yunlong.song@icloud.com> Cc: "miaoxie (A)" <miaoxie@huawei.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net> Subject: Re: [PATCH] f2fs: set_code_data in move_data_block Date: Sun, 11 Feb 2018 03:51:14 +0000 [thread overview] Message-ID: <42B685BFA705F94C860C6DD0752F05654832EB19@DGGEMA503-MBX.china.huawei.com> (raw) In-Reply-To: <a55bc2f7-fc46-4f4a-cb30-d6eb61b30785@huawei.com> >-----Original Message----- >From: Songyunlong (Euler) >Sent: Sunday, February 11, 2018 11:35 AM >To: jaegeuk@kernel.org; chao@kernel.org; Yuchao (T); yunlong.song@icloud.com >Cc: miaoxie (A); Wangbintian; shengyong (A); heyunlei; linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org >Subject: Re: [PATCH] f2fs: set_code_data in move_data_block > >Ping... > >move_data_block misses set_cold_data, then the F2FS_WB_CP_DATA will >lack these data pages in move_data_block, and write_checkpoint can >not make sure this pages committed to the flash. > Here, we write encrypted_page back, which belong to meta mapping. Thanks. >On 2018/2/8 20:33, Yunlong Song wrote: >> Signed-off-by: Yunlong Song <yunlong.song@huawei.com> >> --- >> fs/f2fs/gc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >> index b9d93fd..2095630 100644 >> --- a/fs/f2fs/gc.c >> +++ b/fs/f2fs/gc.c >> @@ -692,6 +692,7 @@ static void move_data_block(struct inode *inode, block_t bidx, >> fio.op = REQ_OP_WRITE; >> fio.op_flags = REQ_SYNC; >> fio.new_blkaddr = newaddr; >> + set_cold_data(fio.page); >> err = f2fs_submit_page_write(&fio); >> if (err) { >> if (PageWriteback(fio.encrypted_page)) >> > >-- >Thanks, >Yunlong Song ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2018-02-11 3:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-08 12:33 [PATCH] f2fs: set_code_data in move_data_block Yunlong Song 2018-02-08 12:33 ` Yunlong Song 2018-02-11 3:34 ` Yunlong Song 2018-02-11 3:34 ` Yunlong Song 2018-02-11 3:50 ` Chao Yu 2018-02-11 3:50 ` Chao Yu 2018-02-11 6:15 ` Yunlong Song 2018-02-11 6:15 ` Yunlong Song 2018-02-11 3:51 ` heyunlei [this message] 2018-02-11 3:51 ` heyunlei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=42B685BFA705F94C860C6DD0752F05654832EB19@DGGEMA503-MBX.china.huawei.com \ --to=heyunlei@huawei.com \ --cc=bintian.wang@huawei.com \ --cc=chao@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ --cc=miaoxie@huawei.com \ --cc=shengyong1@huawei.com \ --cc=yuchao0@huawei.com \ --cc=yunlong.song@huawei.com \ --cc=yunlong.song@icloud.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.