* [ANN] U-Boot v2022.01-rc3 released
@ 2021-11-29 16:28 Tom Rini
2021-11-30 2:35 ` Jesse Taube
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2021-11-29 16:28 UTC (permalink / raw)
To: u-boot; +Cc: u-boot-custodians, u-boot-board-maintainers
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
Hey all,
It's been two weeks since v2022.01-rc2, so here's -rc3.
To repeat what I said with -rc2, we've enabled issue tracking on our
gitlab instance. You can sign up and then be able to file issues at:
https://source.denx.de/groups/u-boot/-/issues
This is intended for everyone to be able to use, both custodians for
their own needs (you can see for example Heinrich has filed something
for UEFI and LMB) as well as users to just report bugs so they don't
feel like they're lost in the mailing list.
As noted with the last release, the -next branch is open and I'll sync
in -rc3 shortly. Please feel free to get a PR ready now if you're able.
In terms of a changelog,
git log --merges v2022.01-rc2..v2022.01-rc3
contains what I've pulled but as always, better PR messages and tags
will provide better results here.
So we're now looking at regular releases every other Monday, and with
final release on January 10th, 2022. Thanks all!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ANN] U-Boot v2022.01-rc3 released
2021-11-29 16:28 [ANN] U-Boot v2022.01-rc3 released Tom Rini
@ 2021-11-30 2:35 ` Jesse Taube
2021-11-30 19:36 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Jesse Taube @ 2021-11-30 2:35 UTC (permalink / raw)
To: Tom Rini, u-boot; +Cc: u-boot-custodians, u-boot-board-maintainers
On 11/29/21 11:28, Tom Rini wrote:
> Hey all,
>
> It's been two weeks since v2022.01-rc2, so here's -rc3.
>
> To repeat what I said with -rc2, we've enabled issue tracking on our
> gitlab instance. You can sign up and then be able to file issues at:
> https://source.denx.de/groups/u-boot/-/issues
>
> This is intended for everyone to be able to use, both custodians for
> their own needs (you can see for example Heinrich has filed something
> for UEFI and LMB) as well as users to just report bugs so they don't
> feel like they're lost in the mailing list.
>
> As noted with the last release, the -next branch is open and I'll sync
> in -rc3 shortly. Please feel free to get a PR ready now if you're able.
>
> In terms of a changelog,
> git log --merges v2022.01-rc2..v2022.01-rc3
> contains what I've pulled but as always, better PR messages and tags
> will provide better results here.
>
> So we're now looking at regular releases every other Monday, and with
> final release on January 10th, 2022. Thanks all!
>
Hey tom,
Thank you for the update as always!
I have a question about a recent commit, I hope its okay to ask here.
In commit cd82f199852d88218e1f17f5ec07cdd9112a89c4
In arch/arm/lib/relocate.S:81 on my SBC it returns an invalid value.
My soc is Thumb2 but the instruction `adr r3, relocate_code`
assembles to `subw r3, pc, #3` which is not 32bit aligned. If i change
the instruction to `adr.w r3, relocate_code` it evaluates to `subw r3,
pc, #4`, which is.
There is a slight problem as it seems to work fine on my laptop using
Debian bullseye, but on my Desktop where I found this I'm running sid.
They are both gcc-10. I have yet to find a way to consistently replicate it.
What are your thoughts of this?
Thanks,
Jesse
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ANN] U-Boot v2022.01-rc3 released
2021-11-30 2:35 ` Jesse Taube
@ 2021-11-30 19:36 ` Tom Rini
2022-07-06 14:31 ` Jesse Taube
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2021-11-30 19:36 UTC (permalink / raw)
To: Jesse Taube; +Cc: u-boot, u-boot-custodians, u-boot-board-maintainers
[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]
On Mon, Nov 29, 2021 at 09:35:52PM -0500, Jesse Taube wrote:
>
>
> On 11/29/21 11:28, Tom Rini wrote:
> > Hey all,
> >
> > It's been two weeks since v2022.01-rc2, so here's -rc3.
> >
> > To repeat what I said with -rc2, we've enabled issue tracking on our
> > gitlab instance. You can sign up and then be able to file issues at:
> > https://source.denx.de/groups/u-boot/-/issues
> >
> > This is intended for everyone to be able to use, both custodians for
> > their own needs (you can see for example Heinrich has filed something
> > for UEFI and LMB) as well as users to just report bugs so they don't
> > feel like they're lost in the mailing list.
> >
> > As noted with the last release, the -next branch is open and I'll sync
> > in -rc3 shortly. Please feel free to get a PR ready now if you're able.
> >
> > In terms of a changelog,
> > git log --merges v2022.01-rc2..v2022.01-rc3
> > contains what I've pulled but as always, better PR messages and tags
> > will provide better results here.
> >
> > So we're now looking at regular releases every other Monday, and with
> > final release on January 10th, 2022. Thanks all!
> >
> Hey tom,
>
> Thank you for the update as always!
>
> I have a question about a recent commit, I hope its okay to ask here.
> In commit cd82f199852d88218e1f17f5ec07cdd9112a89c4
> In arch/arm/lib/relocate.S:81 on my SBC it returns an invalid value.
> My soc is Thumb2 but the instruction `adr r3, relocate_code`
> assembles to `subw r3, pc, #3` which is not 32bit aligned. If i change the
> instruction to `adr.w r3, relocate_code` it evaluates to `subw r3, pc, #4`,
> which is.
>
> There is a slight problem as it seems to work fine on my laptop using Debian
> bullseye, but on my Desktop where I found this I'm running sid.
> They are both gcc-10. I have yet to find a way to consistently replicate it.
>
> What are your thoughts of this?
It sounds like you have enough details here to file a bug with Debian
and see where that leads.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ANN] U-Boot v2022.01-rc3 released
2021-11-30 19:36 ` Tom Rini
@ 2022-07-06 14:31 ` Jesse Taube
2022-07-06 14:47 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Jesse Taube @ 2022-07-06 14:31 UTC (permalink / raw)
To: Tom Rini
Cc: u-boot, u-boot-custodians, u-boot-board-maintainers,
Giulio Benetti, Simon Glass, Tom Rini, mr.bossman075
On 11/30/21 14:36, Tom Rini wrote:
> On Mon, Nov 29, 2021 at 09:35:52PM -0500, Jesse Taube wrote:
>>
>>
>> On 11/29/21 11:28, Tom Rini wrote:
>>> Hey all,
>>>
>>> It's been two weeks since v2022.01-rc2, so here's -rc3.
>>>
>>> To repeat what I said with -rc2, we've enabled issue tracking on our
>>> gitlab instance. You can sign up and then be able to file issues at:
>>> https://source.denx.de/groups/u-boot/-/issues
>>>
>>> This is intended for everyone to be able to use, both custodians for
>>> their own needs (you can see for example Heinrich has filed something
>>> for UEFI and LMB) as well as users to just report bugs so they don't
>>> feel like they're lost in the mailing list.
>>>
>>> As noted with the last release, the -next branch is open and I'll sync
>>> in -rc3 shortly. Please feel free to get a PR ready now if you're able.
>>>
>>> In terms of a changelog,
>>> git log --merges v2022.01-rc2..v2022.01-rc3
>>> contains what I've pulled but as always, better PR messages and tags
>>> will provide better results here.
>>>
>>> So we're now looking at regular releases every other Monday, and with
>>> final release on January 10th, 2022. Thanks all!
>>>
>> Hey tom,
>>
>> Thank you for the update as always!
>>
>> I have a question about a recent commit, I hope its okay to ask here.
>> In commit cd82f199852d88218e1f17f5ec07cdd9112a89c4
>> In arch/arm/lib/relocate.S:81 on my SBC it returns an invalid value.
>> My soc is Thumb2 but the instruction `adr r3, relocate_code`
>> assembles to `subw r3, pc, #3` which is not 32bit aligned. If i change the
>> instruction to `adr.w r3, relocate_code` it evaluates to `subw r3, pc, #4`,
>> which is.
>>
>> There is a slight problem as it seems to work fine on my laptop using Debian
>> bullseye, but on my Desktop where I found this I'm running sid.
>> They are both gcc-10. I have yet to find a way to consistently replicate it.
>>
>> What are your thoughts of this?
>
> It sounds like you have enough details here to file a bug with Debian
> and see where that leads.
>
Sorry for replying to old messages but the bug has appeared again in a
separate case the bug seems to be introduced in
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d3e52e120b68bf19552743fbc078e0a759f48cb7
The test code is as follows
```
.syntax unified
.global bug;
.align 4
bug:
adr r3, bug
.size bug, .-bug
.type bug 2; // This changes offset from 4 to 3 in
include/linux/linkage.h:ENDPROC
//arm-linux-gnueabi-as -march=armv7-m -c -o bug.o bug.S &&
arm-linux-gnueabi-objdump --disassemble=bug bug.o
```
Releases >2.37 have this issue and causes some arm platforms in u-boot
at /arch/arm/lib/relocate.S:81 adr r3, relocate_code
I'm wondering if there should be a mitigation for this till binutils is
patched.
Thanks,
Jesse
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ANN] U-Boot v2022.01-rc3 released
2022-07-06 14:31 ` Jesse Taube
@ 2022-07-06 14:47 ` Tom Rini
2022-07-06 16:34 ` Jesse Taube
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2022-07-06 14:47 UTC (permalink / raw)
To: Jesse Taube
Cc: u-boot, u-boot-custodians, u-boot-board-maintainers,
Giulio Benetti, Simon Glass
[-- Attachment #1: Type: text/plain, Size: 3257 bytes --]
On Wed, Jul 06, 2022 at 10:31:41AM -0400, Jesse Taube wrote:
>
>
> On 11/30/21 14:36, Tom Rini wrote:
> > On Mon, Nov 29, 2021 at 09:35:52PM -0500, Jesse Taube wrote:
> > >
> > >
> > > On 11/29/21 11:28, Tom Rini wrote:
> > > > Hey all,
> > > >
> > > > It's been two weeks since v2022.01-rc2, so here's -rc3.
> > > >
> > > > To repeat what I said with -rc2, we've enabled issue tracking on our
> > > > gitlab instance. You can sign up and then be able to file issues at:
> > > > https://source.denx.de/groups/u-boot/-/issues
> > > >
> > > > This is intended for everyone to be able to use, both custodians for
> > > > their own needs (you can see for example Heinrich has filed something
> > > > for UEFI and LMB) as well as users to just report bugs so they don't
> > > > feel like they're lost in the mailing list.
> > > >
> > > > As noted with the last release, the -next branch is open and I'll sync
> > > > in -rc3 shortly. Please feel free to get a PR ready now if you're able.
> > > >
> > > > In terms of a changelog,
> > > > git log --merges v2022.01-rc2..v2022.01-rc3
> > > > contains what I've pulled but as always, better PR messages and tags
> > > > will provide better results here.
> > > >
> > > > So we're now looking at regular releases every other Monday, and with
> > > > final release on January 10th, 2022. Thanks all!
> > > >
> > > Hey tom,
> > >
> > > Thank you for the update as always!
> > >
> > > I have a question about a recent commit, I hope its okay to ask here.
> > > In commit cd82f199852d88218e1f17f5ec07cdd9112a89c4
> > > In arch/arm/lib/relocate.S:81 on my SBC it returns an invalid value.
> > > My soc is Thumb2 but the instruction `adr r3, relocate_code`
> > > assembles to `subw r3, pc, #3` which is not 32bit aligned. If i change the
> > > instruction to `adr.w r3, relocate_code` it evaluates to `subw r3, pc, #4`,
> > > which is.
> > >
> > > There is a slight problem as it seems to work fine on my laptop using Debian
> > > bullseye, but on my Desktop where I found this I'm running sid.
> > > They are both gcc-10. I have yet to find a way to consistently replicate it.
> > >
> > > What are your thoughts of this?
> >
> > It sounds like you have enough details here to file a bug with Debian
> > and see where that leads.
> >
> Sorry for replying to old messages but the bug has appeared again in a
> separate case the bug seems to be introduced in
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d3e52e120b68bf19552743fbc078e0a759f48cb7
>
> The test code is as follows
> ```
> .syntax unified
>
> .global bug;
>
> .align 4
>
> bug:
>
> adr r3, bug
>
> .size bug, .-bug
>
> .type bug 2; // This changes offset from 4 to 3 in
> include/linux/linkage.h:ENDPROC
> //arm-linux-gnueabi-as -march=armv7-m -c -o bug.o bug.S &&
> arm-linux-gnueabi-objdump --disassemble=bug bug.o
> ```
> Releases >2.37 have this issue and causes some arm platforms in u-boot at
> /arch/arm/lib/relocate.S:81 adr r3, relocate_code
>
> I'm wondering if there should be a mitigation for this till binutils is
> patched.
Thanks for being persistent on this. What would a mitigation look like?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ANN] U-Boot v2022.01-rc3 released
2022-07-06 14:47 ` Tom Rini
@ 2022-07-06 16:34 ` Jesse Taube
0 siblings, 0 replies; 6+ messages in thread
From: Jesse Taube @ 2022-07-06 16:34 UTC (permalink / raw)
To: Tom Rini
Cc: u-boot, u-boot-custodians, u-boot-board-maintainers,
Giulio Benetti, Simon Glass
On 7/6/22 10:47, Tom Rini wrote:
> On Wed, Jul 06, 2022 at 10:31:41AM -0400, Jesse Taube wrote:
>>
>>
>> On 11/30/21 14:36, Tom Rini wrote:
>>> On Mon, Nov 29, 2021 at 09:35:52PM -0500, Jesse Taube wrote:
>>>>
>>>>
>>>> On 11/29/21 11:28, Tom Rini wrote:
>>>>> Hey all,
>>>>>
>>>>> It's been two weeks since v2022.01-rc2, so here's -rc3.
>>>>>
>>>>> To repeat what I said with -rc2, we've enabled issue tracking on our
>>>>> gitlab instance. You can sign up and then be able to file issues at:
>>>>> https://source.denx.de/groups/u-boot/-/issues
>>>>>
>>>>> This is intended for everyone to be able to use, both custodians for
>>>>> their own needs (you can see for example Heinrich has filed something
>>>>> for UEFI and LMB) as well as users to just report bugs so they don't
>>>>> feel like they're lost in the mailing list.
>>>>>
>>>>> As noted with the last release, the -next branch is open and I'll sync
>>>>> in -rc3 shortly. Please feel free to get a PR ready now if you're able.
>>>>>
>>>>> In terms of a changelog,
>>>>> git log --merges v2022.01-rc2..v2022.01-rc3
>>>>> contains what I've pulled but as always, better PR messages and tags
>>>>> will provide better results here.
>>>>>
>>>>> So we're now looking at regular releases every other Monday, and with
>>>>> final release on January 10th, 2022. Thanks all!
>>>>>
>>>> Hey tom,
>>>>
>>>> Thank you for the update as always!
>>>>
>>>> I have a question about a recent commit, I hope its okay to ask here.
>>>> In commit cd82f199852d88218e1f17f5ec07cdd9112a89c4
>>>> In arch/arm/lib/relocate.S:81 on my SBC it returns an invalid value.
>>>> My soc is Thumb2 but the instruction `adr r3, relocate_code`
>>>> assembles to `subw r3, pc, #3` which is not 32bit aligned. If i change the
>>>> instruction to `adr.w r3, relocate_code` it evaluates to `subw r3, pc, #4`,
>>>> which is.
>>>>
>>>> There is a slight problem as it seems to work fine on my laptop using Debian
>>>> bullseye, but on my Desktop where I found this I'm running sid.
>>>> They are both gcc-10. I have yet to find a way to consistently replicate it.
>>>>
>>>> What are your thoughts of this?
>>>
>>> It sounds like you have enough details here to file a bug with Debian
>>> and see where that leads.
>>>
>> Sorry for replying to old messages but the bug has appeared again in a
>> separate case the bug seems to be introduced in
>> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d3e52e120b68bf19552743fbc078e0a759f48cb7
>>
>> The test code is as follows
>> ```
>> .syntax unified
>>
>> .global bug;
>>
>> .align 4
>>
>> bug:
>>
>> adr r3, bug
>>
>> .size bug, .-bug
>>
>> .type bug 2; // This changes offset from 4 to 3 in
>> include/linux/linkage.h:ENDPROC
>> //arm-linux-gnueabi-as -march=armv7-m -c -o bug.o bug.S &&
>> arm-linux-gnueabi-objdump --disassemble=bug bug.o
>> ```
>> Releases >2.37 have this issue and causes some arm platforms in u-boot at
>> /arch/arm/lib/relocate.S:81 adr r3, relocate_code
>>
>> I'm wondering if there should be a mitigation for this till binutils is
>> patched.
>
> Thanks for being persistent on this. What would a mitigation look like?
>
Other people have suggested to use `subw r3, pc, #4` and ifdef for
different variants. We could also do `adr.w`, what do you recommend.
Unfortunately I'm not very familiar with arm asm so I was just putting
it out there because many here know more. I'll continue to look into
fixes for u-boot. And look into fixes for binutils as 2.37 is now in
buildroot and other tool and distros. I'm not sure if line 81 is the
only one that is affected but if it is then its a much easier fix than
every adr instruction.
Thanks,
Jesse
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-06 16:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 16:28 [ANN] U-Boot v2022.01-rc3 released Tom Rini
2021-11-30 2:35 ` Jesse Taube
2021-11-30 19:36 ` Tom Rini
2022-07-06 14:31 ` Jesse Taube
2022-07-06 14:47 ` Tom Rini
2022-07-06 16:34 ` Jesse Taube
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.