From: Stefan Weil <sw@weilnetz.de>
To: John Snow <jsnow@redhat.com>
Cc: qemu-trivial@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM)
Date: Mon, 10 Jan 2022 18:56:50 +0100 [thread overview]
Message-ID: <42ac8990-8733-fa68-c4b4-c54a82ce43f9@weilnetz.de> (raw)
In-Reply-To: <CAFn=p-ZYr+D54GzYKt5cxuJQQTARGQTvkkgVfhLGEeLczFt-Tw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]
Am 10.01.22 um 18:08 schrieb John Snow:
> On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de> wrote:
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> scripts/simplebench/bench-example.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/simplebench/bench-example.py
> b/scripts/simplebench/bench-example.py
> index 4864435f39..fc370691e0 100644
> --- a/scripts/simplebench/bench-example.py
> +++ b/scripts/simplebench/bench-example.py
> @@ -25,7 +25,7 @@
>
> def bench_func(env, case):
> """ Handle one "cell" of benchmarking table. """
> - return bench_block_copy(env['qemu_binary'], env['cmd'], {}
> + return bench_block_copy(env['qemu_binary'], env['cmd'], {},
> case['source'], case['target'])
>
>
> --
> 2.30.2
>
>
> Good spot. If it's not too late and not a hassle, can you add a fixes:
> commit-id in the commit message? No big deal if not.
>
> Reviewed-by: John Snow <jsnow@redhat.com>
Maybe that can be added locally to avoid a V2 patch. Here it is:
Fixes: b2fcb0c5754c2554b8406376e99a75e9e0a6b7bd
Thanks,
Stefan
[-- Attachment #2: Type: text/html, Size: 2498 bytes --]
next prev parent reply other threads:[~2022-01-10 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 15:30 [PATCH] simplebench: Fix Python syntax error (reported by LGTM) Stefan Weil
2022-01-07 18:23 ` Philippe Mathieu-Daudé
2022-01-10 17:08 ` John Snow
2022-01-10 17:56 ` Stefan Weil [this message]
2022-01-10 18:09 ` John Snow
2022-01-17 8:02 ` Vladimir Sementsov-Ogievskiy
2022-01-17 19:26 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ac8990-8733-fa68-c4b4-c54a82ce43f9@weilnetz.de \
--to=sw@weilnetz.de \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.