Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM)

From: John Snow <jsnow@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM)
Date: Mon, 10 Jan 2022 12:08:34 -0500	[thread overview]
Message-ID: <CAFn=p-ZYr+D54GzYKt5cxuJQQTARGQTvkkgVfhLGEeLczFt-Tw@mail.gmail.com> (raw)
In-Reply-To: <20220107153019.504124-1-sw@weilnetz.de>

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de> wrote:

> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  scripts/simplebench/bench-example.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/simplebench/bench-example.py
> b/scripts/simplebench/bench-example.py
> index 4864435f39..fc370691e0 100644
> --- a/scripts/simplebench/bench-example.py
> +++ b/scripts/simplebench/bench-example.py
> @@ -25,7 +25,7 @@
>
>  def bench_func(env, case):
>      """ Handle one "cell" of benchmarking table. """
> -    return bench_block_copy(env['qemu_binary'], env['cmd'], {}
> +    return bench_block_copy(env['qemu_binary'], env['cmd'], {},
>                              case['source'], case['target'])
>
>
> --
> 2.30.2
>

Good spot. If it's not too late and not a hassle, can you add a fixes:
commit-id in the commit message? No big deal if not.

Reviewed-by: John Snow <jsnow@redhat.com>

[-- Attachment #2: Type: text/html, Size: 1563 bytes --]