"tipc: fix socket timer deadlock" to stable?

"tipc: fix socket timer deadlock" to stable?

[Tommi Rantala]

Hello,

We're seeing this tipc deadlock in 4.4.y, that was fixed in the mainline 
commit f1d048f24e66ba85d3dabf3d076cefa5f2b546b0 "tipc: fix socket timer 
deadlock".

Could/should this patch also be included in the stable kernel trees?

I just checked that the patch applies on top of 4.4.53, only the line 
numbers are different compared to the upstream commit.

-Tommi

RE: "tipc: fix socket timer deadlock" to stable?

[Jon Maloy]

> -----Original Message-----
> From: Tommi Rantala [mailto:tommi.t.rantala@nokia.com]
> Sent: Monday, March 13, 2017 11:43 AM
> To: netdev@vger.kernel.org; Jon Maloy <jon.maloy@ericsson.com>
> Cc: David S. Miller <davem@davemloft.net>; GUNA <gbalasun@gmail.com>;
> Ying Xue <ying.xue@windriver.com>
> Subject: "tipc: fix socket timer deadlock" to stable?
> 
> Hello,
> 
> We're seeing this tipc deadlock in 4.4.y, that was fixed in the mainline commit
> f1d048f24e66ba85d3dabf3d076cefa5f2b546b0 "tipc: fix socket timer
> deadlock".
> 
> Could/should this patch also be included in the stable kernel trees?

I think it should. If action is required by me here (?) I will repost the commit for 4.4.

///jon

> 
> I just checked that the patch applies on top of 4.4.53, only the line numbers
> are different compared to the upstream commit.
> 
> -Tommi

Re: "tipc: fix socket timer deadlock" to stable?

[Tommi Rantala]

On 13.03.2017 14:18, Jon Maloy wrote:
>> -----Original Message-----
>> From: Tommi Rantala [mailto:tommi.t.rantala@nokia.com]
>>
>> We're seeing this tipc deadlock in 4.4.y, that was fixed in the mainline commit
>> f1d048f24e66ba85d3dabf3d076cefa5f2b546b0 "tipc: fix socket timer
>> deadlock".
>>
>> Could/should this patch also be included in the stable kernel trees?
>
> I think it should. If action is required by me here (?) I will repost the commit for 4.4.
>
> ///jon

Hi Jon, yes, please do repost the commit. After reading through 
Documentation/networking/netdev-FAQ.txt, you probably want to send it 
with suitable subject-prefix so that the patch is not lost in the noise.

>> I just checked that the patch applies on top of 4.4.53, only the line numbers
>> are different compared to the upstream commit.

(Actually there is also a small change in the patch context.)

-Tommi

RE: "tipc: fix socket timer deadlock" to stable?

[Jon Maloy]

> -----Original Message-----
> From: Tommi Rantala [mailto:tommi.t.rantala@nokia.com]
> Sent: Tuesday, March 21, 2017 03:50 AM
> To: Jon Maloy <jon.maloy@ericsson.com>; netdev@vger.kernel.org
> Cc: David S. Miller <davem@davemloft.net>; GUNA <gbalasun@gmail.com>;
> Ying Xue <ying.xue@windriver.com>
> Subject: Re: "tipc: fix socket timer deadlock" to stable?
> 
> On 13.03.2017 14:18, Jon Maloy wrote:
> >> -----Original Message-----
> >> From: Tommi Rantala [mailto:tommi.t.rantala@nokia.com]
> >>
> >> We're seeing this tipc deadlock in 4.4.y, that was fixed in the
> >> mainline commit
> >> f1d048f24e66ba85d3dabf3d076cefa5f2b546b0 "tipc: fix socket timer
> >> deadlock".
> >>
> >> Could/should this patch also be included in the stable kernel trees?
> >
> > I think it should. If action is required by me here (?) I will repost the commit
> for 4.4.
> >
> > ///jon
> 
> Hi Jon, yes, please do repost the commit. After reading through
> Documentation/networking/netdev-FAQ.txt, you probably want to send it
> with suitable subject-prefix so that the patch is not lost in the noise.
> 
Ok. I'll do that. Just have to do proper testing first.

///jon

> >> I just checked that the patch applies on top of 4.4.53, only the line
> >> numbers are different compared to the upstream commit.
> 
> (Actually there is also a small change in the patch context.)
> 
> -Tommi