From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: Andrey Konovalov <andreyknvl@google.com> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org>, kasan-dev <kasan-dev@googlegroups.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Alexander Potapenko <glider@google.com>, Marco Elver <elver@google.com>, Evgenii Stepanov <eugenis@google.com>, Branislav Rankov <Branislav.Rankov@arm.com> Subject: Re: [PATCH v7 3/4] kasan: Add report for async mode Date: Fri, 22 Jan 2021 15:01:01 +0000 [thread overview] Message-ID: <42b4d820-0a33-35a0-0dd0-0381dd693b9e@arm.com> (raw) In-Reply-To: <CAAeHK+ydhzfrdrPbjok20rgMEYykpfmjcRASm_bTfhuTVXF_VA@mail.gmail.com> On 1/22/21 2:42 PM, Andrey Konovalov wrote: > On Fri, Jan 22, 2021 at 3:11 PM Vincenzo Frascino > <vincenzo.frascino@arm.com> wrote: >> >> KASAN provides an asynchronous mode of execution. >> >> Add reporting functionality for this mode. >> >> Cc: Dmitry Vyukov <dvyukov@google.com> >> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> >> Cc: Alexander Potapenko <glider@google.com> >> Cc: Andrey Konovalov <andreyknvl@google.com> >> Reviewed-by: Andrey Konovalov <andreyknvl@google.com> >> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> >> --- >> include/linux/kasan.h | 2 ++ >> mm/kasan/report.c | 13 +++++++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/include/linux/kasan.h b/include/linux/kasan.h >> index bb862d1f0e15..b0a1d9dfa85c 100644 >> --- a/include/linux/kasan.h >> +++ b/include/linux/kasan.h >> @@ -351,6 +351,8 @@ static inline void *kasan_reset_tag(const void *addr) >> bool kasan_report(unsigned long addr, size_t size, >> bool is_write, unsigned long ip); >> >> +void kasan_report_async(void); >> + >> #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ >> >> static inline void *kasan_reset_tag(const void *addr) >> diff --git a/mm/kasan/report.c b/mm/kasan/report.c >> index 234f35a84f19..1390da06a988 100644 >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -358,6 +358,19 @@ void kasan_report_invalid_free(void *object, unsigned long ip) >> end_report(&flags); >> } >> >> +#if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) > > This looks wrong, CONFIG_KASAN_SW_TAGS doesn't use MTE, so this > function isn't needed for that mode. > It is true, I will fix in v8. > Let's add an #ifdef CONFIG_KASAN_HW_TAGS section in > include/linux/kasan.h after the HW/SW one with kasan_report(). And > only leave CONFIG_KASAN_HW_TAGS in mm/kasan/report.c too. > >> +void kasan_report_async(void) >> +{ >> + unsigned long flags; >> + >> + start_report(&flags); >> + pr_err("BUG: KASAN: invalid-access\n"); >> + pr_err("Asynchronous mode enabled: no access details available\n"); >> + dump_stack(); >> + end_report(&flags); >> +} >> +#endif /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ >> + >> static void __kasan_report(unsigned long addr, size_t size, bool is_write, >> unsigned long ip) >> { >> -- >> 2.30.0 >> -- Regards, Vincenzo
WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: Andrey Konovalov <andreyknvl@google.com> Cc: Branislav Rankov <Branislav.Rankov@arm.com>, Marco Elver <elver@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Evgenii Stepanov <eugenis@google.com>, LKML <linux-kernel@vger.kernel.org>, kasan-dev <kasan-dev@googlegroups.com>, Alexander Potapenko <glider@google.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com> Subject: Re: [PATCH v7 3/4] kasan: Add report for async mode Date: Fri, 22 Jan 2021 15:01:01 +0000 [thread overview] Message-ID: <42b4d820-0a33-35a0-0dd0-0381dd693b9e@arm.com> (raw) In-Reply-To: <CAAeHK+ydhzfrdrPbjok20rgMEYykpfmjcRASm_bTfhuTVXF_VA@mail.gmail.com> On 1/22/21 2:42 PM, Andrey Konovalov wrote: > On Fri, Jan 22, 2021 at 3:11 PM Vincenzo Frascino > <vincenzo.frascino@arm.com> wrote: >> >> KASAN provides an asynchronous mode of execution. >> >> Add reporting functionality for this mode. >> >> Cc: Dmitry Vyukov <dvyukov@google.com> >> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> >> Cc: Alexander Potapenko <glider@google.com> >> Cc: Andrey Konovalov <andreyknvl@google.com> >> Reviewed-by: Andrey Konovalov <andreyknvl@google.com> >> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> >> --- >> include/linux/kasan.h | 2 ++ >> mm/kasan/report.c | 13 +++++++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/include/linux/kasan.h b/include/linux/kasan.h >> index bb862d1f0e15..b0a1d9dfa85c 100644 >> --- a/include/linux/kasan.h >> +++ b/include/linux/kasan.h >> @@ -351,6 +351,8 @@ static inline void *kasan_reset_tag(const void *addr) >> bool kasan_report(unsigned long addr, size_t size, >> bool is_write, unsigned long ip); >> >> +void kasan_report_async(void); >> + >> #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ >> >> static inline void *kasan_reset_tag(const void *addr) >> diff --git a/mm/kasan/report.c b/mm/kasan/report.c >> index 234f35a84f19..1390da06a988 100644 >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -358,6 +358,19 @@ void kasan_report_invalid_free(void *object, unsigned long ip) >> end_report(&flags); >> } >> >> +#if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) > > This looks wrong, CONFIG_KASAN_SW_TAGS doesn't use MTE, so this > function isn't needed for that mode. > It is true, I will fix in v8. > Let's add an #ifdef CONFIG_KASAN_HW_TAGS section in > include/linux/kasan.h after the HW/SW one with kasan_report(). And > only leave CONFIG_KASAN_HW_TAGS in mm/kasan/report.c too. > >> +void kasan_report_async(void) >> +{ >> + unsigned long flags; >> + >> + start_report(&flags); >> + pr_err("BUG: KASAN: invalid-access\n"); >> + pr_err("Asynchronous mode enabled: no access details available\n"); >> + dump_stack(); >> + end_report(&flags); >> +} >> +#endif /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ >> + >> static void __kasan_report(unsigned long addr, size_t size, bool is_write, >> unsigned long ip) >> { >> -- >> 2.30.0 >> -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-22 15:40 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-22 14:11 [PATCH v7 0/4] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino 2021-01-22 14:11 ` Vincenzo Frascino 2021-01-22 14:11 ` [PATCH v7 1/4] arm64: mte: Add asynchronous " Vincenzo Frascino 2021-01-22 14:11 ` Vincenzo Frascino 2021-01-22 14:11 ` [PATCH v7 2/4] kasan: Add KASAN mode kernel parameter Vincenzo Frascino 2021-01-22 14:11 ` Vincenzo Frascino 2021-01-22 14:36 ` Andrey Konovalov 2021-01-22 14:36 ` Andrey Konovalov 2021-01-22 14:11 ` [PATCH v7 3/4] kasan: Add report for async mode Vincenzo Frascino 2021-01-22 14:11 ` Vincenzo Frascino 2021-01-22 14:42 ` Andrey Konovalov 2021-01-22 14:42 ` Andrey Konovalov 2021-01-22 15:01 ` Vincenzo Frascino [this message] 2021-01-22 15:01 ` Vincenzo Frascino 2021-01-22 14:11 ` [PATCH v7 4/4] arm64: mte: Enable async tag check fault Vincenzo Frascino 2021-01-22 14:11 ` Vincenzo Frascino 2021-01-22 14:43 ` Andrey Konovalov 2021-01-22 14:43 ` Andrey Konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=42b4d820-0a33-35a0-0dd0-0381dd693b9e@arm.com \ --to=vincenzo.frascino@arm.com \ --cc=Branislav.Rankov@arm.com \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.