All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: rk3399: Fix eMMC get_clk reg offset
@ 2020-05-24 16:43 ` Jagan Teki
  0 siblings, 0 replies; 4+ messages in thread
From: Jagan Teki @ 2020-05-24 16:43 UTC (permalink / raw)
  To: Kever Yang, Simon Glass, Philipp Tomsich
  Cc: sunil, u-boot, linux-rockchip, linux-amarula, Jagan Teki

Actual eMMC get_clk register is clksel_con22 instead of
clksel_con21.

Fix it.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/clk/rockchip/clk_rk3399.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c
index 6a78837619..4caf3b5617 100644
--- a/drivers/clk/rockchip/clk_rk3399.c
+++ b/drivers/clk/rockchip/clk_rk3399.c
@@ -728,7 +728,7 @@ static ulong rk3399_mmc_get_clk(struct rockchip_cru *cru, uint clk_id)
 		div = 2;
 		break;
 	case SCLK_EMMC:
-		con = readl(&cru->clksel_con[21]);
+		con = readl(&cru->clksel_con[22]);
 		div = 1;
 		break;
 	default:
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] clk: rk3399: Fix eMMC get_clk reg offset
@ 2020-05-24 16:43 ` Jagan Teki
  0 siblings, 0 replies; 4+ messages in thread
From: Jagan Teki @ 2020-05-24 16:43 UTC (permalink / raw)
  To: u-boot

Actual eMMC get_clk register is clksel_con22 instead of
clksel_con21.

Fix it.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/clk/rockchip/clk_rk3399.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c
index 6a78837619..4caf3b5617 100644
--- a/drivers/clk/rockchip/clk_rk3399.c
+++ b/drivers/clk/rockchip/clk_rk3399.c
@@ -728,7 +728,7 @@ static ulong rk3399_mmc_get_clk(struct rockchip_cru *cru, uint clk_id)
 		div = 2;
 		break;
 	case SCLK_EMMC:
-		con = readl(&cru->clksel_con[21]);
+		con = readl(&cru->clksel_con[22]);
 		div = 1;
 		break;
 	default:
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] clk: rk3399: Fix eMMC get_clk reg offset
  2020-05-24 16:43 ` Jagan Teki
@ 2020-05-25  2:48   ` Kever Yang
  -1 siblings, 0 replies; 4+ messages in thread
From: Kever Yang @ 2020-05-25  2:48 UTC (permalink / raw)
  To: Jagan Teki, Simon Glass, Philipp Tomsich
  Cc: sunil, u-boot, linux-rockchip, linux-amarula


On 2020/5/25 上午12:43, Jagan Teki wrote:
> Actual eMMC get_clk register is clksel_con22 instead of
> clksel_con21.
>
> Fix it.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/clk/rockchip/clk_rk3399.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c
> index 6a78837619..4caf3b5617 100644
> --- a/drivers/clk/rockchip/clk_rk3399.c
> +++ b/drivers/clk/rockchip/clk_rk3399.c
> @@ -728,7 +728,7 @@ static ulong rk3399_mmc_get_clk(struct rockchip_cru *cru, uint clk_id)
>   		div = 2;
>   		break;
>   	case SCLK_EMMC:
> -		con = readl(&cru->clksel_con[21]);
> +		con = readl(&cru->clksel_con[22]);
>   		div = 1;
>   		break;
>   	default:

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] clk: rk3399: Fix eMMC get_clk reg offset
@ 2020-05-25  2:48   ` Kever Yang
  0 siblings, 0 replies; 4+ messages in thread
From: Kever Yang @ 2020-05-25  2:48 UTC (permalink / raw)
  To: u-boot


On 2020/5/25 ??12:43, Jagan Teki wrote:
> Actual eMMC get_clk register is clksel_con22 instead of
> clksel_con21.
>
> Fix it.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/clk/rockchip/clk_rk3399.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c
> index 6a78837619..4caf3b5617 100644
> --- a/drivers/clk/rockchip/clk_rk3399.c
> +++ b/drivers/clk/rockchip/clk_rk3399.c
> @@ -728,7 +728,7 @@ static ulong rk3399_mmc_get_clk(struct rockchip_cru *cru, uint clk_id)
>   		div = 2;
>   		break;
>   	case SCLK_EMMC:
> -		con = readl(&cru->clksel_con[21]);
> +		con = readl(&cru->clksel_con[22]);
>   		div = 1;
>   		break;
>   	default:

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-25  2:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24 16:43 [PATCH] clk: rk3399: Fix eMMC get_clk reg offset Jagan Teki
2020-05-24 16:43 ` Jagan Teki
2020-05-25  2:48 ` Kever Yang
2020-05-25  2:48   ` Kever Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.