[PATCH] dt-bindings: rtc: ti,bq32k: Convert to json-schema

[PATCH] dt-bindings: rtc: ti,bq32k: Convert to json-schema

[Geert Uytterhoeven]

Convert the TI BQ32000 I2C Serial Real-Time Clock Device Tree binding
documentation to json-schema.

Document missing properties.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 .../devicetree/bindings/rtc/ti,bq32000.yaml   | 49 +++++++++++++++++++
 .../devicetree/bindings/rtc/ti,bq32k.txt      | 18 -------
 2 files changed, 49 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
 delete mode 100644 Documentation/devicetree/bindings/rtc/ti,bq32k.txt

diff --git a/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
new file mode 100644
index 0000000000000000..392bd71bd1bee25c
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/ti,bq32000.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI BQ32000 I2C Serial Real-Time Clock
+
+maintainers:
+  - Pavel Machek <pavel@ucw.cz>
+
+allOf:
+  - $ref: rtc.yaml#
+
+properties:
+  compatible:
+    const: ti,bq32000
+
+  reg:
+    const: 0x68
+
+  interrupts:
+    maxItems: 1
+
+  start-year: true
+
+  trickle-resistor-ohms:
+    enum: [ 1120, 20180 ]
+
+  trickle-diode-disable: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            bq32000: rtc@68 {
+                    compatible = "ti,bq32000";
+                    reg = <0x68>;
+                    trickle-resistor-ohms = <1120>;
+            };
+    };
diff --git a/Documentation/devicetree/bindings/rtc/ti,bq32k.txt b/Documentation/devicetree/bindings/rtc/ti,bq32k.txt
deleted file mode 100644
index e204906b9ad3b161..0000000000000000
--- a/Documentation/devicetree/bindings/rtc/ti,bq32k.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-* TI BQ32000                I2C Serial Real-Time Clock
-
-Required properties:
-- compatible: Should contain "ti,bq32000".
-- reg: I2C address for chip
-
-Optional properties:
-- trickle-resistor-ohms : Selected resistor for trickle charger
-       Values usable are 1120 and 20180
-       Should be given if trickle charger should be enabled
-- trickle-diode-disable : Do not use internal trickle charger diode
-       Should be given if internal trickle charger diode should be disabled
-Example:
-       bq32000: rtc@68 {
-               compatible = "ti,bq32000";
-               trickle-resistor-ohms = <1120>;
-               reg = <0x68>;
-       };
-- 
2.25.1

Re: [PATCH] dt-bindings: rtc: ti,bq32k: Convert to json-schema

[Rob Herring]

On Wed, 16 Jun 2021 15:51:43 +0200, Geert Uytterhoeven wrote:
> Convert the TI BQ32000 I2C Serial Real-Time Clock Device Tree binding
> documentation to json-schema.
> 
> Document missing properties.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  .../devicetree/bindings/rtc/ti,bq32000.yaml   | 49 +++++++++++++++++++
>  .../devicetree/bindings/rtc/ti,bq32k.txt      | 18 -------
>  2 files changed, 49 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
>  delete mode 100644 Documentation/devicetree/bindings/rtc/ti,bq32k.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH] dt-bindings: rtc: ti,bq32k: Convert to json-schema

[Alexandre Belloni]

On Wed, 16 Jun 2021 15:51:43 +0200, Geert Uytterhoeven wrote:
> Convert the TI BQ32000 I2C Serial Real-Time Clock Device Tree binding
> documentation to json-schema.
> 
> Document missing properties.

Applied, thanks!

[1/1] dt-bindings: rtc: ti,bq32k: Convert to json-schema
      commit: 4a7e7408688de048bffa5e0e00d246b5f854bcf7

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

Re: [PATCH] dt-bindings: rtc: ti,bq32k: Convert to json-schema

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

Hi!

> Convert the TI BQ32000 I2C Serial Real-Time Clock Device Tree binding
> documentation to json-schema.
> 
> Document missing properties.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> index 0000000000000000..392bd71bd1bee25c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/ti,bq32000.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI BQ32000 I2C Serial Real-Time Clock
> +
> +maintainers:
> +  - Pavel Machek <pavel@ucw.cz>

I'm not sure why I'm listed here, but I probably should not be. I
don't have access to that hardware any more.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH] dt-bindings: rtc: ti,bq32k: Convert to json-schema

[Geert Uytterhoeven]

Hi Pavel,

On Sun, Jun 20, 2021 at 10:55 PM Pavel Machek <pavel@ucw.cz> wrote:
> > Convert the TI BQ32000 I2C Serial Real-Time Clock Device Tree binding
> > documentation to json-schema.
> >
> > Document missing properties.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > index 0000000000000000..392bd71bd1bee25c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/ti,bq32000.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: TI BQ32000 I2C Serial Real-Time Clock
> > +
> > +maintainers:
> > +  - Pavel Machek <pavel@ucw.cz>
>
> I'm not sure why I'm listed here, but I probably should not be. I
> don't have access to that hardware any more.

You wrote the bindings, and are the only person who ever modified
the file before.
I see Alexandre has already assumed maintainership in the mean time.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds