[Intel-wired-lan] [PATCH 1/2] net/ice: Fix boolean assignment

[Intel-wired-lan] [PATCH 1/2] net/ice: Fix boolean assignment

[Shiraz Saleem]

From: "Shiraz Saleem" <shiraz.saleem@intel.com>

vbool in ice_devlink_enable_roce_get can be assigned to a
non-0/1 constant.

Fix this assignment of vbool to be 0/1.

Fixes: e523af4ee560 ("net/ice: Add support for enable_iwarp and enable_roce devlink param")
Suggested-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/intel/ice/ice_devlink.c
index 478412b..1cfe918 100644
--- a/drivers/net/ethernet/intel/ice/ice_devlink.c
+++ b/drivers/net/ethernet/intel/ice/ice_devlink.c
@@ -436,7 +436,7 @@ static int ice_devlink_info_get(struct devlink *devlink,
 {
 	struct ice_pf *pf = devlink_priv(devlink);
 
-	ctx->val.vbool = pf->rdma_mode & IIDC_RDMA_PROTOCOL_ROCEV2;
+	ctx->val.vbool = pf->rdma_mode & IIDC_RDMA_PROTOCOL_ROCEV2 ? true : false;
 
 	return 0;
 }
-- 
1.8.3.1

[Intel-wired-lan] [PATCH 2/2] net/ice: Remove unused enum

[Shiraz Saleem]

From: "Shiraz Saleem" <shiraz.saleem@intel.com>

Remove ice_devlink_param_id enum as its not used.

Suggested-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_devlink.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.h b/drivers/net/ethernet/intel/ice/ice_devlink.h
index faea757..fe006d9 100644
--- a/drivers/net/ethernet/intel/ice/ice_devlink.h
+++ b/drivers/net/ethernet/intel/ice/ice_devlink.h
@@ -4,10 +4,6 @@
 #ifndef _ICE_DEVLINK_H_
 #define _ICE_DEVLINK_H_
 
-enum ice_devlink_param_id {
-	ICE_DEVLINK_PARAM_ID_BASE = DEVLINK_PARAM_GENERIC_ID_MAX,
-};
-
 struct ice_pf *ice_allocate_pf(struct device *dev);
 
 void ice_devlink_register(struct ice_pf *pf);
-- 
1.8.3.1

[Intel-wired-lan] [PATCH 2/2] net/ice: Remove unused enum

[Paul Menzel]

Dear Shiraz,


Am 24.11.21 um 13:41 schrieb Shiraz Saleem:
> From: "Shiraz Saleem" <shiraz.saleem@intel.com>
> 
> Remove ice_devlink_param_id enum as its not used.

Please add the name `ice_devlink_param_id` to the commit message summary.

[?]


Kind regards,

Paul

[Intel-wired-lan] [PATCH 2/2] net/ice: Remove unused enum

[Jesse Brandeburg]

On 11/24/2021 4:47 AM, Paul Menzel wrote:
> Dear Shiraz,
> 
> 
> Am 24.11.21 um 13:41 schrieb Shiraz Saleem:
>> From: "Shiraz Saleem" <shiraz.saleem@intel.com>
>>
>> Remove ice_devlink_param_id enum as its not used.
> 
> Please add the name `ice_devlink_param_id` to the commit message summary.

Hi Paul, I don't think that is necessary, is this just personal 
preference or are you following some style guideline that I don't know 
about or maybe just don't remember?

I'd argue that the subject line has a different bug, it should be:
[PATCH net-next] ice: Remove unused enum

But I see no reason to add the long string of the actual enum removed to 
the subject.

Jesse

[Intel-wired-lan] [PATCH 2/2] net/ice: Remove unused enum

[Paul Menzel]

Dear Jesse,


Am 29.11.21 um 22:31 schrieb Jesse Brandeburg:
> On 11/24/2021 4:47 AM, Paul Menzel wrote:

>> Am 24.11.21 um 13:41 schrieb Shiraz Saleem:
>>> From: "Shiraz Saleem" <shiraz.saleem@intel.com>
>>>
>>> Remove ice_devlink_param_id enum as its not used.
>>
>> Please add the name `ice_devlink_param_id` to the commit message summary.
> 
> Hi Paul, I don't think that is necessary, is this just personal 
> preference or are you following some style guideline that I don't know 
> about or maybe just don't remember?
> 
> I'd argue that the subject line has a different bug, it should be:
> [PATCH net-next] ice: Remove unused enum
> 
> But I see no reason to add the long string of the actual enum removed to 
> the subject.

Reading through `git log --oneline`, which is also used in the 
announcement emails, the line

> ice: Remove unused enum

would make me need to look into the commit to find out if something 
?important? was removed. Using

> ice: Remove unused enum ice_devlink_param_id

would make that unnecessary for me.


Kind regards,

Paul