[PATCH v2] wifi: mac80211: update rx nss for the link sta

[PATCH v2] wifi: mac80211: update rx nss for the link sta

[Sriram R]

Update nss info for the non default link stations
which gets added during ML assoc when link stations
gets added. For the default link sta which was added
during auth time, the nss would be updated in the usual
flow during set station post assoc once the capabilities
are available.

Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
---
v2: added wifi prefix in commit title
 net/mac80211/cfg.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index 72df8c708a2d..0fdf92e1428f 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -1754,6 +1754,15 @@ static int sta_link_apply_parameters(struct ieee80211_local *local,
 						    params->eht_capa_len,
 						    link_sta);
 
+	/* update nss if not done already for the link sta,
+	 * for the deflink the nss will be updated once the
+	 * assoc flag is set through set station. For the
+	 * non-deflink sta we would reach here only during assoc,
+	 * so we would have all caps to calculate the nss.
+	 */
+	if (&sta->deflink != link_sta)
+		ieee80211_sta_set_rx_nss(link_sta);
+
 	if (params->opmode_notif_used) {
 		/* returned value is only needed for rc update, but the
 		 * rc isn't initialized here yet, so ignore it
-- 
2.17.1

Re: [PATCH v2] wifi: mac80211: update rx nss for the link sta

[Johannes Berg]

On Fri, 2023-01-20 at 03:42 +0530, Sriram R wrote:
> Update nss info for the non default link stations
> which gets added during ML assoc when link stations
> gets added. For the default link sta which was added
> during auth time, the nss would be updated in the usual
> flow during set station post assoc once the capabilities
> are available.
> 
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
> ---
> v2: added wifi prefix in commit title
>  net/mac80211/cfg.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 72df8c708a2d..0fdf92e1428f 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -1754,6 +1754,15 @@ static int sta_link_apply_parameters(struct ieee80211_local *local,
>  						    params->eht_capa_len,
>  						    link_sta);
>  
> +	/* update nss if not done already for the link sta,
> +	 * for the deflink the nss will be updated once the
> +	 * assoc flag is set through set station. For the
> +	 * non-deflink sta we would reach here only during assoc,
> +	 * so we would have all caps to calculate the nss.
> +	 */
> +	if (&sta->deflink != link_sta)

NACK on that check. Please find a better place, or change the existing
code as well, or something.

johannes

RE: [PATCH v2] wifi: mac80211: update rx nss for the link sta

[Sriram R (QUIC)]

>-----Original Message-----
>From: Johannes Berg <johannes@sipsolutions.net>
>Sent: Tuesday, February 14, 2023 6:18 PM
>To: Sriram R (QUIC) <quic_srirrama@quicinc.com>
>Cc: linux-wireless@vger.kernel.org
>Subject: Re: [PATCH v2] wifi: mac80211: update rx nss for the link sta
>
>On Fri, 2023-01-20 at 03:42 +0530, Sriram R wrote:
>> Update nss info for the non default link stations which gets added
>> during ML assoc when link stations gets added. For the default link
>> sta which was added during auth time, the nss would be updated in the
>> usual flow during set station post assoc once the capabilities are
>> available.
>>
>> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
>> ---
>> v2: added wifi prefix in commit title
>>  net/mac80211/cfg.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index
>> 72df8c708a2d..0fdf92e1428f 100644
>> --- a/net/mac80211/cfg.c
>> +++ b/net/mac80211/cfg.c
>> @@ -1754,6 +1754,15 @@ static int sta_link_apply_parameters(struct
>ieee80211_local *local,
>>  						    params->eht_capa_len,
>>  						    link_sta);
>>
>> +	/* update nss if not done already for the link sta,
>> +	 * for the deflink the nss will be updated once the
>> +	 * assoc flag is set through set station. For the
>> +	 * non-deflink sta we would reach here only during assoc,
>> +	 * so we would have all caps to calculate the nss.
>> +	 */
>> +	if (&sta->deflink != link_sta)
>
>NACK on that check. Please find a better place, or change the existing code as
>well, or something.
>
Ok Sure, let me review this part on where it can be updated.
Thanks,
Sriram.R