[PATCH 0/4] rcar-du: add R8A774[35] DU driver(s) support

[PATCH 0/4] rcar-du: add R8A774[35] DU driver(s) support

[Fabrizio Castro]

In order to be able to define du nodes in r8a7743 and r8a7745 device
trees, we need to define data structures, compatible strings, missing
clock, and update the dt-bindings.
I'll send out the patches to add the du nodes in r8a774[35] device trees
once the patches in this series get accepted.

Best regards,

Fabrizio Castro (4):
  dt-bindings: display: rcar-du: Document R8A774[35] DU
  drm: rcar-du: Add R8A7743 support
  clk: renesas: cpg-mssr: Add du1 clock to R8A7745
  drm: rcar-du: Add R8A7745 support

 .../devicetree/bindings/display/renesas,du.txt     | 30 ++++++++-------
 drivers/clk/renesas/r8a7745-cpg-mssr.c             |  1 +
 drivers/gpu/drm/rcar-du/rcar_du_drv.c              | 44 ++++++++++++++++++++++
 3 files changed, 62 insertions(+), 13 deletions(-)

-- 
2.7.4

[PATCH 1/4] dt-bindings: display: rcar-du: Document R8A774[35] DU

[Fabrizio Castro]

Add device tree bindings for r8a7743 and r8a7745 DUs.
r8a7743 DU is similar to the one from r8a7791, r8a7745 DU is similar
to the one from r8a7794.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 .../devicetree/bindings/display/renesas,du.txt     | 30 ++++++++++++----------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index 4bbd1e9..c520226 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -3,6 +3,8 @@
 Required Properties:
 
   - compatible: must be one of the following.
+    - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
+    - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
     - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
     - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
     - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
@@ -27,10 +29,10 @@ Required Properties:
   - clock-names: Name of the clocks. This property is model-dependent.
     - R8A7779 uses a single functional clock. The clock doesn't need to be
       named.
-    - R8A779[0123456] use one functional clock per channel and one clock per
-      LVDS encoder (if available). The functional clocks must be named "du.x"
-      with "x" being the channel numerical index. The LVDS clocks must be
-      named "lvds.x" with "x" being the LVDS encoder numerical index.
+    - R8A779[0123456] and R8A774[35] use one functional clock per channel and
+      one clock per LVDS encoder (if available). The functional clocks must be
+      named "du.x" with "x" being the channel numerical index. The LVDS clocks
+      must be named "lvds.x" with "x" being the LVDS encoder numerical index.
     - In addition to the functional and encoder clocks, all DU versions also
       support externally supplied pixel clocks. Those clocks are optional.
       When supplied they must be named "dclkin.x" with "x" being the input
@@ -49,16 +51,18 @@ bindings specified in Documentation/devicetree/bindings/graph.txt.
 The following table lists for each supported model the port number
 corresponding to each DU output.
 
-		Port 0		Port1		Port2		Port3
+                      Port0          Port1          Port2          Port3
 -----------------------------------------------------------------------------
- R8A7779 (H1)	DPAD 0		DPAD 1		-		-
- R8A7790 (H2)	DPAD		LVDS 0		LVDS 1		-
- R8A7791 (M2-W)	DPAD		LVDS 0		-		-
- R8A7792 (V2H)	DPAD 0		DPAD 1		-		-
- R8A7793 (M2-N)	DPAD		LVDS 0		-		-
- R8A7794 (E2)	DPAD 0		DPAD 1		-		-
- R8A7795 (H3)	DPAD		HDMI 0		HDMI 1		LVDS
- R8A7796 (M3-W)	DPAD		HDMI		LVDS		-
+ R8A7743 (RZ/G1M)     DPAD 0         LVDS 0         -              -
+ R8A7745 (RZ/G1E)     DPAD 0         DPAD 1         -              -
+ R8A7779 (R-Car H1)   DPAD 0         DPAD 1         -              -
+ R8A7790 (R-Car H2)   DPAD           LVDS 0         LVDS 1         -
+ R8A7791 (R-Car M2-W) DPAD           LVDS 0         -              -
+ R8A7792 (R-Car V2H)  DPAD 0         DPAD 1         -              -
+ R8A7793 (R-Car M2-N) DPAD           LVDS 0         -              -
+ R8A7794 (R-Car E2)   DPAD 0         DPAD 1         -              -
+ R8A7795 (R-Car H3)   DPAD           HDMI 0         HDMI 1         LVDS
+ R8A7796 (R-Car M3-W) DPAD           HDMI           LVDS           -
 
 
 Example: R8A7795 (R-Car H3) ES2.0 DU
-- 
2.7.4

[PATCH 2/4] drm: rcar-du: Add R8A7743 support

[Fabrizio Castro]

Add support for the R8A7743 DU (which is very similar to the R8A7791 DU);
it has 1 DPAD (RGB) output and 1 LVDS output.

Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index d2f29e6..3db5e8d 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -34,6 +34,27 @@
  * Device Information
  */
 
+static const struct rcar_du_device_info rzg1_du_r8a7743_info = {
+	.gen = 2,
+	.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
+		  | RCAR_DU_FEATURE_EXT_CTRL_REGS,
+	.num_crtcs = 2,
+	.routes = {
+		/*
+		 * R8A7743 has one RGB output and one LVDS output
+		 */
+		[RCAR_DU_OUTPUT_DPAD0] = {
+			.possible_crtcs = BIT(1) | BIT(0),
+			.port = 0,
+		},
+		[RCAR_DU_OUTPUT_LVDS0] = {
+			.possible_crtcs = BIT(0),
+			.port = 1,
+		},
+	},
+	.num_lvds = 1,
+};
+
 static const struct rcar_du_device_info rcar_du_r8a7779_info = {
 	.gen = 2,
 	.features = 0,
@@ -207,6 +228,7 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = {
 };
 
 static const struct of_device_id rcar_du_of_table[] = {
+	{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
 	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
 	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
 	{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/4] drm: rcar-du: Add R8A7743 support

[Fabrizio Castro]

Add support for the R8A7743 DU (which is very similar to the R8A7791 DU);
it has 1 DPAD (RGB) output and 1 LVDS output.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index d2f29e6..3db5e8d 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -34,6 +34,27 @@
  * Device Information
  */
 
+static const struct rcar_du_device_info rzg1_du_r8a7743_info = {
+	.gen = 2,
+	.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
+		  | RCAR_DU_FEATURE_EXT_CTRL_REGS,
+	.num_crtcs = 2,
+	.routes = {
+		/*
+		 * R8A7743 has one RGB output and one LVDS output
+		 */
+		[RCAR_DU_OUTPUT_DPAD0] = {
+			.possible_crtcs = BIT(1) | BIT(0),
+			.port = 0,
+		},
+		[RCAR_DU_OUTPUT_LVDS0] = {
+			.possible_crtcs = BIT(0),
+			.port = 1,
+		},
+	},
+	.num_lvds = 1,
+};
+
 static const struct rcar_du_device_info rcar_du_r8a7779_info = {
 	.gen = 2,
 	.features = 0,
@@ -207,6 +228,7 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = {
 };
 
 static const struct of_device_id rcar_du_of_table[] = {
+	{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
 	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
 	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
 	{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
-- 
2.7.4

[PATCH 3/4] clk: renesas: cpg-mssr: Add du1 clock to R8A7745

[Fabrizio Castro]

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 drivers/clk/renesas/r8a7745-cpg-mssr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/renesas/r8a7745-cpg-mssr.c b/drivers/clk/renesas/r8a7745-cpg-mssr.c
index 9e2360a..2859504 100644
--- a/drivers/clk/renesas/r8a7745-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7745-cpg-mssr.c
@@ -129,6 +129,7 @@ static const struct mssr_mod_clk r8a7745_mod_clks[] __initconst = {
 	DEF_MOD("scif2",		 719,	R8A7745_CLK_P),
 	DEF_MOD("scif1",		 720,	R8A7745_CLK_P),
 	DEF_MOD("scif0",		 721,	R8A7745_CLK_P),
+	DEF_MOD("du1",			 723,	R8A7745_CLK_ZX),
 	DEF_MOD("du0",			 724,	R8A7745_CLK_ZX),
 	DEF_MOD("ipmmu-sgx",		 800,	R8A7745_CLK_ZX),
 	DEF_MOD("vin1",			 810,	R8A7745_CLK_ZG),
-- 
2.7.4

[PATCH 4/4] drm: rcar-du: Add R8A7745 support

[Fabrizio Castro]

Add support for the R8A7745 DU (which is very similar to the R8A7794 DU);
it has 2 RGB outputs.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 3db5e8d..faa5b32 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -55,6 +55,27 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info = {
 	.num_lvds = 1,
 };
 
+static const struct rcar_du_device_info rzg1_du_r8a7745_info = {
+	.gen = 2,
+	.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
+		  | RCAR_DU_FEATURE_EXT_CTRL_REGS,
+	.num_crtcs = 2,
+	.routes = {
+		/*
+		 * R8A7745 has two RGB outputs
+		 */
+		[RCAR_DU_OUTPUT_DPAD0] = {
+			.possible_crtcs = BIT(0),
+			.port = 0,
+		},
+		[RCAR_DU_OUTPUT_DPAD1] = {
+			.possible_crtcs = BIT(1),
+			.port = 1,
+		},
+	},
+	.num_lvds = 0,
+};
+
 static const struct rcar_du_device_info rcar_du_r8a7779_info = {
 	.gen = 2,
 	.features = 0,
@@ -229,6 +250,7 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = {
 
 static const struct of_device_id rcar_du_of_table[] = {
 	{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
+	{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
 	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
 	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
 	{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
-- 
2.7.4

Re: [PATCH 3/4] clk: renesas: cpg-mssr: Add du1 clock to R8A7745

[Geert Uytterhoeven]

On Fri, Oct 13, 2017 at 5:22 PM, Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in clk-renesas-for-v4.15.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/4] dt-bindings: display: rcar-du: Document R8A774[35] DU

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Friday, 13 October 2017 18:22:19 EEST Fabrizio Castro wrote:
> Add device tree bindings for r8a7743 and r8a7745 DUs.
> r8a7743 DU is similar to the one from r8a7791, r8a7745 DU is similar
> to the one from r8a7794.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
>  .../devicetree/bindings/display/renesas,du.txt     | 30 ++++++++++---------
>  1 file changed, 17 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> 4bbd1e9..c520226 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -3,6 +3,8 @@
>  Required Properties:
> 
>    - compatible: must be one of the following.
> +    - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> +    - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
>      - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
>      - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
>      - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> @@ -27,10 +29,10 @@ Required Properties:
>    - clock-names: Name of the clocks. This property is model-dependent.
>      - R8A7779 uses a single functional clock. The clock doesn't need to be
>        named.
> -    - R8A779[0123456] use one functional clock per channel and one clock
> per
> -      LVDS encoder (if available). The functional clocks must be named
> "du.x"
> -      with "x" being the channel numerical index. The LVDS clocks must be
> -      named "lvds.x" with "x" being the LVDS encoder numerical index.
> +    - R8A779[0123456] and R8A774[35] use one functional clock per channel

How about "All other DU instances use one functional clock..." ? I expect more 
entries to the added in the future, it would be nice not to have to modify 
this paragraph.

> and 
> +      one clock per LVDS encoder (if available). The functional clocks must
> be
> +      named "du.x" with "x" being the channel numerical index. The LVDS
> clocks
> +      must be named "lvds.x" with "x" being the LVDS encoder numerical
> index.
> - In addition to the functional and encoder clocks, all DU versions also
> support externally supplied pixel clocks. Those clocks are optional. When
> supplied they must be named "dclkin.x" with "x" being the input
> @@ -49,16 +51,18 @@ bindings specified
> in Documentation/devicetree/bindings/graph.txt. The following table lists
> for each supported model the port number corresponding to each DU output.
> 
> -		Port 0		Port1		Port2		Port3
> +                      Port0          Port1          Port2          Port3
>  ---------------------------------------------------------------------------
> -- - R8A7779 (H1)	DPAD 0		DPAD 1		-		-
> - R8A7790 (H2)	DPAD		LVDS 0		LVDS 1		-
> - R8A7791 (M2-W)	DPAD		LVDS 0		-		-
> - R8A7792 (V2H)	DPAD 0		DPAD 1		-		-
> - R8A7793 (M2-N)	DPAD		LVDS 0		-		-
> - R8A7794 (E2)	DPAD 0		DPAD 1		-		-
> - R8A7795 (H3)	DPAD		HDMI 0		HDMI 1		LVDS
> - R8A7796 (M3-W)	DPAD		HDMI		LVDS		-
> + R8A7743 (RZ/G1M)     DPAD 0         LVDS 0         -              -

When there's a single DPAD the table mentions "DPAD" instead of "DPAD 0". 
There's no specific reason for that other than a historical one, but to keep 
entries consistent I would either keep doing so, or rename DPAD to DPAD 0 in 
all existing entries. What would you prefer ?

If you're fine with these changes there's no need to submit a new version, I 
can fix when applying the patch to my tree.

> + R8A7745 (RZ/G1E)     DPAD 0         DPAD 1         -              -
> + R8A7779 (R-Car H1)   DPAD 0         DPAD 1         -              -
> + R8A7790 (R-Car H2)   DPAD           LVDS 0         LVDS 1         -
> + R8A7791 (R-Car M2-W) DPAD           LVDS 0         -              -
> + R8A7792 (R-Car V2H)  DPAD 0         DPAD 1         -              -
> + R8A7793 (R-Car M2-N) DPAD           LVDS 0         -              -
> + R8A7794 (R-Car E2)   DPAD 0         DPAD 1         -              -
> + R8A7795 (R-Car H3)   DPAD           HDMI 0         HDMI 1         LVDS
> + R8A7796 (R-Car M3-W) DPAD           HDMI           LVDS           -
> 
> 
>  Example: R8A7795 (R-Car H3) ES2.0 DU


-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/4] drm: rcar-du: Add R8A7743 support

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Friday, 13 October 2017 18:22:20 EEST Fabrizio Castro wrote:
> Add support for the R8A7743 DU (which is very similar to the R8A7791 DU);
> it has 1 DPAD (RGB) output and 1 LVDS output.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and taken in my tree.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index d2f29e6..3db5e8d 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -34,6 +34,27 @@
>   * Device Information
>   */
> 
> +static const struct rcar_du_device_info rzg1_du_r8a7743_info = {
> +	.gen = 2,
> +	.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> +		  | RCAR_DU_FEATURE_EXT_CTRL_REGS,
> +	.num_crtcs = 2,
> +	.routes = {
> +		/*
> +		 * R8A7743 has one RGB output and one LVDS output
> +		 */
> +		[RCAR_DU_OUTPUT_DPAD0] = {
> +			.possible_crtcs = BIT(1) | BIT(0),
> +			.port = 0,
> +		},
> +		[RCAR_DU_OUTPUT_LVDS0] = {
> +			.possible_crtcs = BIT(0),
> +			.port = 1,
> +		},
> +	},
> +	.num_lvds = 1,
> +};
> +
>  static const struct rcar_du_device_info rcar_du_r8a7779_info = {
>  	.gen = 2,
>  	.features = 0,
> @@ -207,6 +228,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a7796_info = { };
> 
>  static const struct of_device_id rcar_du_of_table[] = {
> +	{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
>  	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
>  	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
>  	{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },

-- 
Regards,

Laurent Pinchart

Re: [PATCH 4/4] drm: rcar-du: Add R8A7745 support

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Friday, 13 October 2017 18:22:22 EEST Fabrizio Castro wrote:
> Add support for the R8A7745 DU (which is very similar to the R8A7794 DU);
> it has 2 RGB outputs.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and taken in my tree.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 3db5e8d..faa5b32 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -55,6 +55,27 @@ static const struct rcar_du_device_info
> rzg1_du_r8a7743_info = { .num_lvds = 1,
>  };
> 
> +static const struct rcar_du_device_info rzg1_du_r8a7745_info = {
> +	.gen = 2,
> +	.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> +		  | RCAR_DU_FEATURE_EXT_CTRL_REGS,
> +	.num_crtcs = 2,
> +	.routes = {
> +		/*
> +		 * R8A7745 has two RGB outputs
> +		 */
> +		[RCAR_DU_OUTPUT_DPAD0] = {
> +			.possible_crtcs = BIT(0),
> +			.port = 0,
> +		},
> +		[RCAR_DU_OUTPUT_DPAD1] = {
> +			.possible_crtcs = BIT(1),
> +			.port = 1,
> +		},
> +	},
> +	.num_lvds = 0,
> +};
> +
>  static const struct rcar_du_device_info rcar_du_r8a7779_info = {
>  	.gen = 2,
>  	.features = 0,
> @@ -229,6 +250,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a7796_info = {
> 
>  static const struct of_device_id rcar_du_of_table[] = {
>  	{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> +	{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
>  	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
>  	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
>  	{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/4] drm: rcar-du: Add R8A7745 support

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Friday, 13 October 2017 18:22:22 EEST Fabrizio Castro wrote:
> Add support for the R8A7745 DU (which is very similar to the R8A7794 DU);
> it has 2 RGB outputs.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and taken in my tree.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 3db5e8d..faa5b32 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -55,6 +55,27 @@ static const struct rcar_du_device_info
> rzg1_du_r8a7743_info = { .num_lvds = 1,
>  };
> 
> +static const struct rcar_du_device_info rzg1_du_r8a7745_info = {
> +	.gen = 2,
> +	.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> +		  | RCAR_DU_FEATURE_EXT_CTRL_REGS,
> +	.num_crtcs = 2,
> +	.routes = {
> +		/*
> +		 * R8A7745 has two RGB outputs
> +		 */
> +		[RCAR_DU_OUTPUT_DPAD0] = {
> +			.possible_crtcs = BIT(0),
> +			.port = 0,
> +		},
> +		[RCAR_DU_OUTPUT_DPAD1] = {
> +			.possible_crtcs = BIT(1),
> +			.port = 1,
> +		},
> +	},
> +	.num_lvds = 0,
> +};
> +
>  static const struct rcar_du_device_info rcar_du_r8a7779_info = {
>  	.gen = 2,
>  	.features = 0,
> @@ -229,6 +250,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a7796_info = {
> 
>  static const struct of_device_id rcar_du_of_table[] = {
>  	{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> +	{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
>  	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
>  	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
>  	{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },

-- 
Regards,

Laurent Pinchart

RE: [PATCH 1/4] dt-bindings: display: rcar-du: Document R8A774[35] DU

[Fabrizio Castro]

Hello Laurent,

thank you for getting back to me.

>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 13 October 2017 18:22:19 EEST Fabrizio Castro wrote:
> > Add device tree bindings for r8a7743 and r8a7745 DUs.
> > r8a7743 DU is similar to the one from r8a7791, r8a7745 DU is similar
> > to the one from r8a7794.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > ---
> >  .../devicetree/bindings/display/renesas,du.txt     | 30 ++++++++++---------
> >  1 file changed, 17 insertions(+), 13 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> > b/Documentation/devicetree/bindings/display/renesas,du.txt index
> > 4bbd1e9..c520226 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> > @@ -3,6 +3,8 @@
> >  Required Properties:
> >
> >    - compatible: must be one of the following.
> > +    - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> > +    - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> >      - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> >      - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> >      - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> > @@ -27,10 +29,10 @@ Required Properties:
> >    - clock-names: Name of the clocks. This property is model-dependent.
> >      - R8A7779 uses a single functional clock. The clock doesn't need to be
> >        named.
> > -    - R8A779[0123456] use one functional clock per channel and one clock
> > per
> > -      LVDS encoder (if available). The functional clocks must be named
> > "du.x"
> > -      with "x" being the channel numerical index. The LVDS clocks must be
> > -      named "lvds.x" with "x" being the LVDS encoder numerical index.
> > +    - R8A779[0123456] and R8A774[35] use one functional clock per channel
>
> How about "All other DU instances use one functional clock..." ? I expect more
> entries to the added in the future, it would be nice not to have to modify
> this paragraph.

I agree.

>
> > and
> > +      one clock per LVDS encoder (if available). The functional clocks must
> > be
> > +      named "du.x" with "x" being the channel numerical index. The LVDS
> > clocks
> > +      must be named "lvds.x" with "x" being the LVDS encoder numerical
> > index.
> > - In addition to the functional and encoder clocks, all DU versions also
> > support externally supplied pixel clocks. Those clocks are optional. When
> > supplied they must be named "dclkin.x" with "x" being the input
> > @@ -49,16 +51,18 @@ bindings specified
> > in Documentation/devicetree/bindings/graph.txt. The following table lists
> > for each supported model the port number corresponding to each DU output.
> >
> > -Port 0Port1Port2Port3
> > +                      Port0          Port1          Port2          Port3
> >  ---------------------------------------------------------------------------
> > -- - R8A7779 (H1)DPAD 0DPAD 1--
> > - R8A7790 (H2)DPADLVDS 0LVDS 1-
> > - R8A7791 (M2-W)DPADLVDS 0--
> > - R8A7792 (V2H)DPAD 0DPAD 1--
> > - R8A7793 (M2-N)DPADLVDS 0--
> > - R8A7794 (E2)DPAD 0DPAD 1--
> > - R8A7795 (H3)DPADHDMI 0HDMI 1LVDS
> > - R8A7796 (M3-W)DPADHDMILVDS-
> > + R8A7743 (RZ/G1M)     DPAD 0         LVDS 0         -              -
>
> When there's a single DPAD the table mentions "DPAD" instead of "DPAD 0".
> There's no specific reason for that other than a historical one, but to keep
> entries consistent I would either keep doing so, or rename DPAD to DPAD 0 in
> all existing entries. What would you prefer ?

My personal preference is to number all of the entries (not just DPAD ones).

>
> If you're fine with these changes there's no need to submit a new version, I
> can fix when applying the patch to my tree.

Thank you Laurent!

Best regards,
Fab

>
> > + R8A7745 (RZ/G1E)     DPAD 0         DPAD 1         -              -
> > + R8A7779 (R-Car H1)   DPAD 0         DPAD 1         -              -
> > + R8A7790 (R-Car H2)   DPAD           LVDS 0         LVDS 1         -
> > + R8A7791 (R-Car M2-W) DPAD           LVDS 0         -              -
> > + R8A7792 (R-Car V2H)  DPAD 0         DPAD 1         -              -
> > + R8A7793 (R-Car M2-N) DPAD           LVDS 0         -              -
> > + R8A7794 (R-Car E2)   DPAD 0         DPAD 1         -              -
> > + R8A7795 (R-Car H3)   DPAD           HDMI 0         HDMI 1         LVDS
> > + R8A7796 (R-Car M3-W) DPAD           HDMI           LVDS           -
> >
> >
> >  Example: R8A7795 (R-Car H3) ES2.0 DU
>
>
> --
> Regards,
>
> Laurent Pinchart




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/4] dt-bindings: display: rcar-du: Document R8A774[35] DU

[Fabrizio Castro]

Hello Laurent,

thank you for getting back to me.

>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 13 October 2017 18:22:19 EEST Fabrizio Castro wrote:
> > Add device tree bindings for r8a7743 and r8a7745 DUs.
> > r8a7743 DU is similar to the one from r8a7791, r8a7745 DU is similar
> > to the one from r8a7794.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> >  .../devicetree/bindings/display/renesas,du.txt     | 30 ++++++++++---------
> >  1 file changed, 17 insertions(+), 13 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> > b/Documentation/devicetree/bindings/display/renesas,du.txt index
> > 4bbd1e9..c520226 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> > @@ -3,6 +3,8 @@
> >  Required Properties:
> >
> >    - compatible: must be one of the following.
> > +    - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> > +    - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> >      - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> >      - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> >      - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> > @@ -27,10 +29,10 @@ Required Properties:
> >    - clock-names: Name of the clocks. This property is model-dependent.
> >      - R8A7779 uses a single functional clock. The clock doesn't need to be
> >        named.
> > -    - R8A779[0123456] use one functional clock per channel and one clock
> > per
> > -      LVDS encoder (if available). The functional clocks must be named
> > "du.x"
> > -      with "x" being the channel numerical index. The LVDS clocks must be
> > -      named "lvds.x" with "x" being the LVDS encoder numerical index.
> > +    - R8A779[0123456] and R8A774[35] use one functional clock per channel
>
> How about "All other DU instances use one functional clock..." ? I expect more
> entries to the added in the future, it would be nice not to have to modify
> this paragraph.

I agree.

>
> > and
> > +      one clock per LVDS encoder (if available). The functional clocks must
> > be
> > +      named "du.x" with "x" being the channel numerical index. The LVDS
> > clocks
> > +      must be named "lvds.x" with "x" being the LVDS encoder numerical
> > index.
> > - In addition to the functional and encoder clocks, all DU versions also
> > support externally supplied pixel clocks. Those clocks are optional. When
> > supplied they must be named "dclkin.x" with "x" being the input
> > @@ -49,16 +51,18 @@ bindings specified
> > in Documentation/devicetree/bindings/graph.txt. The following table lists
> > for each supported model the port number corresponding to each DU output.
> >
> > -Port 0Port1Port2Port3
> > +                      Port0          Port1          Port2          Port3
> >  ---------------------------------------------------------------------------
> > -- - R8A7779 (H1)DPAD 0DPAD 1--
> > - R8A7790 (H2)DPADLVDS 0LVDS 1-
> > - R8A7791 (M2-W)DPADLVDS 0--
> > - R8A7792 (V2H)DPAD 0DPAD 1--
> > - R8A7793 (M2-N)DPADLVDS 0--
> > - R8A7794 (E2)DPAD 0DPAD 1--
> > - R8A7795 (H3)DPADHDMI 0HDMI 1LVDS
> > - R8A7796 (M3-W)DPADHDMILVDS-
> > + R8A7743 (RZ/G1M)     DPAD 0         LVDS 0         -              -
>
> When there's a single DPAD the table mentions "DPAD" instead of "DPAD 0".
> There's no specific reason for that other than a historical one, but to keep
> entries consistent I would either keep doing so, or rename DPAD to DPAD 0 in
> all existing entries. What would you prefer ?

My personal preference is to number all of the entries (not just DPAD ones).

>
> If you're fine with these changes there's no need to submit a new version, I
> can fix when applying the patch to my tree.

Thank you Laurent!

Best regards,
Fab

>
> > + R8A7745 (RZ/G1E)     DPAD 0         DPAD 1         -              -
> > + R8A7779 (R-Car H1)   DPAD 0         DPAD 1         -              -
> > + R8A7790 (R-Car H2)   DPAD           LVDS 0         LVDS 1         -
> > + R8A7791 (R-Car M2-W) DPAD           LVDS 0         -              -
> > + R8A7792 (R-Car V2H)  DPAD 0         DPAD 1         -              -
> > + R8A7793 (R-Car M2-N) DPAD           LVDS 0         -              -
> > + R8A7794 (R-Car E2)   DPAD 0         DPAD 1         -              -
> > + R8A7795 (R-Car H3)   DPAD           HDMI 0         HDMI 1         LVDS
> > + R8A7796 (R-Car M3-W) DPAD           HDMI           LVDS           -
> >
> >
> >  Example: R8A7795 (R-Car H3) ES2.0 DU
>
>
> --
> Regards,
>
> Laurent Pinchart




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 1/4] dt-bindings: display: rcar-du: Document R8A774[35] DU

[Fabrizio Castro]

Hello Laurent,

thank you for getting back to me.

>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 13 October 2017 18:22:19 EEST Fabrizio Castro wrote:
> > Add device tree bindings for r8a7743 and r8a7745 DUs.
> > r8a7743 DU is similar to the one from r8a7791, r8a7745 DU is similar
> > to the one from r8a7794.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> >  .../devicetree/bindings/display/renesas,du.txt     | 30 ++++++++++----=
-----
> >  1 file changed, 17 insertions(+), 13 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> > b/Documentation/devicetree/bindings/display/renesas,du.txt index
> > 4bbd1e9..c520226 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> > @@ -3,6 +3,8 @@
> >  Required Properties:
> >
> >    - compatible: must be one of the following.
> > +    - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> > +    - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> >      - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> >      - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> >      - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> > @@ -27,10 +29,10 @@ Required Properties:
> >    - clock-names: Name of the clocks. This property is model-dependent.
> >      - R8A7779 uses a single functional clock. The clock doesn't need t=
o be
> >        named.
> > -    - R8A779[0123456] use one functional clock per channel and one clo=
ck
> > per
> > -      LVDS encoder (if available). The functional clocks must be named
> > "du.x"
> > -      with "x" being the channel numerical index. The LVDS clocks must=
 be
> > -      named "lvds.x" with "x" being the LVDS encoder numerical index.
> > +    - R8A779[0123456] and R8A774[35] use one functional clock per chan=
nel
>
> How about "All other DU instances use one functional clock..." ? I expect=
 more
> entries to the added in the future, it would be nice not to have to modif=
y
> this paragraph.

I agree.

>
> > and
> > +      one clock per LVDS encoder (if available). The functional clocks=
 must
> > be
> > +      named "du.x" with "x" being the channel numerical index. The LVD=
S
> > clocks
> > +      must be named "lvds.x" with "x" being the LVDS encoder numerical
> > index.
> > - In addition to the functional and encoder clocks, all DU versions als=
o
> > support externally supplied pixel clocks. Those clocks are optional. Wh=
en
> > supplied they must be named "dclkin.x" with "x" being the input
> > @@ -49,16 +51,18 @@ bindings specified
> > in Documentation/devicetree/bindings/graph.txt. The following table lis=
ts
> > for each supported model the port number corresponding to each DU outpu=
t.
> >
> > -Port 0Port1Port2Port3
> > +                      Port0          Port1          Port2          Por=
t3
> >  ----------------------------------------------------------------------=
-----
> > -- - R8A7779 (H1)DPAD 0DPAD 1--
> > - R8A7790 (H2)DPADLVDS 0LVDS 1-
> > - R8A7791 (M2-W)DPADLVDS 0--
> > - R8A7792 (V2H)DPAD 0DPAD 1--
> > - R8A7793 (M2-N)DPADLVDS 0--
> > - R8A7794 (E2)DPAD 0DPAD 1--
> > - R8A7795 (H3)DPADHDMI 0HDMI 1LVDS
> > - R8A7796 (M3-W)DPADHDMILVDS-
> > + R8A7743 (RZ/G1M)     DPAD 0         LVDS 0         -              -
>
> When there's a single DPAD the table mentions "DPAD" instead of "DPAD 0".
> There's no specific reason for that other than a historical one, but to k=
eep
> entries consistent I would either keep doing so, or rename DPAD to DPAD 0=
 in
> all existing entries. What would you prefer ?

My personal preference is to number all of the entries (not just DPAD ones)=
.

>
> If you're fine with these changes there's no need to submit a new version=
, I
> can fix when applying the patch to my tree.

Thank you Laurent!

Best regards,
Fab

>
> > + R8A7745 (RZ/G1E)     DPAD 0         DPAD 1         -              -
> > + R8A7779 (R-Car H1)   DPAD 0         DPAD 1         -              -
> > + R8A7790 (R-Car H2)   DPAD           LVDS 0         LVDS 1         -
> > + R8A7791 (R-Car M2-W) DPAD           LVDS 0         -              -
> > + R8A7792 (R-Car V2H)  DPAD 0         DPAD 1         -              -
> > + R8A7793 (R-Car M2-N) DPAD           LVDS 0         -              -
> > + R8A7794 (R-Car E2)   DPAD 0         DPAD 1         -              -
> > + R8A7795 (R-Car H3)   DPAD           HDMI 0         HDMI 1         LVD=
S
> > + R8A7796 (R-Car M3-W) DPAD           HDMI           LVDS           -
> >
> >
> >  Example: R8A7795 (R-Car H3) ES2.0 DU
>
>
> --
> Regards,
>
> Laurent Pinchart




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, B=
uckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered=
 No. 04586709.