All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dennis Wassenberg <dennis.wassenberg@secunet.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org, linux-sound@vger.kernel.org,
	alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	lukas@wunner.de,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Andrew Duggan <aduggan@synaptics.com>,
	perex@perex.cz, vinod.koul@intel.com, hui.wang@canonical.com,
	rafael.j.wysocki@intel.com
Subject: Re: [PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control
Date: Mon, 19 Dec 2016 11:44:18 +0100	[thread overview]
Message-ID: <43171dc4-95e4-4a2b-eebc-0795988eb6f2@secunet.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1612191054270.19203@cbobk.fhfr.pm>

Hi Jiri,

"led_set_func_hid_lenovo" is set to "hid_lenovo_led_set"

+#if IS_ENABLED(CONFIG_HID_LENOVO)
+static int hda_fixup_thinkpad_hid_prepare(struct hda_codec *codec)
+{
+	struct hda_gen_spec *spec = codec->spec;
+	int ret = 0;
+
+	if (!is_thinkpad(codec))
+		return -ENODEV;
+	if (!led_set_func_hid_lenovo)
+		led_set_func_hid_lenovo = symbol_request(hid_lenovo_led_set);

"hid_lenovo_led_set" is introduced in "[PATCH v2 2/2] hda: thinkpad_helper: Add support for hid-lenovo LED control". This means that "[PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control" can only work with applied "[PATCH 1/4] hid-lenovo: Add support for X1 Tablet cover special keys" and "[PATCH v2 2/2] hda: thinkpad_helper: Add support for hid-lenovo LED control".

Best regards,

Dennis
On 19.12.2016 11:09, Jiri Kosina wrote:
> On Fri, 9 Dec 2016, Dennis Wassenberg wrote:
> 
>> +#if IS_ENABLED(CONFIG_THINKPAD_ACPI)
>> +	if (led_set_func_tpacpi)
>> +		led_set_func_tpacpi(TPACPI_LED_MUTE, !enabled);
>> +#endif
>> +#if IS_ENABLED(CONFIG_HID_LENOVO)
>> +	if (led_set_func_hid_lenovo)
>> +		led_set_func_hid_lenovo(HID_LENOVO_LED_MUTE, !enabled);
> 
> Where does led_set_func_hid_lenovo() come from? I don't see it in Linus' 
> tree as of today. Is that something else than tpacpi_led_set()?
> 
> Thanks,
> 

WARNING: multiple messages have this Message-ID (diff)
From: Dennis Wassenberg <dennis.wassenberg@secunet.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org, linux-sound@vger.kernel.org,
	alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	lukas@wunner.de,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Andrew Duggan <aduggan@synaptics.com>,
	perex@perex.cz, vinod.koul@intel.com, hui.wang@canonical.com,
	rafael.j.wysocki@intel.com
Subject: Re: [PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control
Date: Mon, 19 Dec 2016 10:44:18 +0000	[thread overview]
Message-ID: <43171dc4-95e4-4a2b-eebc-0795988eb6f2@secunet.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1612191054270.19203@cbobk.fhfr.pm>

Hi Jiri,

"led_set_func_hid_lenovo" is set to "hid_lenovo_led_set"

+#if IS_ENABLED(CONFIG_HID_LENOVO)
+static int hda_fixup_thinkpad_hid_prepare(struct hda_codec *codec)
+{
+	struct hda_gen_spec *spec = codec->spec;
+	int ret = 0;
+
+	if (!is_thinkpad(codec))
+		return -ENODEV;
+	if (!led_set_func_hid_lenovo)
+		led_set_func_hid_lenovo = symbol_request(hid_lenovo_led_set);

"hid_lenovo_led_set" is introduced in "[PATCH v2 2/2] hda: thinkpad_helper: Add support for hid-lenovo LED control". This means that "[PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control" can only work with applied "[PATCH 1/4] hid-lenovo: Add support for X1 Tablet cover special keys" and "[PATCH v2 2/2] hda: thinkpad_helper: Add support for hid-lenovo LED control".

Best regards,

Dennis
On 19.12.2016 11:09, Jiri Kosina wrote:
> On Fri, 9 Dec 2016, Dennis Wassenberg wrote:
> 
>> +#if IS_ENABLED(CONFIG_THINKPAD_ACPI)
>> +	if (led_set_func_tpacpi)
>> +		led_set_func_tpacpi(TPACPI_LED_MUTE, !enabled);
>> +#endif
>> +#if IS_ENABLED(CONFIG_HID_LENOVO)
>> +	if (led_set_func_hid_lenovo)
>> +		led_set_func_hid_lenovo(HID_LENOVO_LED_MUTE, !enabled);
> 
> Where does led_set_func_hid_lenovo() come from? I don't see it in Linus' 
> tree as of today. Is that something else than tpacpi_led_set()?
> 
> Thanks,
> 

  reply	other threads:[~2016-12-19 10:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09 15:06 [PATCH 4/4] hda: thinkpad_helper: Add support for hid-lenovo LED control Dennis Wassenberg
2016-12-09 15:06 ` Dennis Wassenberg
2016-12-19 10:09 ` Jiri Kosina
2016-12-19 10:09   ` Jiri Kosina
2016-12-19 10:44   ` Dennis Wassenberg [this message]
2016-12-19 10:44     ` Dennis Wassenberg
2016-12-19 10:53     ` Jiri Kosina
2016-12-19 10:53       ` Jiri Kosina
2016-12-19 11:05       ` Dennis Wassenberg
2016-12-19 11:05         ` Dennis Wassenberg
  -- strict thread matches above, loose matches on Subject: below --
2016-09-12 10:47 Dennis Wassenberg
2016-09-12 10:47 ` Dennis Wassenberg
2016-09-12 12:38 ` Takashi Iwai
2016-09-12 12:38   ` Takashi Iwai
2016-09-14  6:22   ` Dennis Wassenberg
2016-09-14  6:22     ` Dennis Wassenberg
2016-09-14  7:03     ` Takashi Iwai
2016-09-14  7:03       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43171dc4-95e4-4a2b-eebc-0795988eb6f2@secunet.com \
    --to=dennis.wassenberg@secunet.com \
    --cc=aduggan@synaptics.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hui.wang@canonical.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=perex@perex.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.