* [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
[not found] <cover.1618231618.git.alinesantanacordeiro@gmail.com>
@ 2021-04-12 12:57 ` Aline Santana Cordeiro
2021-04-12 13:40 ` Laurent Pinchart
2021-04-12 12:57 ` [Outreachy kernel][PATCH 2/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipe.c Aline Santana Cordeiro
` (2 subsequent siblings)
3 siblings, 1 reply; 18+ messages in thread
From: Aline Santana Cordeiro @ 2021-04-12 12:57 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Replace macro function by static inline function.
Issue suggested by Julia.
Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
---
Changes since v1:
- Insert file path in commit message
drivers/staging/media/omap4iss/iss.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index c89f268a..3bbc39e 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -27,22 +27,24 @@
#include "iss.h"
#include "iss_regs.h"
-#define ISS_PRINT_REGISTER(iss, name)\
- dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", \
- iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name))
+static inline iss_print_register(iss, name)
+{
+ dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
+ iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name));
+}
static void iss_print_status(struct iss_device *iss)
{
dev_dbg(iss->dev, "-------------ISS HL Register dump-------------\n");
- ISS_PRINT_REGISTER(iss, HL_REVISION);
- ISS_PRINT_REGISTER(iss, HL_SYSCONFIG);
- ISS_PRINT_REGISTER(iss, HL_IRQSTATUS(5));
- ISS_PRINT_REGISTER(iss, HL_IRQENABLE_SET(5));
- ISS_PRINT_REGISTER(iss, HL_IRQENABLE_CLR(5));
- ISS_PRINT_REGISTER(iss, CTRL);
- ISS_PRINT_REGISTER(iss, CLKCTRL);
- ISS_PRINT_REGISTER(iss, CLKSTAT);
+ iss_print_register(iss, HL_REVISION);
+ iss_print_register(iss, HL_SYSCONFIG);
+ iss_print_register(iss, HL_IRQSTATUS(5));
+ iss_print_register(iss, HL_IRQENABLE_SET(5));
+ iss_print_register(iss, HL_IRQENABLE_CLR(5));
+ iss_print_register(iss, CTRL);
+ iss_print_register(iss, CLKCTRL);
+ iss_print_register(iss, CLKSTAT);
dev_dbg(iss->dev, "-----------------------------------------------\n");
}
--
2.7.4
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
2021-04-12 12:57 ` [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c Aline Santana Cordeiro
@ 2021-04-12 13:40 ` Laurent Pinchart
2021-04-12 13:58 ` ascordeiro
0 siblings, 1 reply; 18+ messages in thread
From: Laurent Pinchart @ 2021-04-12 13:40 UTC (permalink / raw)
To: Aline Santana Cordeiro
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel, outreachy-kernel
Hi Aline,
While testing on a device isn't a requirement as you can't be expected
to have the necessary hardware, changes are expected to be at least
compile-tested before being submitted.
On Mon, Apr 12, 2021 at 09:57:09AM -0300, Aline Santana Cordeiro wrote:
> Replace macro function by static inline function.
> Issue suggested by Julia.
>
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
> ---
>
> Changes since v1:
> - Insert file path in commit message
>
> drivers/staging/media/omap4iss/iss.c | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index c89f268a..3bbc39e 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -27,22 +27,24 @@
> #include "iss.h"
> #include "iss_regs.h"
>
> -#define ISS_PRINT_REGISTER(iss, name)\
> - dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", \
> - iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name))
> +static inline iss_print_register(iss, name)
> +{
> + dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
> + iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name));
> +}
>
> static void iss_print_status(struct iss_device *iss)
> {
> dev_dbg(iss->dev, "-------------ISS HL Register dump-------------\n");
>
> - ISS_PRINT_REGISTER(iss, HL_REVISION);
> - ISS_PRINT_REGISTER(iss, HL_SYSCONFIG);
> - ISS_PRINT_REGISTER(iss, HL_IRQSTATUS(5));
> - ISS_PRINT_REGISTER(iss, HL_IRQENABLE_SET(5));
> - ISS_PRINT_REGISTER(iss, HL_IRQENABLE_CLR(5));
> - ISS_PRINT_REGISTER(iss, CTRL);
> - ISS_PRINT_REGISTER(iss, CLKCTRL);
> - ISS_PRINT_REGISTER(iss, CLKSTAT);
> + iss_print_register(iss, HL_REVISION);
> + iss_print_register(iss, HL_SYSCONFIG);
> + iss_print_register(iss, HL_IRQSTATUS(5));
> + iss_print_register(iss, HL_IRQENABLE_SET(5));
> + iss_print_register(iss, HL_IRQENABLE_CLR(5));
> + iss_print_register(iss, CTRL);
> + iss_print_register(iss, CLKCTRL);
> + iss_print_register(iss, CLKSTAT);
>
> dev_dbg(iss->dev, "-----------------------------------------------\n");
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
2021-04-12 13:40 ` Laurent Pinchart
@ 2021-04-12 13:58 ` ascordeiro
0 siblings, 0 replies; 18+ messages in thread
From: ascordeiro @ 2021-04-12 13:58 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel, outreachy-kernel
Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> While testing on a device isn't a requirement as you can't be
> expected
> to have the necessary hardware, changes are expected to be at least
> compile-tested before being submitted.
Hi Laurent,
I thought recompiling the kernel would be enough in this case.
I recompiled it in native Ubuntu 16.04 without errors.
Thank you for the feedback.
Aline
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
@ 2021-04-12 13:58 ` ascordeiro
0 siblings, 0 replies; 18+ messages in thread
From: ascordeiro @ 2021-04-12 13:58 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel, outreachy-kernel
Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> While testing on a device isn't a requirement as you can't be
> expected
> to have the necessary hardware, changes are expected to be at least
> compile-tested before being submitted.
Hi Laurent,
I thought recompiling the kernel would be enough in this case.
I recompiled it in native Ubuntu 16.04 without errors.
Thank you for the feedback.
Aline
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
2021-04-12 13:58 ` ascordeiro
(?)
@ 2021-04-12 15:11 ` Laurent Pinchart
2021-04-12 17:29 ` ascordeiro
-1 siblings, 1 reply; 18+ messages in thread
From: Laurent Pinchart @ 2021-04-12 15:11 UTC (permalink / raw)
To: ascordeiro
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel, outreachy-kernel
Hi Aline,
On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote:
> Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> > While testing on a device isn't a requirement as you can't be expected
> > to have the necessary hardware, changes are expected to be at least
> > compile-tested before being submitted.
>
> Hi Laurent,
>
> I thought recompiling the kernel would be enough in this case.
> I recompiled it in native Ubuntu 16.04 without errors.
Did it compile the driver you modified ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
2021-04-12 15:11 ` Laurent Pinchart
@ 2021-04-12 17:29 ` ascordeiro
0 siblings, 0 replies; 18+ messages in thread
From: ascordeiro @ 2021-04-12 17:29 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel, outreachy-kernel
Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu:
> Hi Aline,
>
> On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote:
> > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> > > While testing on a device isn't a requirement as you can't be
> > > expected
> > > to have the necessary hardware, changes are expected to be at
> > > least
> > > compile-tested before being submitted.
> >
> > Hi Laurent,
> >
> > I thought recompiling the kernel would be enough in this case.
> > I recompiled it in native Ubuntu 16.04 without errors.
>
> Did it compile the driver you modified ?
>
I'm sorry, It didn't. I forgot to enable the option to compile the
driver as a module in "make menuconfig" and now I'm seeing the problems
I generated.
Thank you for warning me,
Aline
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
@ 2021-04-12 17:29 ` ascordeiro
0 siblings, 0 replies; 18+ messages in thread
From: ascordeiro @ 2021-04-12 17:29 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel, outreachy-kernel
Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu:
> Hi Aline,
>
> On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote:
> > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> > > While testing on a device isn't a requirement as you can't be
> > > expected
> > > to have the necessary hardware, changes are expected to be at
> > > least
> > > compile-tested before being submitted.
> >
> > Hi Laurent,
> >
> > I thought recompiling the kernel would be enough in this case.
> > I recompiled it in native Ubuntu 16.04 without errors.
>
> Did it compile the driver you modified ?
>
I'm sorry, It didn't. I forgot to enable the option to compile the
driver as a module in "make menuconfig" and now I'm seeing the problems
I generated.
Thank you for warning me,
Aline
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
2021-04-12 17:29 ` ascordeiro
@ 2021-04-12 17:36 ` Julia Lawall
-1 siblings, 0 replies; 18+ messages in thread
From: Julia Lawall @ 2021-04-12 17:36 UTC (permalink / raw)
To: ascordeiro
Cc: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, linux-staging, linux-kernel, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
On Mon, 12 Apr 2021, ascordeiro wrote:
> Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu:
> > Hi Aline,
> >
> > On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote:
> > > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> > > > While testing on a device isn't a requirement as you can't be
> > > > expected
> > > > to have the necessary hardware, changes are expected to be at
> > > > least
> > > > compile-tested before being submitted.
> > >
> > > Hi Laurent,
> > >
> > > I thought recompiling the kernel would be enough in this case.
> > > I recompiled it in native Ubuntu 16.04 without errors.
> >
> > Did it compile the driver you modified ?
> >
> I'm sorry, It didn't. I forgot to enable the option to compile the
> driver as a module in "make menuconfig" and now I'm seeing the problems
> I generated.
You can easily compile a single file using make path/foo.o and a single
directory using make path/.
julia
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
@ 2021-04-12 17:36 ` Julia Lawall
0 siblings, 0 replies; 18+ messages in thread
From: Julia Lawall @ 2021-04-12 17:36 UTC (permalink / raw)
To: ascordeiro
Cc: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, linux-staging, linux-kernel, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
On Mon, 12 Apr 2021, ascordeiro wrote:
> Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu:
> > Hi Aline,
> >
> > On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote:
> > > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> > > > While testing on a device isn't a requirement as you can't be
> > > > expected
> > > > to have the necessary hardware, changes are expected to be at
> > > > least
> > > > compile-tested before being submitted.
> > >
> > > Hi Laurent,
> > >
> > > I thought recompiling the kernel would be enough in this case.
> > > I recompiled it in native Ubuntu 16.04 without errors.
> >
> > Did it compile the driver you modified ?
> >
> I'm sorry, It didn't. I forgot to enable the option to compile the
> driver as a module in "make menuconfig" and now I'm seeing the problems
> I generated.
You can easily compile a single file using make path/foo.o and a single
directory using make path/.
julia
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
2021-04-12 17:36 ` Julia Lawall
@ 2021-04-12 17:39 ` ascordeiro
-1 siblings, 0 replies; 18+ messages in thread
From: ascordeiro @ 2021-04-12 17:39 UTC (permalink / raw)
To: Julia Lawall
Cc: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, linux-staging, linux-kernel, outreachy-kernel
Em seg, 2021-04-12 às 19:36 +0200, Julia Lawall escreveu:
>
>
> On Mon, 12 Apr 2021, ascordeiro wrote:
>
> > Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu:
> > > Hi Aline,
> > >
> > > On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote:
> > > > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> > > > > While testing on a device isn't a requirement as you can't be
> > > > > expected
> > > > > to have the necessary hardware, changes are expected to be at
> > > > > least
> > > > > compile-tested before being submitted.
> > > >
> > > > Hi Laurent,
> > > >
> > > > I thought recompiling the kernel would be enough in this case.
> > > > I recompiled it in native Ubuntu 16.04 without errors.
> > >
> > > Did it compile the driver you modified ?
> > >
> > I'm sorry, It didn't. I forgot to enable the option to compile the
> > driver as a module in "make menuconfig" and now I'm seeing the
> > problems
> > I generated.
>
> You can easily compile a single file using make path/foo.o and a
> single
> directory using make path/.
>
> julia
Ok! I'll do that from now on.
Thank you for the help,
Aline
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c
@ 2021-04-12 17:39 ` ascordeiro
0 siblings, 0 replies; 18+ messages in thread
From: ascordeiro @ 2021-04-12 17:39 UTC (permalink / raw)
To: Julia Lawall
Cc: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, linux-staging, linux-kernel, outreachy-kernel
Em seg, 2021-04-12 às 19:36 +0200, Julia Lawall escreveu:
>
>
> On Mon, 12 Apr 2021, ascordeiro wrote:
>
> > Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu:
> > > Hi Aline,
> > >
> > > On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote:
> > > > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu:
> > > > > While testing on a device isn't a requirement as you can't be
> > > > > expected
> > > > > to have the necessary hardware, changes are expected to be at
> > > > > least
> > > > > compile-tested before being submitted.
> > > >
> > > > Hi Laurent,
> > > >
> > > > I thought recompiling the kernel would be enough in this case.
> > > > I recompiled it in native Ubuntu 16.04 without errors.
> > >
> > > Did it compile the driver you modified ?
> > >
> > I'm sorry, It didn't. I forgot to enable the option to compile the
> > driver as a module in "make menuconfig" and now I'm seeing the
> > problems
> > I generated.
>
> You can easily compile a single file using make path/foo.o and a
> single
> directory using make path/.
>
> julia
Ok! I'll do that from now on.
Thank you for the help,
Aline
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Outreachy kernel][PATCH 2/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipe.c
[not found] <cover.1618231618.git.alinesantanacordeiro@gmail.com>
2021-04-12 12:57 ` [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c Aline Santana Cordeiro
@ 2021-04-12 12:57 ` Aline Santana Cordeiro
2021-04-12 12:57 ` [Outreachy kernel][PATCH 3/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipeif.c Aline Santana Cordeiro
2021-04-12 12:57 ` [Outreachy kernel][PATCH 4/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_resizer.c Aline Santana Cordeiro
3 siblings, 0 replies; 18+ messages in thread
From: Aline Santana Cordeiro @ 2021-04-12 12:57 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Replace macro function by static inline function.
Issue suggested by Julia.
Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
---
Changes since v1:
- Insert file path in commit message
drivers/staging/media/omap4iss/iss_ipipe.c | 28 +++++++++++++++-------------
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss_ipipe.c b/drivers/staging/media/omap4iss/iss_ipipe.c
index 26be078..09c941c 100644
--- a/drivers/staging/media/omap4iss/iss_ipipe.c
+++ b/drivers/staging/media/omap4iss/iss_ipipe.c
@@ -38,9 +38,11 @@ static const unsigned int ipipe_fmts[] = {
*
* Also prints other debug information stored in the IPIPE module.
*/
-#define IPIPE_PRINT_REGISTER(iss, name)\
- dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n", \
- iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name))
+static inline ipipe_print_register(iss, name)
+{
+ dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
+ iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name));
+}
static void ipipe_print_status(struct iss_ipipe_device *ipipe)
{
@@ -48,16 +50,16 @@ static void ipipe_print_status(struct iss_ipipe_device *ipipe)
dev_dbg(iss->dev, "-------------IPIPE Register dump-------------\n");
- IPIPE_PRINT_REGISTER(iss, SRC_EN);
- IPIPE_PRINT_REGISTER(iss, SRC_MODE);
- IPIPE_PRINT_REGISTER(iss, SRC_FMT);
- IPIPE_PRINT_REGISTER(iss, SRC_COL);
- IPIPE_PRINT_REGISTER(iss, SRC_VPS);
- IPIPE_PRINT_REGISTER(iss, SRC_VSZ);
- IPIPE_PRINT_REGISTER(iss, SRC_HPS);
- IPIPE_PRINT_REGISTER(iss, SRC_HSZ);
- IPIPE_PRINT_REGISTER(iss, GCK_MMR);
- IPIPE_PRINT_REGISTER(iss, YUV_PHS);
+ ipipe_print_register(iss, SRC_EN);
+ ipipe_print_register(iss, SRC_MODE);
+ ipipe_print_register(iss, SRC_FMT);
+ ipipe_print_register(iss, SRC_COL);
+ ipipe_print_register(iss, SRC_VPS);
+ ipipe_print_register(iss, SRC_VSZ);
+ ipipe_print_register(iss, SRC_HPS);
+ ipipe_print_register(iss, SRC_HSZ);
+ ipipe_print_register(iss, GCK_MMR);
+ ipipe_print_register(iss, YUV_PHS);
dev_dbg(iss->dev, "-----------------------------------------------\n");
}
--
2.7.4
^ permalink raw reply related [flat|nested] 18+ messages in thread* [Outreachy kernel][PATCH 3/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipeif.c
[not found] <cover.1618231618.git.alinesantanacordeiro@gmail.com>
2021-04-12 12:57 ` [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c Aline Santana Cordeiro
2021-04-12 12:57 ` [Outreachy kernel][PATCH 2/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipe.c Aline Santana Cordeiro
@ 2021-04-12 12:57 ` Aline Santana Cordeiro
2021-04-13 0:16 ` kernel test robot
2021-04-12 12:57 ` [Outreachy kernel][PATCH 4/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_resizer.c Aline Santana Cordeiro
3 siblings, 1 reply; 18+ messages in thread
From: Aline Santana Cordeiro @ 2021-04-12 12:57 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Replace macro function by static inline function.
Issue suggested by Julia.
Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
---
Changes since v1:
- Insert file path in commit message
drivers/staging/media/omap4iss/iss_ipipeif.c | 62 +++++++++++++++-------------
1 file changed, 34 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss_ipipeif.c b/drivers/staging/media/omap4iss/iss_ipipeif.c
index c2978d0..3dc98f6 100644
--- a/drivers/staging/media/omap4iss/iss_ipipeif.c
+++ b/drivers/staging/media/omap4iss/iss_ipipeif.c
@@ -34,17 +34,23 @@ static const unsigned int ipipeif_fmts[] = {
*
* Also prints other debug information stored in the IPIPEIF module.
*/
-#define IPIPEIF_PRINT_REGISTER(iss, name)\
- dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n", \
- iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPEIF, IPIPEIF_##name))
+static inline ipipeif_print_register(iss, name)
+{
+ dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
+ iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPEIF, IPIPEIF_##name));
+}
-#define ISIF_PRINT_REGISTER(iss, name)\
- dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n", \
- iss_reg_read(iss, OMAP4_ISS_MEM_ISP_ISIF, ISIF_##name))
+static inline isif_print_register(iss, name)
+{
+ dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n",
+ iss_reg_read(iss, OMAP4_ISS_MEM_ISP_ISIF, ISIF_##name));
+}
-#define ISP5_PRINT_REGISTER(iss, name)\
- dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n", \
- iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_##name))
+static inline isp5_print_register(iss, name)
+{
+ dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n",
+ iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_##name));
+}
static void ipipeif_print_status(struct iss_ipipeif_device *ipipeif)
{
@@ -52,25 +58,25 @@ static void ipipeif_print_status(struct iss_ipipeif_device *ipipeif)
dev_dbg(iss->dev, "-------------IPIPEIF Register dump-------------\n");
- IPIPEIF_PRINT_REGISTER(iss, CFG1);
- IPIPEIF_PRINT_REGISTER(iss, CFG2);
-
- ISIF_PRINT_REGISTER(iss, SYNCEN);
- ISIF_PRINT_REGISTER(iss, CADU);
- ISIF_PRINT_REGISTER(iss, CADL);
- ISIF_PRINT_REGISTER(iss, MODESET);
- ISIF_PRINT_REGISTER(iss, CCOLP);
- ISIF_PRINT_REGISTER(iss, SPH);
- ISIF_PRINT_REGISTER(iss, LNH);
- ISIF_PRINT_REGISTER(iss, LNV);
- ISIF_PRINT_REGISTER(iss, VDINT(0));
- ISIF_PRINT_REGISTER(iss, HSIZE);
-
- ISP5_PRINT_REGISTER(iss, SYSCONFIG);
- ISP5_PRINT_REGISTER(iss, CTRL);
- ISP5_PRINT_REGISTER(iss, IRQSTATUS(0));
- ISP5_PRINT_REGISTER(iss, IRQENABLE_SET(0));
- ISP5_PRINT_REGISTER(iss, IRQENABLE_CLR(0));
+ ipipeif_print_register(iss, CFG1);
+ ipipeif_print_register(iss, CFG2);
+
+ isif_print_register(iss, SYNCEN);
+ isif_print_register(iss, CADU);
+ isif_print_register(iss, CADL);
+ isif_print_register(iss, MODESET);
+ isif_print_register(iss, CCOLP);
+ isif_print_register(iss, SPH);
+ isif_print_register(iss, LNH);
+ isif_print_register(iss, LNV);
+ isif_print_register(iss, VDINT(0));
+ isif_print_register(iss, HSIZE);
+
+ isp5_print_register(iss, SYSCONFIG);
+ isp5_print_register(iss, CTRL);
+ isp5_print_register(iss, IRQSTATUS(0));
+ isp5_print_register(iss, IRQENABLE_SET(0));
+ isp5_print_register(iss, IRQENABLE_CLR(0));
dev_dbg(iss->dev, "-----------------------------------------------\n");
}
--
2.7.4
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [Outreachy kernel][PATCH 3/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipeif.c
2021-04-12 12:57 ` [Outreachy kernel][PATCH 3/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipeif.c Aline Santana Cordeiro
@ 2021-04-13 0:16 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-04-13 0:16 UTC (permalink / raw)
To: Aline Santana Cordeiro, Laurent Pinchart, Mauro Carvalho Chehab,
Greg Kroah-Hartman
Cc: kbuild-all, clang-built-linux, linux-media, linux-staging,
linux-kernel, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 8308 bytes --]
Hi Aline,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f2f560e1bdc055a6a306e6b7823ba589794e6564
config: mips-randconfig-r013-20210412 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/227d208756f87cbe3c143fa2a3a8f91103c6858e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
git checkout 227d208756f87cbe3c143fa2a3a8f91103c6858e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/media/omap4iss/iss_ipipeif.c:39:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:34: error: expected ')'
dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_ipipeif.c:39:2: note: to match this '('
dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_ipipeif.c:45:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_ipipeif.c:45:31: error: expected ')'
dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_ipipeif.c:45:2: note: to match this '('
dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_ipipeif.c:51:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_ipipeif.c:51:31: error: expected ')'
dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_ipipeif.c:51:2: note: to match this '('
dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_ipipeif.c:61:30: error: use of undeclared identifier 'CFG1'
ipipeif_print_register(iss, CFG1);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:62:30: error: use of undeclared identifier 'CFG2'
ipipeif_print_register(iss, CFG2);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:64:27: error: use of undeclared identifier 'SYNCEN'
isif_print_register(iss, SYNCEN);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:65:27: error: use of undeclared identifier 'CADU'
isif_print_register(iss, CADU);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:66:27: error: use of undeclared identifier 'CADL'
isif_print_register(iss, CADL);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:67:27: error: use of undeclared identifier 'MODESET'
isif_print_register(iss, MODESET);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:68:27: error: use of undeclared identifier 'CCOLP'
isif_print_register(iss, CCOLP);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:69:27: error: use of undeclared identifier 'SPH'
isif_print_register(iss, SPH);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:70:27: error: use of undeclared identifier 'LNH'
isif_print_register(iss, LNH);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:71:27: error: use of undeclared identifier 'LNV'
isif_print_register(iss, LNV);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:72:27: error: implicit declaration of function 'VDINT' [-Werror,-Wimplicit-function-declaration]
isif_print_register(iss, VDINT(0));
^
drivers/staging/media/omap4iss/iss_ipipeif.c:72:22: warning: incompatible pointer to integer conversion passing 'struct iss_device *' to parameter of type 'int' [-Wint-conversion]
isif_print_register(iss, VDINT(0));
^~~
drivers/staging/media/omap4iss/iss_ipipeif.c:73:27: error: use of undeclared identifier 'HSIZE'
isif_print_register(iss, HSIZE);
^
>> drivers/staging/media/omap4iss/iss_ipipeif.c:75:27: error: use of undeclared identifier 'SYSCONFIG'
isp5_print_register(iss, SYSCONFIG);
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 20 errors generated.
vim +/SYSCONFIG +75 drivers/staging/media/omap4iss/iss_ipipeif.c
54
55 static void ipipeif_print_status(struct iss_ipipeif_device *ipipeif)
56 {
57 struct iss_device *iss = to_iss_device(ipipeif);
58
59 dev_dbg(iss->dev, "-------------IPIPEIF Register dump-------------\n");
60
61 ipipeif_print_register(iss, CFG1);
62 ipipeif_print_register(iss, CFG2);
63
64 isif_print_register(iss, SYNCEN);
65 isif_print_register(iss, CADU);
66 isif_print_register(iss, CADL);
67 isif_print_register(iss, MODESET);
68 isif_print_register(iss, CCOLP);
69 isif_print_register(iss, SPH);
70 isif_print_register(iss, LNH);
71 isif_print_register(iss, LNV);
72 isif_print_register(iss, VDINT(0));
73 isif_print_register(iss, HSIZE);
74
> 75 isp5_print_register(iss, SYSCONFIG);
76 isp5_print_register(iss, CTRL);
77 isp5_print_register(iss, IRQSTATUS(0));
78 isp5_print_register(iss, IRQENABLE_SET(0));
79 isp5_print_register(iss, IRQENABLE_CLR(0));
80
81 dev_dbg(iss->dev, "-----------------------------------------------\n");
82 }
83
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37728 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [Outreachy kernel][PATCH 3/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipeif.c
@ 2021-04-13 0:16 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-04-13 0:16 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 8464 bytes --]
Hi Aline,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f2f560e1bdc055a6a306e6b7823ba589794e6564
config: mips-randconfig-r013-20210412 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/227d208756f87cbe3c143fa2a3a8f91103c6858e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
git checkout 227d208756f87cbe3c143fa2a3a8f91103c6858e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/media/omap4iss/iss_ipipeif.c:39:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:34: error: expected ')'
dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_ipipeif.c:39:2: note: to match this '('
dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_ipipeif.c:45:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_ipipeif.c:45:31: error: expected ')'
dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_ipipeif.c:45:2: note: to match this '('
dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_ipipeif.c:51:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_ipipeif.c:51:31: error: expected ')'
dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_ipipeif.c:51:2: note: to match this '('
dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_ipipeif.c:61:30: error: use of undeclared identifier 'CFG1'
ipipeif_print_register(iss, CFG1);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:62:30: error: use of undeclared identifier 'CFG2'
ipipeif_print_register(iss, CFG2);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:64:27: error: use of undeclared identifier 'SYNCEN'
isif_print_register(iss, SYNCEN);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:65:27: error: use of undeclared identifier 'CADU'
isif_print_register(iss, CADU);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:66:27: error: use of undeclared identifier 'CADL'
isif_print_register(iss, CADL);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:67:27: error: use of undeclared identifier 'MODESET'
isif_print_register(iss, MODESET);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:68:27: error: use of undeclared identifier 'CCOLP'
isif_print_register(iss, CCOLP);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:69:27: error: use of undeclared identifier 'SPH'
isif_print_register(iss, SPH);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:70:27: error: use of undeclared identifier 'LNH'
isif_print_register(iss, LNH);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:71:27: error: use of undeclared identifier 'LNV'
isif_print_register(iss, LNV);
^
drivers/staging/media/omap4iss/iss_ipipeif.c:72:27: error: implicit declaration of function 'VDINT' [-Werror,-Wimplicit-function-declaration]
isif_print_register(iss, VDINT(0));
^
drivers/staging/media/omap4iss/iss_ipipeif.c:72:22: warning: incompatible pointer to integer conversion passing 'struct iss_device *' to parameter of type 'int' [-Wint-conversion]
isif_print_register(iss, VDINT(0));
^~~
drivers/staging/media/omap4iss/iss_ipipeif.c:73:27: error: use of undeclared identifier 'HSIZE'
isif_print_register(iss, HSIZE);
^
>> drivers/staging/media/omap4iss/iss_ipipeif.c:75:27: error: use of undeclared identifier 'SYSCONFIG'
isp5_print_register(iss, SYSCONFIG);
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 20 errors generated.
vim +/SYSCONFIG +75 drivers/staging/media/omap4iss/iss_ipipeif.c
54
55 static void ipipeif_print_status(struct iss_ipipeif_device *ipipeif)
56 {
57 struct iss_device *iss = to_iss_device(ipipeif);
58
59 dev_dbg(iss->dev, "-------------IPIPEIF Register dump-------------\n");
60
61 ipipeif_print_register(iss, CFG1);
62 ipipeif_print_register(iss, CFG2);
63
64 isif_print_register(iss, SYNCEN);
65 isif_print_register(iss, CADU);
66 isif_print_register(iss, CADL);
67 isif_print_register(iss, MODESET);
68 isif_print_register(iss, CCOLP);
69 isif_print_register(iss, SPH);
70 isif_print_register(iss, LNH);
71 isif_print_register(iss, LNV);
72 isif_print_register(iss, VDINT(0));
73 isif_print_register(iss, HSIZE);
74
> 75 isp5_print_register(iss, SYSCONFIG);
76 isp5_print_register(iss, CTRL);
77 isp5_print_register(iss, IRQSTATUS(0));
78 isp5_print_register(iss, IRQENABLE_SET(0));
79 isp5_print_register(iss, IRQENABLE_CLR(0));
80
81 dev_dbg(iss->dev, "-----------------------------------------------\n");
82 }
83
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37728 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Outreachy kernel][PATCH 4/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_resizer.c
[not found] <cover.1618231618.git.alinesantanacordeiro@gmail.com>
` (2 preceding siblings ...)
2021-04-12 12:57 ` [Outreachy kernel][PATCH 3/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipeif.c Aline Santana Cordeiro
@ 2021-04-12 12:57 ` Aline Santana Cordeiro
2021-04-13 1:49 ` kernel test robot
3 siblings, 1 reply; 18+ messages in thread
From: Aline Santana Cordeiro @ 2021-04-12 12:57 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Replace macro function by static inline function.
Issue suggested by Julia.
Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
---
Changes since v1:
- Insert file path in commit message
- Remove trailing space left during modification
drivers/staging/media/omap4iss/iss_resizer.c | 126 ++++++++++++++-------------
1 file changed, 65 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss_resizer.c b/drivers/staging/media/omap4iss/iss_resizer.c
index 3b6875c..80ca44d 100644
--- a/drivers/staging/media/omap4iss/iss_resizer.c
+++ b/drivers/staging/media/omap4iss/iss_resizer.c
@@ -30,13 +30,17 @@ static const unsigned int resizer_fmts[] = {
*
* Also prints other debug information stored in the RESIZER module.
*/
-#define RSZ_PRINT_REGISTER(iss, name)\
- dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n", \
- iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RSZ_##name))
+static inline rsz_print_register(iss, name)
+{
+ dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
+ iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RSZ_##name));
+}
-#define RZA_PRINT_REGISTER(iss, name)\
- dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n", \
- iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RZA_##name))
+static inline rza_print_register(iss, name)
+{
+ dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
+ iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RZA_##name));
+}
static void resizer_print_status(struct iss_resizer_device *resizer)
{
@@ -44,61 +48,61 @@ static void resizer_print_status(struct iss_resizer_device *resizer)
dev_dbg(iss->dev, "-------------RESIZER Register dump-------------\n");
- RSZ_PRINT_REGISTER(iss, SYSCONFIG);
- RSZ_PRINT_REGISTER(iss, IN_FIFO_CTRL);
- RSZ_PRINT_REGISTER(iss, FRACDIV);
- RSZ_PRINT_REGISTER(iss, SRC_EN);
- RSZ_PRINT_REGISTER(iss, SRC_MODE);
- RSZ_PRINT_REGISTER(iss, SRC_FMT0);
- RSZ_PRINT_REGISTER(iss, SRC_FMT1);
- RSZ_PRINT_REGISTER(iss, SRC_VPS);
- RSZ_PRINT_REGISTER(iss, SRC_VSZ);
- RSZ_PRINT_REGISTER(iss, SRC_HPS);
- RSZ_PRINT_REGISTER(iss, SRC_HSZ);
- RSZ_PRINT_REGISTER(iss, DMA_RZA);
- RSZ_PRINT_REGISTER(iss, DMA_RZB);
- RSZ_PRINT_REGISTER(iss, DMA_STA);
- RSZ_PRINT_REGISTER(iss, GCK_MMR);
- RSZ_PRINT_REGISTER(iss, GCK_SDR);
- RSZ_PRINT_REGISTER(iss, IRQ_RZA);
- RSZ_PRINT_REGISTER(iss, IRQ_RZB);
- RSZ_PRINT_REGISTER(iss, YUV_Y_MIN);
- RSZ_PRINT_REGISTER(iss, YUV_Y_MAX);
- RSZ_PRINT_REGISTER(iss, YUV_C_MIN);
- RSZ_PRINT_REGISTER(iss, YUV_C_MAX);
- RSZ_PRINT_REGISTER(iss, SEQ);
-
- RZA_PRINT_REGISTER(iss, EN);
- RZA_PRINT_REGISTER(iss, MODE);
- RZA_PRINT_REGISTER(iss, 420);
- RZA_PRINT_REGISTER(iss, I_VPS);
- RZA_PRINT_REGISTER(iss, I_HPS);
- RZA_PRINT_REGISTER(iss, O_VSZ);
- RZA_PRINT_REGISTER(iss, O_HSZ);
- RZA_PRINT_REGISTER(iss, V_PHS_Y);
- RZA_PRINT_REGISTER(iss, V_PHS_C);
- RZA_PRINT_REGISTER(iss, V_DIF);
- RZA_PRINT_REGISTER(iss, V_TYP);
- RZA_PRINT_REGISTER(iss, V_LPF);
- RZA_PRINT_REGISTER(iss, H_PHS);
- RZA_PRINT_REGISTER(iss, H_DIF);
- RZA_PRINT_REGISTER(iss, H_TYP);
- RZA_PRINT_REGISTER(iss, H_LPF);
- RZA_PRINT_REGISTER(iss, DWN_EN);
- RZA_PRINT_REGISTER(iss, SDR_Y_BAD_H);
- RZA_PRINT_REGISTER(iss, SDR_Y_BAD_L);
- RZA_PRINT_REGISTER(iss, SDR_Y_SAD_H);
- RZA_PRINT_REGISTER(iss, SDR_Y_SAD_L);
- RZA_PRINT_REGISTER(iss, SDR_Y_OFT);
- RZA_PRINT_REGISTER(iss, SDR_Y_PTR_S);
- RZA_PRINT_REGISTER(iss, SDR_Y_PTR_E);
- RZA_PRINT_REGISTER(iss, SDR_C_BAD_H);
- RZA_PRINT_REGISTER(iss, SDR_C_BAD_L);
- RZA_PRINT_REGISTER(iss, SDR_C_SAD_H);
- RZA_PRINT_REGISTER(iss, SDR_C_SAD_L);
- RZA_PRINT_REGISTER(iss, SDR_C_OFT);
- RZA_PRINT_REGISTER(iss, SDR_C_PTR_S);
- RZA_PRINT_REGISTER(iss, SDR_C_PTR_E);
+ rsz_print_register(iss, SYSCONFIG);
+ rsz_print_register(iss, IN_FIFO_CTRL);
+ rsz_print_register(iss, FRACDIV);
+ rsz_print_register(iss, SRC_EN);
+ rsz_print_register(iss, SRC_MODE);
+ rsz_print_register(iss, SRC_FMT0);
+ rsz_print_register(iss, SRC_FMT1);
+ rsz_print_register(iss, SRC_VPS);
+ rsz_print_register(iss, SRC_VSZ);
+ rsz_print_register(iss, SRC_HPS);
+ rsz_print_register(iss, SRC_HSZ);
+ rsz_print_register(iss, DMA_RZA);
+ rsz_print_register(iss, DMA_RZB);
+ rsz_print_register(iss, DMA_STA);
+ rsz_print_register(iss, GCK_MMR);
+ rsz_print_register(iss, GCK_SDR);
+ rsz_print_register(iss, IRQ_RZA);
+ rsz_print_register(iss, IRQ_RZB);
+ rsz_print_register(iss, YUV_Y_MIN);
+ rsz_print_register(iss, YUV_Y_MAX);
+ rsz_print_register(iss, YUV_C_MIN);
+ rsz_print_register(iss, YUV_C_MAX);
+ rsz_print_register(iss, SEQ);
+
+ rza_print_register(iss, EN);
+ rza_print_register(iss, MODE);
+ rza_print_register(iss, 420);
+ rza_print_register(iss, I_VPS);
+ rza_print_register(iss, I_HPS);
+ rza_print_register(iss, O_VSZ);
+ rza_print_register(iss, O_HSZ);
+ rza_print_register(iss, V_PHS_Y);
+ rza_print_register(iss, V_PHS_C);
+ rza_print_register(iss, V_DIF);
+ rza_print_register(iss, V_TYP);
+ rza_print_register(iss, V_LPF);
+ rza_print_register(iss, H_PHS);
+ rza_print_register(iss, H_DIF);
+ rza_print_register(iss, H_TYP);
+ rza_print_register(iss, H_LPF);
+ rza_print_register(iss, DWN_EN);
+ rza_print_register(iss, SDR_Y_BAD_H);
+ rza_print_register(iss, SDR_Y_BAD_L);
+ rza_print_register(iss, SDR_Y_SAD_H);
+ rza_print_register(iss, SDR_Y_SAD_L);
+ rza_print_register(iss, SDR_Y_OFT);
+ rza_print_register(iss, SDR_Y_PTR_S);
+ rza_print_register(iss, SDR_Y_PTR_E);
+ rza_print_register(iss, SDR_C_BAD_H);
+ rza_print_register(iss, SDR_C_BAD_L);
+ rza_print_register(iss, SDR_C_SAD_H);
+ rza_print_register(iss, SDR_C_SAD_L);
+ rza_print_register(iss, SDR_C_OFT);
+ rza_print_register(iss, SDR_C_PTR_S);
+ rza_print_register(iss, SDR_C_PTR_E);
dev_dbg(iss->dev, "-----------------------------------------------\n");
}
--
2.7.4
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [Outreachy kernel][PATCH 4/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_resizer.c
2021-04-12 12:57 ` [Outreachy kernel][PATCH 4/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_resizer.c Aline Santana Cordeiro
@ 2021-04-13 1:49 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-04-13 1:49 UTC (permalink / raw)
To: Aline Santana Cordeiro, Laurent Pinchart, Mauro Carvalho Chehab,
Greg Kroah-Hartman
Cc: kbuild-all, clang-built-linux, linux-media, linux-staging,
linux-kernel, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 9020 bytes --]
Hi Aline,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f2f560e1bdc055a6a306e6b7823ba589794e6564
config: mips-randconfig-r013-20210412 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/82d48fcd5db8ca859bb928988c9b85d32e1eadbd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
git checkout 82d48fcd5db8ca859bb928988c9b85d32e1eadbd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/media/omap4iss/iss_resizer.c:35:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_resizer.c:35:30: error: expected ')'
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_resizer.c:35:2: note: to match this '('
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_resizer.c:41:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_resizer.c:41:30: error: expected ')'
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_resizer.c:41:2: note: to match this '('
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_resizer.c:51:26: error: use of undeclared identifier 'SYSCONFIG'
rsz_print_register(iss, SYSCONFIG);
^
drivers/staging/media/omap4iss/iss_resizer.c:52:26: error: use of undeclared identifier 'IN_FIFO_CTRL'
rsz_print_register(iss, IN_FIFO_CTRL);
^
drivers/staging/media/omap4iss/iss_resizer.c:53:26: error: use of undeclared identifier 'FRACDIV'
rsz_print_register(iss, FRACDIV);
^
drivers/staging/media/omap4iss/iss_resizer.c:54:26: error: use of undeclared identifier 'SRC_EN'
rsz_print_register(iss, SRC_EN);
^
drivers/staging/media/omap4iss/iss_resizer.c:55:26: error: use of undeclared identifier 'SRC_MODE'
rsz_print_register(iss, SRC_MODE);
^
drivers/staging/media/omap4iss/iss_resizer.c:56:26: error: use of undeclared identifier 'SRC_FMT0'
rsz_print_register(iss, SRC_FMT0);
^
drivers/staging/media/omap4iss/iss_resizer.c:57:26: error: use of undeclared identifier 'SRC_FMT1'
rsz_print_register(iss, SRC_FMT1);
^
drivers/staging/media/omap4iss/iss_resizer.c:58:26: error: use of undeclared identifier 'SRC_VPS'
rsz_print_register(iss, SRC_VPS);
^
drivers/staging/media/omap4iss/iss_resizer.c:59:26: error: use of undeclared identifier 'SRC_VSZ'
rsz_print_register(iss, SRC_VSZ);
^
drivers/staging/media/omap4iss/iss_resizer.c:60:26: error: use of undeclared identifier 'SRC_HPS'
rsz_print_register(iss, SRC_HPS);
^
drivers/staging/media/omap4iss/iss_resizer.c:61:26: error: use of undeclared identifier 'SRC_HSZ'
rsz_print_register(iss, SRC_HSZ);
^
drivers/staging/media/omap4iss/iss_resizer.c:62:26: error: use of undeclared identifier 'DMA_RZA'
rsz_print_register(iss, DMA_RZA);
^
drivers/staging/media/omap4iss/iss_resizer.c:63:26: error: use of undeclared identifier 'DMA_RZB'
rsz_print_register(iss, DMA_RZB);
^
drivers/staging/media/omap4iss/iss_resizer.c:64:26: error: use of undeclared identifier 'DMA_STA'
rsz_print_register(iss, DMA_STA);
^
>> drivers/staging/media/omap4iss/iss_resizer.c:65:26: error: use of undeclared identifier 'GCK_MMR'
rsz_print_register(iss, GCK_MMR);
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
vim +/GCK_MMR +65 drivers/staging/media/omap4iss/iss_resizer.c
44
45 static void resizer_print_status(struct iss_resizer_device *resizer)
46 {
47 struct iss_device *iss = to_iss_device(resizer);
48
49 dev_dbg(iss->dev, "-------------RESIZER Register dump-------------\n");
50
51 rsz_print_register(iss, SYSCONFIG);
52 rsz_print_register(iss, IN_FIFO_CTRL);
53 rsz_print_register(iss, FRACDIV);
54 rsz_print_register(iss, SRC_EN);
55 rsz_print_register(iss, SRC_MODE);
56 rsz_print_register(iss, SRC_FMT0);
57 rsz_print_register(iss, SRC_FMT1);
58 rsz_print_register(iss, SRC_VPS);
59 rsz_print_register(iss, SRC_VSZ);
60 rsz_print_register(iss, SRC_HPS);
61 rsz_print_register(iss, SRC_HSZ);
> 62 rsz_print_register(iss, DMA_RZA);
63 rsz_print_register(iss, DMA_RZB);
64 rsz_print_register(iss, DMA_STA);
> 65 rsz_print_register(iss, GCK_MMR);
66 rsz_print_register(iss, GCK_SDR);
67 rsz_print_register(iss, IRQ_RZA);
68 rsz_print_register(iss, IRQ_RZB);
69 rsz_print_register(iss, YUV_Y_MIN);
70 rsz_print_register(iss, YUV_Y_MAX);
71 rsz_print_register(iss, YUV_C_MIN);
72 rsz_print_register(iss, YUV_C_MAX);
73 rsz_print_register(iss, SEQ);
74
75 rza_print_register(iss, EN);
76 rza_print_register(iss, MODE);
77 rza_print_register(iss, 420);
78 rza_print_register(iss, I_VPS);
79 rza_print_register(iss, I_HPS);
80 rza_print_register(iss, O_VSZ);
81 rza_print_register(iss, O_HSZ);
82 rza_print_register(iss, V_PHS_Y);
83 rza_print_register(iss, V_PHS_C);
84 rza_print_register(iss, V_DIF);
85 rza_print_register(iss, V_TYP);
86 rza_print_register(iss, V_LPF);
87 rza_print_register(iss, H_PHS);
88 rza_print_register(iss, H_DIF);
89 rza_print_register(iss, H_TYP);
90 rza_print_register(iss, H_LPF);
91 rza_print_register(iss, DWN_EN);
92 rza_print_register(iss, SDR_Y_BAD_H);
93 rza_print_register(iss, SDR_Y_BAD_L);
94 rza_print_register(iss, SDR_Y_SAD_H);
95 rza_print_register(iss, SDR_Y_SAD_L);
96 rza_print_register(iss, SDR_Y_OFT);
97 rza_print_register(iss, SDR_Y_PTR_S);
98 rza_print_register(iss, SDR_Y_PTR_E);
99 rza_print_register(iss, SDR_C_BAD_H);
100 rza_print_register(iss, SDR_C_BAD_L);
101 rza_print_register(iss, SDR_C_SAD_H);
102 rza_print_register(iss, SDR_C_SAD_L);
103 rza_print_register(iss, SDR_C_OFT);
104 rza_print_register(iss, SDR_C_PTR_S);
105 rza_print_register(iss, SDR_C_PTR_E);
106
107 dev_dbg(iss->dev, "-----------------------------------------------\n");
108 }
109
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37728 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [Outreachy kernel][PATCH 4/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_resizer.c
@ 2021-04-13 1:49 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-04-13 1:49 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 9200 bytes --]
Hi Aline,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f2f560e1bdc055a6a306e6b7823ba589794e6564
config: mips-randconfig-r013-20210412 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/82d48fcd5db8ca859bb928988c9b85d32e1eadbd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aline-Santana-Cordeiro/staging-media-omap4iss-Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-215756
git checkout 82d48fcd5db8ca859bb928988c9b85d32e1eadbd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/media/omap4iss/iss_resizer.c:35:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_resizer.c:35:30: error: expected ')'
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_resizer.c:35:2: note: to match this '('
dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_resizer.c:41:15: error: member reference type 'int' is not a pointer
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
~~~ ^
include/linux/dev_printk.h:131:26: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^~~
drivers/staging/media/omap4iss/iss_resizer.c:41:30: error: expected ')'
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
^
drivers/staging/media/omap4iss/iss_resizer.c:41:2: note: to match this '('
dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n",
^
include/linux/dev_printk.h:131:13: note: expanded from macro 'dev_dbg'
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
^
drivers/staging/media/omap4iss/iss_resizer.c:51:26: error: use of undeclared identifier 'SYSCONFIG'
rsz_print_register(iss, SYSCONFIG);
^
drivers/staging/media/omap4iss/iss_resizer.c:52:26: error: use of undeclared identifier 'IN_FIFO_CTRL'
rsz_print_register(iss, IN_FIFO_CTRL);
^
drivers/staging/media/omap4iss/iss_resizer.c:53:26: error: use of undeclared identifier 'FRACDIV'
rsz_print_register(iss, FRACDIV);
^
drivers/staging/media/omap4iss/iss_resizer.c:54:26: error: use of undeclared identifier 'SRC_EN'
rsz_print_register(iss, SRC_EN);
^
drivers/staging/media/omap4iss/iss_resizer.c:55:26: error: use of undeclared identifier 'SRC_MODE'
rsz_print_register(iss, SRC_MODE);
^
drivers/staging/media/omap4iss/iss_resizer.c:56:26: error: use of undeclared identifier 'SRC_FMT0'
rsz_print_register(iss, SRC_FMT0);
^
drivers/staging/media/omap4iss/iss_resizer.c:57:26: error: use of undeclared identifier 'SRC_FMT1'
rsz_print_register(iss, SRC_FMT1);
^
drivers/staging/media/omap4iss/iss_resizer.c:58:26: error: use of undeclared identifier 'SRC_VPS'
rsz_print_register(iss, SRC_VPS);
^
drivers/staging/media/omap4iss/iss_resizer.c:59:26: error: use of undeclared identifier 'SRC_VSZ'
rsz_print_register(iss, SRC_VSZ);
^
drivers/staging/media/omap4iss/iss_resizer.c:60:26: error: use of undeclared identifier 'SRC_HPS'
rsz_print_register(iss, SRC_HPS);
^
drivers/staging/media/omap4iss/iss_resizer.c:61:26: error: use of undeclared identifier 'SRC_HSZ'
rsz_print_register(iss, SRC_HSZ);
^
drivers/staging/media/omap4iss/iss_resizer.c:62:26: error: use of undeclared identifier 'DMA_RZA'
rsz_print_register(iss, DMA_RZA);
^
drivers/staging/media/omap4iss/iss_resizer.c:63:26: error: use of undeclared identifier 'DMA_RZB'
rsz_print_register(iss, DMA_RZB);
^
drivers/staging/media/omap4iss/iss_resizer.c:64:26: error: use of undeclared identifier 'DMA_STA'
rsz_print_register(iss, DMA_STA);
^
>> drivers/staging/media/omap4iss/iss_resizer.c:65:26: error: use of undeclared identifier 'GCK_MMR'
rsz_print_register(iss, GCK_MMR);
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
vim +/GCK_MMR +65 drivers/staging/media/omap4iss/iss_resizer.c
44
45 static void resizer_print_status(struct iss_resizer_device *resizer)
46 {
47 struct iss_device *iss = to_iss_device(resizer);
48
49 dev_dbg(iss->dev, "-------------RESIZER Register dump-------------\n");
50
51 rsz_print_register(iss, SYSCONFIG);
52 rsz_print_register(iss, IN_FIFO_CTRL);
53 rsz_print_register(iss, FRACDIV);
54 rsz_print_register(iss, SRC_EN);
55 rsz_print_register(iss, SRC_MODE);
56 rsz_print_register(iss, SRC_FMT0);
57 rsz_print_register(iss, SRC_FMT1);
58 rsz_print_register(iss, SRC_VPS);
59 rsz_print_register(iss, SRC_VSZ);
60 rsz_print_register(iss, SRC_HPS);
61 rsz_print_register(iss, SRC_HSZ);
> 62 rsz_print_register(iss, DMA_RZA);
63 rsz_print_register(iss, DMA_RZB);
64 rsz_print_register(iss, DMA_STA);
> 65 rsz_print_register(iss, GCK_MMR);
66 rsz_print_register(iss, GCK_SDR);
67 rsz_print_register(iss, IRQ_RZA);
68 rsz_print_register(iss, IRQ_RZB);
69 rsz_print_register(iss, YUV_Y_MIN);
70 rsz_print_register(iss, YUV_Y_MAX);
71 rsz_print_register(iss, YUV_C_MIN);
72 rsz_print_register(iss, YUV_C_MAX);
73 rsz_print_register(iss, SEQ);
74
75 rza_print_register(iss, EN);
76 rza_print_register(iss, MODE);
77 rza_print_register(iss, 420);
78 rza_print_register(iss, I_VPS);
79 rza_print_register(iss, I_HPS);
80 rza_print_register(iss, O_VSZ);
81 rza_print_register(iss, O_HSZ);
82 rza_print_register(iss, V_PHS_Y);
83 rza_print_register(iss, V_PHS_C);
84 rza_print_register(iss, V_DIF);
85 rza_print_register(iss, V_TYP);
86 rza_print_register(iss, V_LPF);
87 rza_print_register(iss, H_PHS);
88 rza_print_register(iss, H_DIF);
89 rza_print_register(iss, H_TYP);
90 rza_print_register(iss, H_LPF);
91 rza_print_register(iss, DWN_EN);
92 rza_print_register(iss, SDR_Y_BAD_H);
93 rza_print_register(iss, SDR_Y_BAD_L);
94 rza_print_register(iss, SDR_Y_SAD_H);
95 rza_print_register(iss, SDR_Y_SAD_L);
96 rza_print_register(iss, SDR_Y_OFT);
97 rza_print_register(iss, SDR_Y_PTR_S);
98 rza_print_register(iss, SDR_Y_PTR_E);
99 rza_print_register(iss, SDR_C_BAD_H);
100 rza_print_register(iss, SDR_C_BAD_L);
101 rza_print_register(iss, SDR_C_SAD_H);
102 rza_print_register(iss, SDR_C_SAD_L);
103 rza_print_register(iss, SDR_C_OFT);
104 rza_print_register(iss, SDR_C_PTR_S);
105 rza_print_register(iss, SDR_C_PTR_E);
106
107 dev_dbg(iss->dev, "-----------------------------------------------\n");
108 }
109
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37728 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread