From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, virtualization@lists.linux-foundation.org Cc: Stefan Hajnoczi <stefanha@redhat.com>, Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org, Eli Cohen <elic@nvidia.com>, "Michael S. Tsirkin" <mst@redhat.com>, Max Gurtovoy <mgurtovoy@nvidia.com> Subject: Re: [PATCH RFC 09/12] vdpa_sim: make vdpasim->buffer size configurable Date: Mon, 16 Nov 2020 12:19:55 +0800 [thread overview] Message-ID: <433bbdf4-b69c-7ae8-a734-923ffac646eb@redhat.com> (raw) In-Reply-To: <20201113134712.69744-10-sgarzare@redhat.com> On 2020/11/13 下午9:47, Stefano Garzarella wrote: > Allow each device to specify the size of the buffer allocated > in vdpa_sim. > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 + > drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +- > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 1 + > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 1 + > 4 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.h b/drivers/vdpa/vdpa_sim/vdpa_sim.h > index f7e1fe0a88d3..cc21e07aa2f7 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.h > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.h > @@ -49,6 +49,7 @@ struct vdpasim_device { > > struct vdpasim_init_attr { > struct vdpasim_device device; > + size_t buffer_size; > int batch_mapping; > > work_func_t work_fn; > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index bd034fbf4683..3863d49e0d6d 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -223,7 +223,7 @@ struct vdpasim *vdpasim_create(struct vdpasim_init_attr *attr) > if (!vdpasim->iommu) > goto err_iommu; > > - vdpasim->buffer = kvmalloc(PAGE_SIZE, GFP_KERNEL); > + vdpasim->buffer = kvmalloc(attr->buffer_size, GFP_KERNEL); > if (!vdpasim->buffer) > goto err_iommu; > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c > index f456a0e4e097..122a3c039507 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c > @@ -100,6 +100,7 @@ static int __init vdpasim_blk_init(void) > attr.device.update_config = vdpasim_blk_update_config; > > attr.work_fn = vdpasim_blk_work; > + attr.buffer_size = PAGE_SIZE; > > vdpasim_blk_dev = vdpasim_create(&attr); > if (IS_ERR(vdpasim_blk_dev)) { > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > index b9372fdf2415..d0a1403f64b2 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > @@ -124,6 +124,7 @@ static int __init vdpasim_net_init(void) > > attr.work_fn = vdpasim_net_work; > attr.batch_mapping = batch_mapping; > + attr.buffer_size = PAGE_SIZE; > > vdpasim_net_dev = vdpasim_create(&attr); > if (IS_ERR(vdpasim_net_dev)) {
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com>, virtualization@lists.linux-foundation.org Cc: Laurent Vivier <lvivier@redhat.com>, Max Gurtovoy <mgurtovoy@nvidia.com>, "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org, Stefan Hajnoczi <stefanha@redhat.com>, Eli Cohen <elic@nvidia.com> Subject: Re: [PATCH RFC 09/12] vdpa_sim: make vdpasim->buffer size configurable Date: Mon, 16 Nov 2020 12:19:55 +0800 [thread overview] Message-ID: <433bbdf4-b69c-7ae8-a734-923ffac646eb@redhat.com> (raw) In-Reply-To: <20201113134712.69744-10-sgarzare@redhat.com> On 2020/11/13 下午9:47, Stefano Garzarella wrote: > Allow each device to specify the size of the buffer allocated > in vdpa_sim. > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 + > drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +- > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 1 + > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 1 + > 4 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.h b/drivers/vdpa/vdpa_sim/vdpa_sim.h > index f7e1fe0a88d3..cc21e07aa2f7 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.h > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.h > @@ -49,6 +49,7 @@ struct vdpasim_device { > > struct vdpasim_init_attr { > struct vdpasim_device device; > + size_t buffer_size; > int batch_mapping; > > work_func_t work_fn; > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index bd034fbf4683..3863d49e0d6d 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -223,7 +223,7 @@ struct vdpasim *vdpasim_create(struct vdpasim_init_attr *attr) > if (!vdpasim->iommu) > goto err_iommu; > > - vdpasim->buffer = kvmalloc(PAGE_SIZE, GFP_KERNEL); > + vdpasim->buffer = kvmalloc(attr->buffer_size, GFP_KERNEL); > if (!vdpasim->buffer) > goto err_iommu; > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c > index f456a0e4e097..122a3c039507 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c > @@ -100,6 +100,7 @@ static int __init vdpasim_blk_init(void) > attr.device.update_config = vdpasim_blk_update_config; > > attr.work_fn = vdpasim_blk_work; > + attr.buffer_size = PAGE_SIZE; > > vdpasim_blk_dev = vdpasim_create(&attr); > if (IS_ERR(vdpasim_blk_dev)) { > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > index b9372fdf2415..d0a1403f64b2 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > @@ -124,6 +124,7 @@ static int __init vdpasim_net_init(void) > > attr.work_fn = vdpasim_net_work; > attr.batch_mapping = batch_mapping; > + attr.buffer_size = PAGE_SIZE; > > vdpasim_net_dev = vdpasim_create(&attr); > if (IS_ERR(vdpasim_net_dev)) { _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-11-16 4:20 UTC|newest] Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-13 13:47 [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-13 13:47 ` [PATCH RFC 01/12] vhost-vdpa: add support for vDPA blk devices Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-17 10:57 ` Stefan Hajnoczi 2020-11-17 10:57 ` Stefan Hajnoczi 2020-11-17 15:05 ` Stefano Garzarella 2020-11-17 15:05 ` Stefano Garzarella 2020-11-13 13:47 ` [PATCH RFC 02/12] vdpa: split vdpasim to core and net modules Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-13 18:32 ` kernel test robot 2020-11-16 4:00 ` Jason Wang 2020-11-16 4:00 ` Jason Wang 2020-11-16 9:39 ` Stefano Garzarella 2020-11-16 9:39 ` Stefano Garzarella 2020-11-18 13:14 ` Stefano Garzarella 2020-11-18 13:14 ` Stefano Garzarella 2020-11-19 6:16 ` Jason Wang 2020-11-19 6:16 ` Jason Wang 2020-11-16 9:06 ` Dan Carpenter 2020-11-16 9:06 ` Dan Carpenter 2020-11-16 9:12 ` Stefano Garzarella 2020-11-16 10:47 ` Dan Carpenter 2020-11-16 10:47 ` Dan Carpenter 2020-11-16 11:16 ` Stefano Garzarella 2020-11-16 11:58 ` Dan Carpenter 2020-11-16 11:58 ` Dan Carpenter 2020-11-16 12:41 ` Stefano Garzarella 2020-11-16 12:54 ` Dan Carpenter 2020-11-16 12:54 ` Dan Carpenter 2020-11-13 13:47 ` [PATCH RFC 03/12] vdpa_sim: remove hard-coded virtq count Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:02 ` Jason Wang 2020-11-16 4:02 ` Jason Wang 2020-11-13 13:47 ` [PATCH RFC 04/12] vdpa: add vdpa simulator for block device Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:10 ` Jason Wang 2020-11-16 4:10 ` Jason Wang 2020-11-16 10:17 ` Stefano Garzarella 2020-11-16 10:17 ` Stefano Garzarella 2020-11-17 11:11 ` Stefan Hajnoczi 2020-11-17 11:11 ` Stefan Hajnoczi 2020-11-17 14:16 ` Stefano Garzarella 2020-11-17 14:16 ` Stefano Garzarella 2020-11-17 16:43 ` Stefan Hajnoczi 2020-11-17 16:43 ` Stefan Hajnoczi 2020-11-17 17:38 ` Stefano Garzarella 2020-11-17 17:38 ` Stefano Garzarella 2020-11-18 11:23 ` Stefan Hajnoczi 2020-11-18 11:23 ` Stefan Hajnoczi 2020-11-18 11:39 ` Stefano Garzarella 2020-11-18 11:39 ` Stefano Garzarella 2020-11-13 13:47 ` [PATCH RFC 05/12] vdpa_sim: remove the limit of IOTLB entries Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:12 ` Jason Wang 2020-11-16 4:12 ` Jason Wang 2020-11-16 10:22 ` Stefano Garzarella 2020-11-16 10:22 ` Stefano Garzarella 2020-11-13 13:47 ` [PATCH RFC 06/12] vdpa_sim: add struct vdpasim_device to store device properties Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:14 ` Jason Wang 2020-11-16 4:14 ` Jason Wang 2020-11-16 10:30 ` Stefano Garzarella 2020-11-16 10:30 ` Stefano Garzarella 2020-11-17 11:23 ` Stefan Hajnoczi 2020-11-17 11:23 ` Stefan Hajnoczi 2020-11-17 14:24 ` Stefano Garzarella 2020-11-17 14:24 ` Stefano Garzarella 2020-11-13 13:47 ` [PATCH RFC 07/12] vdpa_sim: move config management outside of the core Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:18 ` Jason Wang 2020-11-16 4:18 ` Jason Wang 2020-11-16 10:42 ` Stefano Garzarella 2020-11-16 10:42 ` Stefano Garzarella 2020-11-13 13:47 ` [PATCH RFC 08/12] vdpa_sim: use kvmalloc to allocate vdpasim->buffer Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:19 ` Jason Wang 2020-11-16 4:19 ` Jason Wang 2020-11-13 13:47 ` [PATCH RFC 09/12] vdpa_sim: make vdpasim->buffer size configurable Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:19 ` Jason Wang [this message] 2020-11-16 4:19 ` Jason Wang 2020-11-13 13:47 ` [PATCH RFC 10/12] vdpa_sim: split vdpasim_virtqueue's iov field in riov and wiov Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:21 ` Jason Wang 2020-11-16 4:21 ` Jason Wang 2020-11-17 11:27 ` Stefan Hajnoczi 2020-11-17 11:27 ` Stefan Hajnoczi 2020-11-20 14:41 ` Stefano Garzarella 2020-11-20 14:41 ` Stefano Garzarella 2020-11-13 13:47 ` [PATCH RFC 11/12] vringh: allow vringh_iov_xfer() to skip bytes when ptr is NULL Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-16 4:32 ` Jason Wang 2020-11-16 4:32 ` Jason Wang 2020-11-16 11:48 ` Stefano Garzarella 2020-11-16 11:48 ` Stefano Garzarella 2020-11-13 13:47 ` [PATCH RFC 12/12] vdpa_sim_blk: implement ramdisk behaviour Stefano Garzarella 2020-11-13 13:47 ` Stefano Garzarella 2020-11-13 15:15 ` kernel test robot 2020-11-16 5:25 ` Jason Wang 2020-11-16 5:25 ` Jason Wang 2020-11-16 11:08 ` Stefano Garzarella 2020-11-16 11:08 ` Stefano Garzarella 2020-11-16 9:50 ` Michael S. Tsirkin 2020-11-16 9:50 ` Michael S. Tsirkin 2020-11-16 11:23 ` Stefano Garzarella 2020-11-16 11:23 ` Stefano Garzarella 2020-11-17 11:36 ` Stefan Hajnoczi 2020-11-17 11:36 ` Stefan Hajnoczi 2020-11-17 14:32 ` Stefano Garzarella 2020-11-17 14:32 ` Stefano Garzarella 2020-11-16 3:37 ` [PATCH RFC 00/12] vdpa: generalize vdpa simulator and add block device Jason Wang 2020-11-16 3:37 ` Jason Wang 2020-11-16 8:53 ` Stefano Garzarella 2020-11-16 8:53 ` Stefano Garzarella 2020-12-18 11:38 ` Stefano Garzarella 2020-12-18 11:38 ` Stefano Garzarella 2020-12-21 3:16 ` Jason Wang 2020-12-21 3:16 ` Jason Wang 2020-12-21 11:14 ` Stefano Garzarella 2020-12-21 11:14 ` Stefano Garzarella 2020-12-22 2:44 ` Jason Wang 2020-12-22 2:44 ` Jason Wang 2020-12-22 10:57 ` Stefano Garzarella 2020-12-22 10:57 ` Stefano Garzarella 2020-12-22 12:29 ` Jason Wang 2020-12-22 12:29 ` Jason Wang 2020-12-22 12:56 ` Jason Wang 2020-12-22 12:56 ` Jason Wang 2020-12-22 13:23 ` Stefano Garzarella 2020-12-22 13:23 ` Stefano Garzarella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=433bbdf4-b69c-7ae8-a734-923ffac646eb@redhat.com \ --to=jasowang@redhat.com \ --cc=elic@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lvivier@redhat.com \ --cc=mgurtovoy@nvidia.com \ --cc=mst@redhat.com \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.