[PATCH] block: decode QUEUE_FLAG_HCTX_ACTIVE in debugfs output

[PATCH] block: decode QUEUE_FLAG_HCTX_ACTIVE in debugfs output

[Johannes Thumshirn]

While debugging an issue we've found that $DEBUGFS/block/$disk/state
doesn't decode QUEUE_FLAG_HCTX_ACTIVE but only displays its numerical
value.

Add QUEUE_FLAG(HCTX_ACTIVE) to the blk_queue_flag_name array so it'll get
decoded properly.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 block/blk-mq-debugfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index 4b66d2776eda..3b38d15723de 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -129,6 +129,7 @@ static const char *const blk_queue_flag_name[] = {
 	QUEUE_FLAG_NAME(PCI_P2PDMA),
 	QUEUE_FLAG_NAME(ZONE_RESETALL),
 	QUEUE_FLAG_NAME(RQ_ALLOC_TIME),
+	QUEUE_FLAG_NAME(HCTX_ACTIVE),
 	QUEUE_FLAG_NAME(NOWAIT),
 };
 #undef QUEUE_FLAG_NAME
-- 
2.32.0

Re: [PATCH] block: decode QUEUE_FLAG_HCTX_ACTIVE in debugfs output

[Jens Axboe]

On 10/4/21 1:22 AM, Johannes Thumshirn wrote:
> While debugging an issue we've found that $DEBUGFS/block/$disk/state
> doesn't decode QUEUE_FLAG_HCTX_ACTIVE but only displays its numerical
> value.
> 
> Add QUEUE_FLAG(HCTX_ACTIVE) to the blk_queue_flag_name array so it'll get
> decoded properly.

Applied, thanks.

We really should have some way to catch this at build time, this isn't the
first (and won't be the last) time we run into this.

-- 
Jens Axboe