From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 7/8] x86emul: support RDPRU
Date: Wed, 4 Sep 2019 11:26:21 +0200 [thread overview]
Message-ID: <435d5ee1-23a8-576a-22dd-0ed822430c79@suse.com> (raw)
In-Reply-To: <c0e34ad1-746b-6520-2d6a-f069e3107755@citrix.com>
On 03.09.2019 14:34, Andrew Cooper wrote:
>> --- a/xen/arch/x86/cpuid.c
>> +++ b/xen/arch/x86/cpuid.c
>> @@ -545,6 +545,11 @@ void recalculate_cpuid_policy(struct dom
>>
>> p->extd.maxlinaddr = p->extd.lm ? 48 : 32;
>>
>> + if ( p->extd.rdpru )
>> + p->extd.rdpru_max = min(p->extd.rdpru_max, max->extd.rdpru_max);
>> + else
>> + p->extd.rdpru_max = 0;
>> +
>> recalculate_xstate(p);
>> recalculate_misc(p);
>
> The CPUID logic needs quite a bit more than this, and to be safe on
> migrate. For one, recalculate_xstate() unilaterally clobbers this to 0.
I've looked again - recalculate_misc() clobbers .a, .b, and .c,
but not .d afaics. Anyway, just as a note, as you've said you'd
take care of this anyway, and I'll re-base afterwards.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-04 9:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 9:35 [Xen-devel] [PATCH v3 0/8] x86emul: further work Jan Beulich
2019-09-03 9:37 ` [Xen-devel] [PATCH v3 1/8] x86emul: support WBNOINVD Jan Beulich
2019-09-03 10:17 ` Andrew Cooper
2019-09-03 9:37 ` [Xen-devel] [PATCH v3 2/8] x86/HVM: ignore guest INVD uses Jan Beulich
2019-09-03 9:43 ` Paul Durrant
2019-09-03 10:18 ` Andrew Cooper
2019-09-03 12:22 ` Jan Beulich
2019-09-03 9:39 ` [Xen-devel] [PATCH v3 3/8] x86emul: generalize invlpg() hook Jan Beulich
2019-09-03 9:39 ` [Xen-devel] [PATCH v3 4/8] x86emul: support INVPCID Jan Beulich
2019-09-03 9:39 ` [Xen-devel] [PATCH v3 5/8] x86emul: support MOVDIR{I,64B} insns Jan Beulich
2019-09-03 10:28 ` [Xen-devel] [PATCH v3 5/8] x86emul: support MOVDIR{I, 64B} insns Andrew Cooper
2019-09-03 12:25 ` Jan Beulich
2019-09-04 10:19 ` Andrew Cooper
2019-09-04 11:52 ` Jan Beulich
2019-09-03 9:40 ` [Xen-devel] [PATCH v3 6/8] x86/HVM: scale MPERF values reported to guests (on AMD) Jan Beulich
2019-09-03 9:41 ` [Xen-devel] [PATCH v3 7/8] x86emul: support RDPRU Jan Beulich
2019-09-03 12:34 ` Andrew Cooper
2019-09-03 13:05 ` Jan Beulich
2019-09-04 9:26 ` Jan Beulich [this message]
2019-09-04 9:46 ` Andrew Cooper
2019-09-03 9:42 ` [Xen-devel] [PATCH v3 8/8] x86/HVM: don't needlessly intercept APERF/MPERF/TSC MSR reads Jan Beulich
2019-09-04 23:16 ` Boris Ostrovsky
2019-09-05 6:31 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435d5ee1-23a8-576a-22dd-0ed822430c79@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.