* [PATCH] ASoC: MMP audio needs sram support
@ 2014-06-05 10:40 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2014-06-05 10:40 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, Eric Miao, lgirdwood, Haojian Zhuang, Qiao Zhou,
linux-arm-kernel
>From e7a94bb7fb871c73cc85712d89c1f48d0271c1be Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 5 Jun 2014 12:31:28 +0200
Subject: [PATCH] ASoC: MMP audio needs sram support
Building the pxa/mmp audio driver without support for the mmp
sram driver enabled results in this link error:
sound/built-in.o: In function `mmp_pcm_free_dma_buffers':
:(.text+0x3e734): undefined reference to `sram_get_gpool'
sound/built-in.o: In function `mmp_pcm_new':
:(.text+0x3e7c0): undefined reference to `sram_get_gpool'
The sram driver is cannot be manually enabled and needs to
be turned on by selecting MMP_SRAM from each module that
needs it, which is what this patch does.
Ideally, MMP should move over to the generic SRAM support, but
for the moment, we can avoid the build error.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Qiao Zhou <zhouqiao@marvell.com>
diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index 42b305e..12a6da8 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -11,6 +11,7 @@ config SND_PXA2XX_SOC
config SND_MMP_SOC
bool "Soc Audio for Marvell MMP chips"
depends on ARCH_MMP
+ select MMP_SRAM
select SND_SOC_GENERIC_DMAENGINE_PCM
select SND_ARM
help
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ASoC: MMP audio needs sram support
@ 2014-06-05 10:40 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2014-06-05 10:40 UTC (permalink / raw)
To: linux-arm-kernel
>From e7a94bb7fb871c73cc85712d89c1f48d0271c1be Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 5 Jun 2014 12:31:28 +0200
Subject: [PATCH] ASoC: MMP audio needs sram support
Building the pxa/mmp audio driver without support for the mmp
sram driver enabled results in this link error:
sound/built-in.o: In function `mmp_pcm_free_dma_buffers':
:(.text+0x3e734): undefined reference to `sram_get_gpool'
sound/built-in.o: In function `mmp_pcm_new':
:(.text+0x3e7c0): undefined reference to `sram_get_gpool'
The sram driver is cannot be manually enabled and needs to
be turned on by selecting MMP_SRAM from each module that
needs it, which is what this patch does.
Ideally, MMP should move over to the generic SRAM support, but
for the moment, we can avoid the build error.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Qiao Zhou <zhouqiao@marvell.com>
diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index 42b305e..12a6da8 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -11,6 +11,7 @@ config SND_PXA2XX_SOC
config SND_MMP_SOC
bool "Soc Audio for Marvell MMP chips"
depends on ARCH_MMP
+ select MMP_SRAM
select SND_SOC_GENERIC_DMAENGINE_PCM
select SND_ARM
help
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: MMP audio needs sram support
2014-06-05 10:40 ` Arnd Bergmann
@ 2014-06-05 11:35 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-06-05 11:35 UTC (permalink / raw)
To: Arnd Bergmann
Cc: alsa-devel, Eric Miao, lgirdwood, Haojian Zhuang, Qiao Zhou,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 196 bytes --]
On Thu, Jun 05, 2014 at 12:40:04PM +0200, Arnd Bergmann wrote:
> Building the pxa/mmp audio driver without support for the mmp
> sram driver enabled results in this link error:
applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ASoC: MMP audio needs sram support
@ 2014-06-05 11:35 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-06-05 11:35 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 05, 2014 at 12:40:04PM +0200, Arnd Bergmann wrote:
> Building the pxa/mmp audio driver without support for the mmp
> sram driver enabled results in this link error:
applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140605/caf132ce/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: MMP audio needs sram support
2014-06-05 10:40 ` Arnd Bergmann
@ 2014-06-17 14:31 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-06-17 14:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: alsa-devel, Eric Miao, lgirdwood, Haojian Zhuang, Qiao Zhou,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 515 bytes --]
On Thu, Jun 05, 2014 at 12:40:04PM +0200, Arnd Bergmann wrote:
> From e7a94bb7fb871c73cc85712d89c1f48d0271c1be Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Thu, 5 Jun 2014 12:31:28 +0200
> Subject: [PATCH] ASoC: MMP audio needs sram support
>
> Building the pxa/mmp audio driver without support for the mmp
> sram driver enabled results in this link error:
One other thing here: please send patches in the format in
SubmittingPatches so that the tools can apply them cleanly.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ASoC: MMP audio needs sram support
@ 2014-06-17 14:31 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-06-17 14:31 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 05, 2014 at 12:40:04PM +0200, Arnd Bergmann wrote:
> From e7a94bb7fb871c73cc85712d89c1f48d0271c1be Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Thu, 5 Jun 2014 12:31:28 +0200
> Subject: [PATCH] ASoC: MMP audio needs sram support
>
> Building the pxa/mmp audio driver without support for the mmp
> sram driver enabled results in this link error:
One other thing here: please send patches in the format in
SubmittingPatches so that the tools can apply them cleanly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140617/df72168c/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-17 14:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-05 10:40 [PATCH] ASoC: MMP audio needs sram support Arnd Bergmann
2014-06-05 10:40 ` Arnd Bergmann
2014-06-05 11:35 ` Mark Brown
2014-06-05 11:35 ` Mark Brown
2014-06-17 14:31 ` Mark Brown
2014-06-17 14:31 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.