All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Framebuffer mode required for PowerBook Titanium
@ 2005-11-05 23:49 Michael Hanselmann
  2005-11-06  0:11   ` Antonino A. Daplas
  2005-11-06  0:17 ` Benjamin Herrenschmidt
  0 siblings, 2 replies; 9+ messages in thread
From: Michael Hanselmann @ 2005-11-05 23:49 UTC (permalink / raw)
  To: benh; +Cc: linux-kernel, linux-fbdev-devel

This patch adds the framebuffer mode required for an Apple PowerBook G4
Titanium.

Signed-off-by: Michael Hanselmann <linux-kernel@hansmi.ch>

---
--- linux-2.6.14/drivers/video/modedb.c.orig	2005-11-05 22:29:02.000000000 +0100
+++ linux-2.6.14/drivers/video/modedb.c	2005-11-05 22:31:15.000000000 +0100
@@ -251,6 +251,10 @@ static const struct fb_videomode modedb[
 	NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
 	FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
 	FB_VMODE_NONINTERLACED
+    }, {
+	/* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
+	"mac21", 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
+	FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
     },
 };

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Framebuffer mode required for PowerBook Titanium
  2005-11-05 23:49 [PATCH] Framebuffer mode required for PowerBook Titanium Michael Hanselmann
@ 2005-11-06  0:11   ` Antonino A. Daplas
  2005-11-06  0:17 ` Benjamin Herrenschmidt
  1 sibling, 0 replies; 9+ messages in thread
From: Antonino A. Daplas @ 2005-11-06  0:11 UTC (permalink / raw)
  To: Michael Hanselmann; +Cc: benh, linux-kernel, linux-fbdev-devel

Michael Hanselmann wrote:
> This patch adds the framebuffer mode required for an Apple PowerBook G4
> Titanium.
> 

Does booting with video=xxxfb:1152x768M@60 work?  If it does, I would prefer
that we avoid adding more entries to the global mode database.

Tony

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Framebuffer mode required for PowerBook Titanium
@ 2005-11-06  0:11   ` Antonino A. Daplas
  0 siblings, 0 replies; 9+ messages in thread
From: Antonino A. Daplas @ 2005-11-06  0:11 UTC (permalink / raw)
  To: Michael Hanselmann; +Cc: benh, linux-kernel, linux-fbdev-devel

Michael Hanselmann wrote:
> This patch adds the framebuffer mode required for an Apple PowerBook G4
> Titanium.
> 

Does booting with video=xxxfb:1152x768M@60 work?  If it does, I would prefer
that we avoid adding more entries to the global mode database.

Tony


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Framebuffer mode required for PowerBook Titanium
  2005-11-05 23:49 [PATCH] Framebuffer mode required for PowerBook Titanium Michael Hanselmann
  2005-11-06  0:11   ` Antonino A. Daplas
@ 2005-11-06  0:17 ` Benjamin Herrenschmidt
  2005-11-06  0:49   ` Michael Hanselmann
  1 sibling, 1 reply; 9+ messages in thread
From: Benjamin Herrenschmidt @ 2005-11-06  0:17 UTC (permalink / raw)
  To: Michael Hanselmann; +Cc: linux-kernel, linux-fbdev-devel

On Sun, 2005-11-06 at 00:49 +0100, Michael Hanselmann wrote:
> This patch adds the framebuffer mode required for an Apple PowerBook G4
> Titanium.
> 
> Signed-off-by: Michael Hanselmann <linux-kernel@hansmi.ch>
> 
> ---
> --- linux-2.6.14/drivers/video/modedb.c.orig	2005-11-05 22:29:02.000000000 +0100
> +++ linux-2.6.14/drivers/video/modedb.c	2005-11-05 22:31:15.000000000 +0100
> @@ -251,6 +251,10 @@ static const struct fb_videomode modedb[
>  	NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
>  	FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
>  	FB_VMODE_NONINTERLACED
> +    }, {
> +	/* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
> +	"mac21", 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
> +	FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
>      },
>  };

Please, re-do it without the "mac21" name, just leave NULL there.

Ben.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Framebuffer mode required for PowerBook Titanium
  2005-11-06  0:11   ` Antonino A. Daplas
  (?)
@ 2005-11-06  0:30   ` Michael Hanselmann
  2005-11-06  0:38       ` Antonino A. Daplas
  -1 siblings, 1 reply; 9+ messages in thread
From: Michael Hanselmann @ 2005-11-06  0:30 UTC (permalink / raw)
  To: Antonino A. Daplas; +Cc: benh, linux-kernel, linux-fbdev-devel

> Does booting with video=xxxfb:1152x768M@60 work?  If it does, I would prefer
> that we avoid adding more entries to the global mode database.

It boots but the picture is stretched over the display. That's what I
first tried, too, but only adding the mode definition fixed it.

Greets,
Michael

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Framebuffer mode required for PowerBook Titanium
  2005-11-06  0:30   ` Michael Hanselmann
@ 2005-11-06  0:38       ` Antonino A. Daplas
  0 siblings, 0 replies; 9+ messages in thread
From: Antonino A. Daplas @ 2005-11-06  0:38 UTC (permalink / raw)
  To: Michael Hanselmann; +Cc: benh, linux-kernel, linux-fbdev-devel

Michael Hanselmann wrote:
>> Does booting with video=xxxfb:1152x768M@60 work?  If it does, I would prefer
>> that we avoid adding more entries to the global mode database.
> 
> It boots but the picture is stretched over the display. That's what I
> first tried, too, but only adding the mode definition fixed it.

Okay.

Tony

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Framebuffer mode required for PowerBook Titanium
@ 2005-11-06  0:38       ` Antonino A. Daplas
  0 siblings, 0 replies; 9+ messages in thread
From: Antonino A. Daplas @ 2005-11-06  0:38 UTC (permalink / raw)
  To: Michael Hanselmann; +Cc: benh, linux-kernel, linux-fbdev-devel

Michael Hanselmann wrote:
>> Does booting with video=xxxfb:1152x768M@60 work?  If it does, I would prefer
>> that we avoid adding more entries to the global mode database.
> 
> It boots but the picture is stretched over the display. That's what I
> first tried, too, but only adding the mode definition fixed it.

Okay.

Tony


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Framebuffer mode required for PowerBook Titanium
  2005-11-06  0:17 ` Benjamin Herrenschmidt
@ 2005-11-06  0:49   ` Michael Hanselmann
  2005-11-06  1:39     ` Antonino A. Daplas
  0 siblings, 1 reply; 9+ messages in thread
From: Michael Hanselmann @ 2005-11-06  0:49 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linux-kernel, linux-fbdev-devel

This patch adds the framebuffer mode required for an Apple PowerBook G4
Titanium.

---

Redone with NULL instead of "mac21".

--- linux-2.6.14/drivers/video/modedb.c.orig	2005-11-05 22:29:02.000000000 +0100
+++ linux-2.6.14/drivers/video/modedb.c	2005-11-06 01:33:27.000000000 +0100
@@ -251,6 +251,10 @@
 	NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
 	FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
 	FB_VMODE_NONINTERLACED
+    }, {
+	/* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
+	NULL, 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
+	FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
     },
 };

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] Framebuffer mode required for PowerBook Titanium
  2005-11-06  0:49   ` Michael Hanselmann
@ 2005-11-06  1:39     ` Antonino A. Daplas
  0 siblings, 0 replies; 9+ messages in thread
From: Antonino A. Daplas @ 2005-11-06  1:39 UTC (permalink / raw)
  To: Michael Hanselmann
  Cc: Benjamin Herrenschmidt, linux-kernel, linux-fbdev-devel

Michael Hanselmann wrote:
> This patch adds the framebuffer mode required for an Apple PowerBook G4
> Titanium.

Feel free to add my

Acked-by: Antonino Daplas <adaplas@pol.net>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2005-11-06  1:39 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-05 23:49 [PATCH] Framebuffer mode required for PowerBook Titanium Michael Hanselmann
2005-11-06  0:11 ` Antonino A. Daplas
2005-11-06  0:11   ` Antonino A. Daplas
2005-11-06  0:30   ` Michael Hanselmann
2005-11-06  0:38     ` Antonino A. Daplas
2005-11-06  0:38       ` Antonino A. Daplas
2005-11-06  0:17 ` Benjamin Herrenschmidt
2005-11-06  0:49   ` Michael Hanselmann
2005-11-06  1:39     ` Antonino A. Daplas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.