* [PATCH] Add htons for icmp.id in conntrack/extensions/libct_proto_icmp.c
@ 2005-11-06 2:49 Krzysztof Oledzki
2005-11-06 2:59 ` Pablo Neira
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Oledzki @ 2005-11-06 2:49 UTC (permalink / raw)
To: Pablo Neira; +Cc: netfilter-devel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 553 bytes --]
Hello,
We need to add htons for icmp id.
Index: conntrack/extensions/libct_proto_icmp.c
===================================================================
--- conntrack/extensions/libct_proto_icmp.c (revision 4480)
+++ conntrack/extensions/libct_proto_icmp.c (working copy)
@@ -77,7 +77,7 @@
break;
case '3':
if (optarg) {
- orig->l4src.icmp.id = atoi(optarg);
+ orig->l4src.icmp.id = htons(atoi(optarg));
reply->l4dst.icmp.id = 0;
*flags |= ICMP_ID;
}
Best regards,
Krzysztof Olędzki
[-- Attachment #2: Type: TEXT/PLAIN, Size: 457 bytes --]
Index: conntrack/extensions/libct_proto_icmp.c
===================================================================
--- conntrack/extensions/libct_proto_icmp.c (revision 4480)
+++ conntrack/extensions/libct_proto_icmp.c (working copy)
@@ -77,7 +77,7 @@
break;
case '3':
if (optarg) {
- orig->l4src.icmp.id = atoi(optarg);
+ orig->l4src.icmp.id = htons(atoi(optarg));
reply->l4dst.icmp.id = 0;
*flags |= ICMP_ID;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Add htons for icmp.id in conntrack/extensions/libct_proto_icmp.c
2005-11-06 2:49 [PATCH] Add htons for icmp.id in conntrack/extensions/libct_proto_icmp.c Krzysztof Oledzki
@ 2005-11-06 2:59 ` Pablo Neira
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira @ 2005-11-06 2:59 UTC (permalink / raw)
To: Krzysztof Oledzki; +Cc: netfilter-devel
Krzysztof Oledzki wrote:
> We need to add htons for icmp id.
I'm going to apply it asap. Thanks.
--
Pablo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-06 2:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-06 2:49 [PATCH] Add htons for icmp.id in conntrack/extensions/libct_proto_icmp.c Krzysztof Oledzki
2005-11-06 2:59 ` Pablo Neira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.