All of lore.kernel.org
 help / color / mirror / Atom feed
From: poza@codeaurora.org
To: Christoph Hellwig <hch@infradead.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dongdong Liu <liudongdong3@huawei.com>,
	Keith Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>,
	Sinan Kaya <okaya@codeaurora.org>,
	Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v10 1/7] PCI/AER: Rename error recovery to generic pci naming
Date: Fri, 23 Feb 2018 10:54:35 +0530	[thread overview]
Message-ID: <4388ff68e84185bd825abf7ff4ae952d@codeaurora.org> (raw)
In-Reply-To: <20180222183403.GA6267@infradead.org>

On 2018-02-23 00:04, Christoph Hellwig wrote:
> On Thu, Feb 22, 2018 at 09:32:06PM +0530, Oza Pawandeep wrote:
>> This patch renames error recovery to generic name with pci prefix
>> 
>> Signed-off-by: Oza Pawandeep <poza@codeaurora.org>
>> 
>> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c 
>> b/drivers/pci/pcie/aer/aerdrv_core.c
>> index a4bfea5..306bf2f 100644
>> --- a/drivers/pci/pcie/aer/aerdrv_core.c
>> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
>> @@ -478,7 +478,7 @@ static pci_ers_result_t reset_link(struct pci_dev 
>> *dev)
>>  }
>> 
>>  /**
>> - * do_recovery - handle nonfatal/fatal error recovery process
>> + * pci_do_recovery - handle nonfatal/fatal error recovery process
>>   * @dev: pointer to a pci_dev data structure of agent detecting an 
>> error
>>   * @severity: error severity type
>>   *
>> @@ -486,7 +486,7 @@ static pci_ers_result_t reset_link(struct pci_dev 
>> *dev)
>>   * error detected message to all downstream drivers within a 
>> hierarchy in
>>   * question and return the returned code.
>>   */
>> -static void do_recovery(struct pci_dev *dev, int severity)
>> +static void pci_do_recovery(struct pci_dev *dev, int severity)
> 
> Maybe pcie_do_recovery?
> 

sure will take care.
Thanks.

> Otherwise looks fine:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2018-02-23  5:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 16:02 [PATCH v10 0/7] Address error and recovery for AER and DPC Oza Pawandeep
2018-02-22 16:02 ` [PATCH v10 1/7] PCI/AER: Rename error recovery to generic pci naming Oza Pawandeep
2018-02-22 18:34   ` Christoph Hellwig
2018-02-23  5:24     ` poza [this message]
2018-02-22 16:02 ` [PATCH v10 2/7] PCI/AER: factor out error reporting from AER Oza Pawandeep
2018-02-22 18:34   ` Christoph Hellwig
2018-02-22 18:42     ` David Laight
2018-02-22 16:02 ` [PATCH v10 3/7] PCI/ERR: add mutex to synchronize recovery Oza Pawandeep
2018-02-22 18:36   ` Christoph Hellwig
2018-02-23  5:27     ` poza
2018-02-22 16:02 ` [PATCH v10 4/7] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-02-22 18:39   ` Christoph Hellwig
2018-02-23  5:28     ` poza
2018-02-22 16:02 ` [PATCH v10 5/7] PCI/AER: Unify aer error defines at single space Oza Pawandeep
2018-02-22 16:06   ` poza
2018-02-22 16:02 ` [PATCH v10 6/7] PCI: Unify wait for link active into generic pci Oza Pawandeep
2018-02-22 18:43   ` Christoph Hellwig
2018-02-23  6:53     ` poza
2018-02-22 16:02 ` [PATCH v10 7/7] PCI/DPC: Enumerate the devices after DPC trigger event Oza Pawandeep

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4388ff68e84185bd825abf7ff4ae952d@codeaurora.org \
    --to=poza@codeaurora.org \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=keith.busch@intel.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=liudongdong3@huawei.com \
    --cc=okaya@codeaurora.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    --cc=timur@codeaurora.org \
    --cc=wzhang@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.