* posix_fadvise succeeds on FIFO.
@ 2005-12-06 20:34 Valentine Barshak
0 siblings, 0 replies; only message in thread
From: Valentine Barshak @ 2005-12-06 20:34 UTC (permalink / raw)
To: lkml
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
Hello all.
The following issue has been found with posix_fadvise:
the system call succeeds on a pipe or FIFO, although it has to fail with
EINVAL return value on linux.
I've attached a small test for posix_fadvise and a patch for linux
kernel 2.6.14 that fixes the problem.
The patch makes posix_fadvise return ESPIPE on FIFO/pipe in order to be
fully POSIX-compliant.
Please, take a look at these. Is it really a bug in kernel?
Thanks.
[-- Attachment #2: posix_fadvise_test.c --]
[-- Type: text/x-csrc, Size: 792 bytes --]
#define _GNU_SOURCE
#include <stdio.h>
#include <unistd.h>
#include <stdlib.h>
#include <fcntl.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <errno.h>
int main()
{
int retval, fd;
if (mkfifo("fifo", 0666) < 0) {
printf("create fifo error\n");
return 1;
}
fd = open("fifo", O_RDWR);
if (fd < 0) {
printf("open fifo error\n");
remove("fifo");
return 1;
}
retval = posix_fadvise(fd, 0, 0, POSIX_FADV_NORMAL);
if (retval) {
printf("Expected fail - The fd argument is associated with a pipe or FIFO.\n");
if (retval != ESPIPE)
printf("Unexpected ERRNO %d (Expected %d)\n", retval, ESPIPE);
} else
printf("Unexpected success - The fd argument is associated with a pipe or FIFO.\n");
close(fd);
remove("fifo");
if (retval)
return 0;
return 1;
}
[-- Attachment #3: fadv.patch --]
[-- Type: text/x-patch, Size: 409 bytes --]
--- a/mm/fadvise.c 2005-10-10 22:54:29.000000000 +0400
+++ b/mm/fadvise.c 2005-12-06 23:04:19.980711464 +0300
@@ -37,6 +37,11 @@
if (!file)
return -EBADF;
+ if (S_ISFIFO(file->f_dentry->d_inode->i_mode)) {
+ ret = -ESPIPE;
+ goto out;
+ }
+
mapping = file->f_mapping;
if (!mapping || len < 0) {
ret = -EINVAL;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-12-06 20:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-06 20:34 posix_fadvise succeeds on FIFO Valentine Barshak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.