Re: [PATCH] Cpuset: rcu optimization of page alloc hook

From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: dada1@cosmosbay.com, pj@sgi.com, linux-kernel@vger.kernel.org,
	Simon.Derr@bull.net, ak@suse.de, clameter@sgi.com
Subject: Re: [PATCH] Cpuset: rcu optimization of page alloc hook
Date: Mon, 12 Dec 2005 20:38:59 +1100	[thread overview]
Message-ID: <439D4533.6000708@yahoo.com.au> (raw)
In-Reply-To: <20051212011108.0725524d.akpm@osdl.org>

Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> 

>>
>>Is it a good idea for all kmem_cache_t? If so, can we move
>>__read_mostly to the type definition?
>>
> 
> 
> Yes, I suppose that's worthwhile.
> 
> We've been shuffling towards removing kmem_cache_t in favour of `struct
> kmem_cache', but this is an argument against doing that.
> 
> If we can work out how:
> 
> void foo()
> {
> 	kmem_cache_t *p;
> }
> 
> That'll barf.
> 

Mmm. And the structure within structure, which Eric points out. I assumed
without grepping that those were mostly confined to slab itself and would
be easy to special case, but it turns out networking makes some use of
them too.

-- 
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com 