* [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev
@ 2022-10-24 11:00 Dongliang Mu
2022-10-24 13:54 ` Marc Kleine-Budde
0 siblings, 1 reply; 4+ messages in thread
From: Dongliang Mu @ 2022-10-24 11:00 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vincent Mailhol,
Stefan Mätje, Dongliang Mu, Julia Lawall
Cc: linux-can, netdev, linux-kernel
From API pairing, modify unregister_netdev to unregister_candev since
the registeration function is register_candev. Actually, they are the
same.
Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
---
drivers/net/can/usb/ucan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c
index 7c35f50fda4e..60f730094e5d 100644
--- a/drivers/net/can/usb/ucan.c
+++ b/drivers/net/can/usb/ucan.c
@@ -1581,7 +1581,7 @@ static void ucan_disconnect(struct usb_interface *intf)
usb_set_intfdata(intf, NULL);
if (up) {
- unregister_netdev(up->netdev);
+ unregister_candev(up->netdev);
free_candev(up->netdev);
}
}
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev
2022-10-24 11:00 [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev Dongliang Mu
@ 2022-10-24 13:54 ` Marc Kleine-Budde
2022-10-25 2:27 ` Dongliang Mu
0 siblings, 1 reply; 4+ messages in thread
From: Marc Kleine-Budde @ 2022-10-24 13:54 UTC (permalink / raw)
To: Dongliang Mu
Cc: Wolfgang Grandegger, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Vincent Mailhol, Stefan Mätje,
Julia Lawall, linux-can, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On 24.10.2022 19:00:30, Dongliang Mu wrote:
> From API pairing, modify unregister_netdev to unregister_candev since
> the registeration function is register_candev. Actually, they are the
^ typo
> same.
>
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
Fixed while applying.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev
2022-10-24 13:54 ` Marc Kleine-Budde
@ 2022-10-25 2:27 ` Dongliang Mu
2022-10-25 7:13 ` Marc Kleine-Budde
0 siblings, 1 reply; 4+ messages in thread
From: Dongliang Mu @ 2022-10-25 2:27 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: Wolfgang Grandegger, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Vincent Mailhol, Stefan Mätje,
Julia Lawall, linux-can, netdev, linux-kernel
> On Oct 24, 2022, at 21:54, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> On 24.10.2022 19:00:30, Dongliang Mu wrote:
>> From API pairing, modify unregister_netdev to unregister_candev since
>> the registeration function is register_candev. Actually, they are the
> ^ typo
:(
>> same.
>>
>> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
>
> Fixed while applying.
You mean it is already done in your own tree? If yes, that’s fine.
>
> Thanks,
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev
2022-10-25 2:27 ` Dongliang Mu
@ 2022-10-25 7:13 ` Marc Kleine-Budde
0 siblings, 0 replies; 4+ messages in thread
From: Marc Kleine-Budde @ 2022-10-25 7:13 UTC (permalink / raw)
To: Dongliang Mu
Cc: Wolfgang Grandegger, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Vincent Mailhol, Stefan Mätje,
Julia Lawall, linux-can, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
On 25.10.2022 10:27:12, Dongliang Mu wrote:
> > Fixed while applying.
>
> You mean it is already done in your own tree? If yes, that’s fine.
ACK
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-25 7:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 11:00 [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev Dongliang Mu
2022-10-24 13:54 ` Marc Kleine-Budde
2022-10-25 2:27 ` Dongliang Mu
2022-10-25 7:13 ` Marc Kleine-Budde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.