* [PATCH v2 1/1] drm/i915: Update only cur_freq without setting RPNSWREQ when device is suspended
@ 2016-10-24 6:38 Sagar Arun Kamble
2016-10-24 7:16 ` ✗ Fi.CI.BAT: warning for series starting with [v2,1/1] " Patchwork
0 siblings, 1 reply; 3+ messages in thread
From: Sagar Arun Kamble @ 2016-10-24 6:38 UTC (permalink / raw)
To: intel-gfx
If min/max frequency is updated from debugfs/sysfs and device is
suspended, just update the driver tracking state cur_freq and it will
come into effect when HW becomes busy next.
v2: Folded awake check into if/else. (Jon)
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 560fc7a..96dbce5 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5114,7 +5114,11 @@ void gen6_rps_boost(struct drm_i915_private *dev_priv,
void intel_set_rps(struct drm_i915_private *dev_priv, u8 val)
{
- if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
+ lockdep_assert_held(&dev_priv->rps.hw_lock);
+
+ if (!dev_priv->gt.awake)
+ dev_priv->rps.cur_freq = val;
+ else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
valleyview_set_rps(dev_priv, val);
else
gen6_set_rps(dev_priv, val);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: warning for series starting with [v2,1/1] drm/i915: Update only cur_freq without setting RPNSWREQ when device is suspended
2016-10-24 6:38 [PATCH v2 1/1] drm/i915: Update only cur_freq without setting RPNSWREQ when device is suspended Sagar Arun Kamble
@ 2016-10-24 7:16 ` Patchwork
2016-10-24 8:08 ` Saarinen, Jani
0 siblings, 1 reply; 3+ messages in thread
From: Patchwork @ 2016-10-24 7:16 UTC (permalink / raw)
To: sagar.a.kamble; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/1] drm/i915: Update only cur_freq without setting RPNSWREQ when device is suspended
URL : https://patchwork.freedesktop.org/series/14231/
State : warning
== Summary ==
Series 14231v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/14231/revisions/1/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (fi-skl-6700hq)
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> DMESG-WARN (fi-skl-6700hq)
Test kms_force_connector_basic:
Subgroup force-load-detect:
pass -> DMESG-WARN (fi-ivb-3770)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-ilk-650)
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup suspend-read-crc-pipe-c:
pass -> DMESG-WARN (fi-skl-6700hq)
fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42
fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30
fi-byt-j1900 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31
fi-byt-n2820 total:246 pass:211 dwarn:0 dfail:0 fail:0 skip:35
fi-hsw-4770 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
fi-hsw-4770r total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
fi-ilk-650 total:246 pass:184 dwarn:1 dfail:0 fail:1 skip:60
fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25
fi-ivb-3770 total:246 pass:220 dwarn:1 dfail:0 fail:0 skip:25
fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24
fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:246 pass:219 dwarn:4 dfail:0 fail:0 skip:23
fi-skl-6700k total:246 pass:222 dwarn:1 dfail:0 fail:0 skip:23
fi-skl-6770hq total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36
fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2797/
ce5c0064ae0d2b55aa73b8f4875e888aa84a8021 drm-intel-nightly: 2016y-10m-24d-06h-29m-10s UTC integration manifest
f34a1f9 drm/i915: Update only cur_freq without setting RPNSWREQ when device is suspended
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for series starting with [v2,1/1] drm/i915: Update only cur_freq without setting RPNSWREQ when device is suspended
2016-10-24 7:16 ` ✗ Fi.CI.BAT: warning for series starting with [v2,1/1] " Patchwork
@ 2016-10-24 8:08 ` Saarinen, Jani
0 siblings, 0 replies; 3+ messages in thread
From: Saarinen, Jani @ 2016-10-24 8:08 UTC (permalink / raw)
To: intel-gfx, Kamble, Sagar A
> == Series Details ==
>
> Series: series starting with [v2,1/1] drm/i915: Update only cur_freq without
> setting RPNSWREQ when device is suspended
> URL : https://patchwork.freedesktop.org/series/14231/
> State : warning
>
> == Summary ==
>
> Series 14231v1 Series without cover letter
> https://patchwork.freedesktop.org/api/1.0/series/14231/revisions/1/mbox/
>
> Test drv_module_reload_basic:
> dmesg-warn -> PASS (fi-skl-6700hq)
> Test gem_exec_suspend:
> Subgroup basic-s3:
> pass -> DMESG-WARN (fi-skl-6700hq)
https://bugs.freedesktop.org/show_bug.cgi?id=98353
> Test kms_force_connector_basic:
> Subgroup force-load-detect:
> pass -> DMESG-WARN (fi-ivb-3770)
https://bugs.freedesktop.org/show_bug.cgi?id=98228
> Test kms_pipe_crc_basic:
> Subgroup suspend-read-crc-pipe-a:
> pass -> DMESG-WARN (fi-skl-6700hq)
https://bugs.freedesktop.org/show_bug.cgi?id=98353
> pass -> DMESG-WARN (fi-ilk-650)
[ 342.836614] [drm:intel_pch_fifo_underrun_irq_handler [i915]] *ERROR* PCH transcoder B FIFO underrun
[ 342.853231] [drm:intel_pch_fifo_underrun_irq_handler [i915]] *ERROR* PCH transcoder B FIFO underrun
https://bugs.freedesktop.org/show_bug.cgi?id=98251
> Subgroup suspend-read-crc-pipe-b:
> pass -> DMESG-WARN (fi-skl-6700hq)
https://bugs.freedesktop.org/show_bug.cgi?id=98353
> Subgroup suspend-read-crc-pipe-c:
> pass -> DMESG-WARN (fi-skl-6700hq)
https://bugs.freedesktop.org/show_bug.cgi?id=98353
>
> fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15
> fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42
> fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30
> fi-byt-j1900 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31
> fi-byt-n2820 total:246 pass:211 dwarn:0 dfail:0 fail:0 skip:35
> fi-hsw-4770 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
> fi-hsw-4770r total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
> fi-ilk-650 total:246 pass:184 dwarn:1 dfail:0 fail:1 skip:60
> fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25
> fi-ivb-3770 total:246 pass:220 dwarn:1 dfail:0 fail:0 skip:25
> fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24
> fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
> fi-skl-6700hq total:246 pass:219 dwarn:4 dfail:0 fail:0 skip:23
> fi-skl-6700k total:246 pass:222 dwarn:1 dfail:0 fail:0 skip:23
> fi-skl-6770hq total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
> fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36
> fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
>
> Results at /archive/results/CI_IGT_test/Patchwork_2797/
>
> ce5c0064ae0d2b55aa73b8f4875e888aa84a8021 drm-intel-nightly: 2016y-10m-
> 24d-06h-29m-10s UTC integration manifest
> f34a1f9 drm/i915: Update only cur_freq without setting RPNSWREQ when
> device is suspended
>
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-24 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-24 6:38 [PATCH v2 1/1] drm/i915: Update only cur_freq without setting RPNSWREQ when device is suspended Sagar Arun Kamble
2016-10-24 7:16 ` ✗ Fi.CI.BAT: warning for series starting with [v2,1/1] " Patchwork
2016-10-24 8:08 ` Saarinen, Jani
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.