All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gvt: Fix workload status after wait
@ 2016-11-02  5:41 Zhenyu Wang
  2016-11-02  6:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2016-11-02  6:47 ` [PATCH] " Joonas Lahtinen
  0 siblings, 2 replies; 5+ messages in thread
From: Zhenyu Wang @ 2016-11-02  5:41 UTC (permalink / raw)
  To: igvt-g-dev; +Cc: intel-gfx

From commit e95433c73a11759203af1cae5958f998c9673370, workload status setting
was changed to only capture on error path, but we need to set it properly in
normal path too, otherwise we'll fail to complete workload which could lead
guest VM vGPU reset.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
---
 drivers/gpu/drm/i915/gvt/scheduler.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index 18acb45..bc4c14a 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -455,7 +455,8 @@ static int workload_thread(void *priv)
 		if (lret < 0) {
 			workload->status = lret;
 			gvt_err("fail to wait workload, skip\n");
-		}
+		} else
+			workload->status = 0;
 
 complete:
 		gvt_dbg_sched("will complete workload %p\n, status: %d\n",
-- 
2.10.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix workload status after wait
  2016-11-02  5:41 [PATCH] drm/i915/gvt: Fix workload status after wait Zhenyu Wang
@ 2016-11-02  6:24 ` Patchwork
  2016-11-02  7:08   ` Saarinen, Jani
  2016-11-02  6:47 ` [PATCH] " Joonas Lahtinen
  1 sibling, 1 reply; 5+ messages in thread
From: Patchwork @ 2016-11-02  6:24 UTC (permalink / raw)
  To: Zhenyu Wang; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/gvt: Fix workload status after wait
URL   : https://patchwork.freedesktop.org/series/14711/
State : failure

== Summary ==

Series 14711v1 drm/i915/gvt: Fix workload status after wait
https://patchwork.freedesktop.org/api/1.0/series/14711/revisions/1/mbox/

Test drv_module_reload_basic:
                pass       -> DMESG-WARN (fi-ilk-650)
Test gem_ctx_switch:
        Subgroup basic-default:
                pass       -> TIMEOUT    (fi-bsw-n3050)
        Subgroup basic-default-heavy:
                pass       -> INCOMPLETE (fi-bsw-n3050)
Test gem_exec_suspend:
        Subgroup basic-s3:
                pass       -> DMESG-WARN (fi-ilk-650)
Test kms_busy:
        Subgroup basic-flip-default-a:
                pass       -> DMESG-WARN (fi-ilk-650)
Test kms_pipe_crc_basic:
        Subgroup bad-nb-words-1:
                pass       -> DMESG-WARN (fi-ilk-650)
        Subgroup bad-source:
                dmesg-warn -> PASS       (fi-ilk-650)
        Subgroup hang-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-ilk-650)
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                dmesg-warn -> PASS       (fi-ilk-650)
        Subgroup read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-ilk-650)
        Subgroup suspend-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-ilk-650)

fi-bdw-5557u     total:241  pass:226  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:23   pass:21   dwarn:0   dfail:0   fail:0   skip:0  
fi-bxt-t5700     total:241  pass:213  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900     total:241  pass:213  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:241  pass:209  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:241  pass:221  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:241  pass:220  dwarn:0   dfail:0   fail:0   skip:21 
fi-ilk-650       total:241  pass:181  dwarn:6   dfail:0   fail:0   skip:54 
fi-ivb-3520m     total:241  pass:218  dwarn:0   dfail:0   fail:0   skip:23 
fi-ivb-3770      total:241  pass:218  dwarn:0   dfail:0   fail:0   skip:23 
fi-kbl-7200u     total:241  pass:219  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:241  pass:227  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:241  pass:220  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:241  pass:219  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:241  pass:227  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:241  pass:208  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:241  pass:207  dwarn:0   dfail:0   fail:0   skip:34 

c5ad9c11e819eebcad5b9be5aa5e991e89b26965 drm-intel-nightly: 2016y-11m-01d-16h-36m-25s UTC integration manifest
6995b34 drm/i915/gvt: Fix workload status after wait

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2883/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/gvt: Fix workload status after wait
  2016-11-02  5:41 [PATCH] drm/i915/gvt: Fix workload status after wait Zhenyu Wang
  2016-11-02  6:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-11-02  6:47 ` Joonas Lahtinen
  2016-11-02  7:07   ` Zhenyu Wang
  1 sibling, 1 reply; 5+ messages in thread
From: Joonas Lahtinen @ 2016-11-02  6:47 UTC (permalink / raw)
  To: Zhenyu Wang, igvt-g-dev; +Cc: intel-gfx

On ke, 2016-11-02 at 13:41 +0800, Zhenyu Wang wrote:
> From commit e95433c73a11759203af1cae5958f998c9673370, workload status setting
> was changed to only capture on error path, but we need to set it properly in
> normal path too, otherwise we'll fail to complete workload which could lead
> guest VM vGPU reset.
> 

Should have Fixes tag with the above commit.

> @@ -455,7 +455,8 @@ static int workload_thread(void *priv)
>  		if (lret < 0) {
>  			workload->status = lret;
>  			gvt_err("fail to wait workload, skip\n");
> -		}
> +		} else
> +			workload->status = 0;

All branches of if-else continuum must use braces if one does, so
"} else {" here

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/gvt: Fix workload status after wait
  2016-11-02  6:47 ` [PATCH] " Joonas Lahtinen
@ 2016-11-02  7:07   ` Zhenyu Wang
  0 siblings, 0 replies; 5+ messages in thread
From: Zhenyu Wang @ 2016-11-02  7:07 UTC (permalink / raw)
  To: Joonas Lahtinen; +Cc: intel-gfx, igvt-g-dev


[-- Attachment #1.1: Type: text/plain, Size: 1009 bytes --]

On 2016.11.02 08:47:52 +0200, Joonas Lahtinen wrote:
> On ke, 2016-11-02 at 13:41 +0800, Zhenyu Wang wrote:
> > From commit e95433c73a11759203af1cae5958f998c9673370, workload status setting
> > was changed to only capture on error path, but we need to set it properly in
> > normal path too, otherwise we'll fail to complete workload which could lead
> > guest VM vGPU reset.
> > 
> 
> Should have Fixes tag with the above commit.
> 
> > @@ -455,7 +455,8 @@ static int workload_thread(void *priv)
> >  		if (lret < 0) {
> >  			workload->status = lret;
> >  			gvt_err("fail to wait workload, skip\n");
> > -		}
> > +		} else
> > +			workload->status = 0;
> 
> All branches of if-else continuum must use braces if one does, so
> "} else {" here
> 

Thanks for the review. I'll queue this up in gvt-linux tree as it stopped
our testing and will be included in next pull request.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix workload status after wait
  2016-11-02  6:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-11-02  7:08   ` Saarinen, Jani
  0 siblings, 0 replies; 5+ messages in thread
From: Saarinen, Jani @ 2016-11-02  7:08 UTC (permalink / raw)
  To: intel-gfx

> == Series Details ==
> 
> Series: drm/i915/gvt: Fix workload status after wait
> URL   : https://patchwork.freedesktop.org/series/14711/
> State : failure
> 
> == Summary ==
> 
> Series 14711v1 drm/i915/gvt: Fix workload status after wait
> https://patchwork.freedesktop.org/api/1.0/series/14711/revisions/1/mbox/
> 
> Test drv_module_reload_basic:
>                 pass       -> DMESG-WARN (fi-ilk-650)
> Test gem_ctx_switch:
>         Subgroup basic-default:
>                 pass       -> TIMEOUT    (fi-bsw-n3050)
Seen also on CI: https://intel-gfx-ci.01.org/CI/fi-bsw-n3050.html => (CI_DRM_1772 / Oct 27).

running: igt/gem_ctx_switch/basic-default
[021/241] pass: 21 /                     
timeout: igt/gem_ctx_switch/basic-default
[022/241] pass: 21, timeout: 1 /
running: igt/gem_ctx_switch/basic-default-heavy
[022/241] pass: 21, timeout: 1 -               
Build timed out (after 17 minutes). Marking the build as aborted.

>         Subgroup basic-default-heavy:
>                 pass       -> INCOMPLETE (fi-bsw-n3050)
> Test gem_exec_suspend:
>         Subgroup basic-s3:
>                 pass       -> DMESG-WARN (fi-ilk-650)
> Test kms_busy:
>         Subgroup basic-flip-default-a:
>                 pass       -> DMESG-WARN (fi-ilk-650)
> Test kms_pipe_crc_basic:
>         Subgroup bad-nb-words-1:
>                 pass       -> DMESG-WARN (fi-ilk-650)
These all ILK-650 cases seems to be https://bugs.freedesktop.org/show_bug.cgi?id=98531 ?

>         Subgroup bad-source:
>                 dmesg-warn -> PASS       (fi-ilk-650)
>         Subgroup hang-read-crc-pipe-a:
>                 dmesg-warn -> PASS       (fi-ilk-650)
>         Subgroup nonblocking-crc-pipe-a-frame-sequence:
>                 dmesg-warn -> PASS       (fi-ilk-650)
>         Subgroup read-crc-pipe-a:
>                 pass       -> DMESG-WARN (fi-ilk-650)
>         Subgroup suspend-read-crc-pipe-a:
>                 dmesg-warn -> PASS       (fi-ilk-650)
> 
> fi-bsw-n3050     total:23   pass:21   dwarn:0   dfail:0   fail:0   skip:0
> fi-ilk-650       total:241  pass:181  dwarn:6   dfail:0   fail:0   skip:54
> 
> c5ad9c11e819eebcad5b9be5aa5e991e89b26965 drm-intel-nightly: 2016y-
> 11m-01d-16h-36m-25s UTC integration manifest
> 6995b34 drm/i915/gvt: Fix workload status after wait
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2883/


Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-02  7:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-02  5:41 [PATCH] drm/i915/gvt: Fix workload status after wait Zhenyu Wang
2016-11-02  6:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-11-02  7:08   ` Saarinen, Jani
2016-11-02  6:47 ` [PATCH] " Joonas Lahtinen
2016-11-02  7:07   ` Zhenyu Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.