* [PATCH v4] drm/i915: Respect num_pipes when install or reset display IRQ
@ 2016-12-23 6:06 Wang Elaine
2016-12-23 6:53 ` ✗ Fi.CI.BAT: warning for " Patchwork
0 siblings, 1 reply; 4+ messages in thread
From: Wang Elaine @ 2016-12-23 6:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Elaine Wang
From: Elaine Wang <elaine.wang@intel.com>
Some platforms don't have display. To avoid accessing the
non-existent display interrupt registers, check whether num_pipes
isn't zero before invoking display IRQ install or reset function.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Elaine Wang <elaine.wang@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index a0e70f5..3c9a885 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2990,8 +2990,10 @@ static void gen8_irq_reset(struct drm_device *dev)
POWER_DOMAIN_PIPE(pipe)))
GEN8_IRQ_RESET_NDX(DE_PIPE, pipe);
- GEN5_IRQ_RESET(GEN8_DE_PORT_);
- GEN5_IRQ_RESET(GEN8_DE_MISC_);
+ if (INTEL_INFO(dev_priv)->num_pipes) {
+ GEN5_IRQ_RESET(GEN8_DE_PORT_);
+ GEN5_IRQ_RESET(GEN8_DE_MISC_);
+ }
GEN5_IRQ_RESET(GEN8_PCU_);
if (HAS_PCH_SPLIT(dev_priv))
@@ -3414,7 +3416,9 @@ static int gen8_irq_postinstall(struct drm_device *dev)
ibx_irq_pre_postinstall(dev);
gen8_gt_irq_postinstall(dev_priv);
- gen8_de_irq_postinstall(dev_priv);
+
+ if (INTEL_INFO(dev_priv)->num_pipes)
+ gen8_de_irq_postinstall(dev_priv);
if (HAS_PCH_SPLIT(dev_priv))
ibx_irq_postinstall(dev);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: Respect num_pipes when install or reset display IRQ
2016-12-23 6:06 [PATCH v4] drm/i915: Respect num_pipes when install or reset display IRQ Wang Elaine
@ 2016-12-23 6:53 ` Patchwork
2016-12-23 9:04 ` Wang, Elaine
0 siblings, 1 reply; 4+ messages in thread
From: Patchwork @ 2016-12-23 6:53 UTC (permalink / raw)
To: Wang Elaine; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Respect num_pipes when install or reset display IRQ
URL : https://patchwork.freedesktop.org/series/17164/
State : warning
== Summary ==
Series 17164v1 drm/i915: Respect num_pipes when install or reset display IRQ
https://patchwork.freedesktop.org/api/1.0/series/17164/revisions/1/mbox/
Test kms_flip:
Subgroup basic-plain-flip:
pass -> DMESG-WARN (fi-snb-2520m)
fi-bdw-5557u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
fi-bsw-n3050 total:246 pass:207 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
fi-bxt-t5700 total:82 pass:69 dwarn:0 dfail:0 fail:0 skip:12
fi-byt-j1900 total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19
fi-hsw-4770r total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19
fi-ivb-3520m total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
fi-ivb-3770 total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
fi-kbl-7500u total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
fi-skl-6260u total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700hq total:246 pass:226 dwarn:0 dfail:0 fail:0 skip:20
fi-skl-6700k total:246 pass:222 dwarn:3 dfail:0 fail:0 skip:21
fi-skl-6770hq total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13
fi-snb-2520m total:246 pass:214 dwarn:1 dfail:0 fail:0 skip:31
fi-snb-2600 total:246 pass:214 dwarn:0 dfail:0 fail:0 skip:32
7165fdc7f0b0b536557fcd0a222d083a901be57c drm-tip: 2016y-12m-22d-19h-42m-25s UTC integration manifest
2728153 drm/i915: Respect num_pipes when install or reset display IRQ
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3383/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for drm/i915: Respect num_pipes when install or reset display IRQ
2016-12-23 6:53 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-12-23 9:04 ` Wang, Elaine
2016-12-23 9:15 ` Saarinen, Jani
0 siblings, 1 reply; 4+ messages in thread
From: Wang, Elaine @ 2016-12-23 9:04 UTC (permalink / raw)
To: intel-gfx
This patch shouldn't impact on platforms that have non-zero num_pipes. The warning happened to snb, which has non-zero num_pipes according to dmesg log "[drm:intel_modeset_init [i915]] 2 display pipes available" in https://intel-gfx-ci.01.org/CI/Patchwork_3383/fi-snb-2520m/dmesg-before.log. So the warning isn't a regression caused by this patch.
According to the error message in dmesg log, it looks like it's the same issue reported by Bug 98228 - [BAT IVB] HDMI *ERROR* EDID checksum is invalid ( https://bugs.freedesktop.org/show_bug.cgi?id=98228)
[ 413.875957] [drm:drm_edid_block_valid] *ERROR* EDID checksum is invalid, remainder is 63
Thanks,
Elaine
> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Patchwork
> Sent: Friday, December 23, 2016 2:54 PM
> To: Wang, Elaine <elaine.wang@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Respect num_pipes
> when install or reset display IRQ
>
> == Series Details ==
>
> Series: drm/i915: Respect num_pipes when install or reset display IRQ
> URL : https://patchwork.freedesktop.org/series/17164/
> State : warning
>
> == Summary ==
>
> Series 17164v1 drm/i915: Respect num_pipes when install or reset display
> IRQ
> https://patchwork.freedesktop.org/api/1.0/series/17164/revisions/1/mbox/
>
> Test kms_flip:
> Subgroup basic-plain-flip:
> pass -> DMESG-WARN (fi-snb-2520m)
>
> fi-bdw-5557u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
> fi-bsw-n3050 total:246 pass:207 dwarn:0 dfail:0 fail:0 skip:39
> fi-bxt-j4205 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
> fi-bxt-t5700 total:82 pass:69 dwarn:0 dfail:0 fail:0 skip:12
> fi-byt-j1900 total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:27
> fi-byt-n2820 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31
> fi-hsw-4770 total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19
> fi-hsw-4770r total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19
> fi-ivb-3520m total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
> fi-ivb-3770 total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
> fi-kbl-7500u total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
> fi-skl-6260u total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13
> fi-skl-6700hq total:246 pass:226 dwarn:0 dfail:0 fail:0 skip:20
> fi-skl-6700k total:246 pass:222 dwarn:3 dfail:0 fail:0 skip:21
> fi-skl-6770hq total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13
> fi-snb-2520m total:246 pass:214 dwarn:1 dfail:0 fail:0 skip:31
> fi-snb-2600 total:246 pass:214 dwarn:0 dfail:0 fail:0 skip:32
>
> 7165fdc7f0b0b536557fcd0a222d083a901be57c drm-tip: 2016y-12m-22d-19h-
> 42m-25s UTC integration manifest
> 2728153 drm/i915: Respect num_pipes when install or reset display IRQ
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3383/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for drm/i915: Respect num_pipes when install or reset display IRQ
2016-12-23 9:04 ` Wang, Elaine
@ 2016-12-23 9:15 ` Saarinen, Jani
0 siblings, 0 replies; 4+ messages in thread
From: Saarinen, Jani @ 2016-12-23 9:15 UTC (permalink / raw)
To: Wang, Elaine, intel-gfx
HI,
> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Wang, Elaine
> Sent: Friday, December 23, 2016 11:04 AM
> To: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Respect num_pipes
> when install or reset display IRQ
>
> This patch shouldn't impact on platforms that have non-zero num_pipes. The
> warning happened to snb, which has non-zero num_pipes according to
> dmesg log "[drm:intel_modeset_init [i915]] 2 display pipes available" in
> https://intel-gfx-ci.01.org/CI/Patchwork_3383/fi-snb-2520m/dmesg-
> before.log. So the warning isn't a regression caused by this patch.
>
> According to the error message in dmesg log, it looks like it's the same issue
> reported by Bug 98228 - [BAT IVB] HDMI *ERROR* EDID checksum is invalid (
> https://bugs.freedesktop.org/show_bug.cgi?id=98228)
Almost as we have own for SNB too: https://bugs.freedesktop.org/show_bug.cgi?id=98625
But yes, is known issue.
>
> [ 413.875957] [drm:drm_edid_block_valid] *ERROR* EDID checksum is
> invalid, remainder is 63
>
> Thanks,
> Elaine
> > -----Original Message-----
> > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
> > Behalf Of Patchwork
> > Sent: Friday, December 23, 2016 2:54 PM
> > To: Wang, Elaine <elaine.wang@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Respect
> > num_pipes when install or reset display IRQ
> >
> > == Series Details ==
> >
> > Series: drm/i915: Respect num_pipes when install or reset display IRQ
> > URL : https://patchwork.freedesktop.org/series/17164/
> > State : warning
> >
> > == Summary ==
> >
> > Series 17164v1 drm/i915: Respect num_pipes when install or reset
> > display IRQ
> > https://patchwork.freedesktop.org/api/1.0/series/17164/revisions/1/mbo
> > x/
> >
> > Test kms_flip:
> > Subgroup basic-plain-flip:
> > pass -> DMESG-WARN (fi-snb-2520m)
> >
> > fi-bdw-5557u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
> > fi-bsw-n3050 total:246 pass:207 dwarn:0 dfail:0 fail:0 skip:39
> > fi-bxt-j4205 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
> > fi-bxt-t5700 total:82 pass:69 dwarn:0 dfail:0 fail:0 skip:12
> > fi-byt-j1900 total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:27
> > fi-byt-n2820 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31
> > fi-hsw-4770 total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19
> > fi-hsw-4770r total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19
> > fi-ivb-3520m total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
> > fi-ivb-3770 total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
> > fi-kbl-7500u total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
> > fi-skl-6260u total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13
> > fi-skl-6700hq total:246 pass:226 dwarn:0 dfail:0 fail:0 skip:20
> > fi-skl-6700k total:246 pass:222 dwarn:3 dfail:0 fail:0 skip:21
> > fi-skl-6770hq total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13
> > fi-snb-2520m total:246 pass:214 dwarn:1 dfail:0 fail:0 skip:31
> > fi-snb-2600 total:246 pass:214 dwarn:0 dfail:0 fail:0 skip:32
> >
> > 7165fdc7f0b0b536557fcd0a222d083a901be57c drm-tip: 2016y-12m-22d-19h-
> > 42m-25s UTC integration manifest
> > 2728153 drm/i915: Respect num_pipes when install or reset display IRQ
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3383/
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-23 9:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-23 6:06 [PATCH v4] drm/i915: Respect num_pipes when install or reset display IRQ Wang Elaine
2016-12-23 6:53 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-12-23 9:04 ` Wang, Elaine
2016-12-23 9:15 ` Saarinen, Jani
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.