All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf intel-pt: Fix estimated timestamps for cycle-accurate mode
Date: Wed, 5 Oct 2016 10:33:14 +0300	[thread overview]
Message-ID: <43aa0250-fe84-f70a-8995-04af72c584f9@intel.com> (raw)
In-Reply-To: <1475062896-22274-1-git-send-email-adrian.hunter@intel.com>

On 28/09/16 14:41, Adrian Hunter wrote:
> In cycle-accurate mode, timestamps can be calculated from CYC packets. The
> decoder also estimates timestamps based on the number of instructions since
> the last timestamp. For that to work in cycle-accurate mode, the
> instruction count needs to be reset to zero when a timestamp is calculated
> from a CYC packet, but that wasn't happening, so fix it.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Cc: stable@vger.kernel.org # v4.3+

Hi

These 2 patches are still outstanding when you have time.

Regards
Adrian

> ---
>  tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
> index 7591a0c37473..3d1d446f037f 100644
> --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
> +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
> @@ -1353,6 +1353,8 @@ static void intel_pt_calc_cyc_timestamp(struct intel_pt_decoder *decoder)
>  			     timestamp, decoder->timestamp);
>  	else
>  		decoder->timestamp = timestamp;
> +
> +	decoder->timestamp_insn_cnt = 0;
>  }
>  
>  /* Walk PSB+ packets when already in sync. */
> 

  parent reply	other threads:[~2016-10-05  7:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 11:41 [PATCH 1/2] perf intel-pt: Fix estimated timestamps for cycle-accurate mode Adrian Hunter
2016-09-28 11:41 ` [PATCH 2/2] perf intel-pt: Fix MTC timestamp calculation for large MTC periods Adrian Hunter
2016-10-06 22:40   ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2016-10-05  7:33 ` Adrian Hunter [this message]
2016-10-05 11:16   ` [PATCH 1/2] perf intel-pt: Fix estimated timestamps for cycle-accurate mode Arnaldo Carvalho de Melo
2016-10-06 22:40 ` [tip:perf/urgent] " tip-bot for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43aa0250-fe84-f70a-8995-04af72c584f9@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.