* [PATCH] kexec: Increase the upper limit for RAM segments
@ 2016-10-20 23:14 Sameer Goel
2016-10-21 17:05 ` Geoff Levand
0 siblings, 1 reply; 5+ messages in thread
From: Sameer Goel @ 2016-10-20 23:14 UTC (permalink / raw)
To: geoff; +Cc: Sameer Goel, kexec
Change the current hardcoded values to 64 from 16.
Signed-off-by: Sameer Goel <sgoel@codeaurora.org>
---
kexec/arch/arm64/kexec-arm64.h | 2 +-
kexec/kexec-syscall.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kexec/arch/arm64/kexec-arm64.h b/kexec/arch/arm64/kexec-arm64.h
index bac62f8..bd4c20e 100644
--- a/kexec/arch/arm64/kexec-arm64.h
+++ b/kexec/arch/arm64/kexec-arm64.h
@@ -11,7 +11,7 @@
#include "image-header.h"
#include "kexec.h"
-#define KEXEC_SEGMENT_MAX 16
+#define KEXEC_SEGMENT_MAX 64
#define BOOT_BLOCK_VERSION 17
#define BOOT_BLOCK_LAST_COMP_VERSION 16
diff --git a/kexec/kexec-syscall.h b/kexec/kexec-syscall.h
index c0d0bea..f84c937 100644
--- a/kexec/kexec-syscall.h
+++ b/kexec/kexec-syscall.h
@@ -115,7 +115,7 @@ static inline long kexec_file_load(int kernel_fd, int initrd_fd,
#define KEXEC_ARCH_MIPS ( 8 << 16)
#define KEXEC_ARCH_CRIS (76 << 16)
-#define KEXEC_MAX_SEGMENTS 16
+#define KEXEC_MAX_SEGMENTS 64
#ifdef __i386__
#define KEXEC_ARCH_NATIVE KEXEC_ARCH_386
--
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] kexec: Increase the upper limit for RAM segments
2016-10-20 23:14 [PATCH] kexec: Increase the upper limit for RAM segments Sameer Goel
@ 2016-10-21 17:05 ` Geoff Levand
2016-10-31 19:11 ` Goel, Sameer
0 siblings, 1 reply; 5+ messages in thread
From: Geoff Levand @ 2016-10-21 17:05 UTC (permalink / raw)
To: Sameer Goel; +Cc: kexec
Hi Sameer.
On 10/20/2016 04:14 PM, Sameer Goel wrote:
> Change the current hardcoded values to 64 from 16.
Please add an explanation of why this change is needed.
-Geoff
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kexec: Increase the upper limit for RAM segments
2016-10-21 17:05 ` Geoff Levand
@ 2016-10-31 19:11 ` Goel, Sameer
2016-11-01 1:37 ` Baoquan He
2016-11-01 19:24 ` Geoff Levand
0 siblings, 2 replies; 5+ messages in thread
From: Goel, Sameer @ 2016-10-31 19:11 UTC (permalink / raw)
To: Geoff Levand; +Cc: kexec
This change is needed in case when the System Ram listings are retrieved
from /proc/iomem. On a newer UEFI based Qualcomm system, the number of
regions listed were close to 34. So, the actual system ram region was
not covered and the kexec tool failed to load the kernel image.
So, I have requested an increase in the number of memory regions.
Thanks,
Sameer
On 10/21/2016 11:05 AM, Geoff Levand wrote:
> Hi Sameer.
>
> On 10/20/2016 04:14 PM, Sameer Goel wrote:
>> Change the current hardcoded values to 64 from 16.
>
> Please add an explanation of why this change is needed.
>
> -Geoff
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kexec: Increase the upper limit for RAM segments
2016-10-31 19:11 ` Goel, Sameer
@ 2016-11-01 1:37 ` Baoquan He
2016-11-01 19:24 ` Geoff Levand
1 sibling, 0 replies; 5+ messages in thread
From: Baoquan He @ 2016-11-01 1:37 UTC (permalink / raw)
To: Goel, Sameer; +Cc: Geoff Levand, kexec
On 10/31/16 at 01:11pm, Goel, Sameer wrote:
> This change is needed in case when the System Ram listings are retrieved
> from /proc/iomem. On a newer UEFI based Qualcomm system, the number of
> regions listed were close to 34. So, the actual system ram region was not
> covered and the kexec tool failed to load the kernel image.
>
> So, I have requested an increase in the number of memory regions.
> Thanks,
It would be great to add this to your patch log so that reviewers can
understand it better. Better repost with an updated patch log, copying
these as patch log is good enough.
> Sameer
>
> On 10/21/2016 11:05 AM, Geoff Levand wrote:
> > Hi Sameer.
> >
> > On 10/20/2016 04:14 PM, Sameer Goel wrote:
> > > Change the current hardcoded values to 64 from 16.
> >
> > Please add an explanation of why this change is needed.
> >
> > -Geoff
> >
> > _______________________________________________
> > kexec mailing list
> > kexec@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kexec
> >
>
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project.
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kexec: Increase the upper limit for RAM segments
2016-10-31 19:11 ` Goel, Sameer
2016-11-01 1:37 ` Baoquan He
@ 2016-11-01 19:24 ` Geoff Levand
1 sibling, 0 replies; 5+ messages in thread
From: Geoff Levand @ 2016-11-01 19:24 UTC (permalink / raw)
To: Goel, Sameer; +Cc: kexec
Hi Sameer,
On 10/31/2016 12:11 PM, Goel, Sameer wrote:
> This change is needed in case when the System Ram listings are retrieved from /proc/iomem. On a newer UEFI based Qualcomm system, the number of regions listed were close to 34. So, the actual system ram region was not covered and the kexec tool failed to load the kernel image.
>
> So, I have requested an increase in the number of memory regions.
> Thanks,
> Sameer
>
> On 10/21/2016 11:05 AM, Geoff Levand wrote:
>> Hi Sameer.
>>
>> On 10/20/2016 04:14 PM, Sameer Goel wrote:
>>> Change the current hardcoded values to 64 from 16.
>>
>> Please add an explanation of why this change is needed.
Sorry I wasn't clear. Please post a new patch, and
in the commit log include an explanation of why this
change is needed.
-Geoff
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-01 19:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-20 23:14 [PATCH] kexec: Increase the upper limit for RAM segments Sameer Goel
2016-10-21 17:05 ` Geoff Levand
2016-10-31 19:11 ` Goel, Sameer
2016-11-01 1:37 ` Baoquan He
2016-11-01 19:24 ` Geoff Levand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.