All of lore.kernel.org
 help / color / mirror / Atom feed
* pull request: wireless-next-2.6 2009-02-23
@ 2009-02-23 19:26 John W. Linville
  2009-02-24  6:31   ` Johannes Berg
  2009-02-27 20:40 ` John W. Linville
  0 siblings, 2 replies; 18+ messages in thread
From: John W. Linville @ 2009-02-23 19:26 UTC (permalink / raw)
  To: davem; +Cc: linux-wireless, netdev

Dave,

Here is a big batch of changes intended for 2.6.30.  They run the usual
gamut of wireless driver and mac80211 changes...

There is an ugly one from me.  It is a kluge but it prevents a crash on
my Lenovo T400.  I bisected the crash down to "mac80211: use cfg80211s
BSS infrastructure", which is already in net-next-2.6.  Still, if it is
too ugly then let me know and I'll reformulate without it.

Please let me know if there are problems!

Thanks,

John

---

Individual patches are available here:

	http://www.kernel.org/pub/linux/kernel/people/linville/wireless-next-2.6/

---

The following changes since commit ce16c5337ab0d165f95c88aa857207efd7c01139:
  Eric W. Biederman (1):
        netns: Remove net_alive

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6.git master

Bing Zhao (1):
      libertas: fix power save issue in libertas_sdio module

Bob Copeland (10):
      ath9k: remove write-only current_rd_inuse
      ath9k: save a few calls to ath9k_regd_get_eepromRD
      ath9k: convert isWwrSKU macro into C code
      ath9k: remove ath9k_regd_get_rd()
      ath9k: remove prototype for ath9k_regd_get_current_country
      ath9k: move common regulatory code out of if() branches
      ath5k: don't mask off interrupt bits
      ath5k: use spin_lock_irqsave for beacon lock
      ath5k: move beacon processing to a tasklet
      ath5k: compute rts/cts duration after computing full pktlen

Dan Williams (4):
      hostap: convert usage of net/ieee80211.h to linux/ieee80211.h
      make net/ieee80211.h private to ipw2x00
      cfg80211: age scan results on resume
      ipw2x00: age scan results on resume

Helmut Schaa (1):
      iwlagn: clean up error path in iwl_pci_probe

Ivo van Doorn (4):
      rt2x00: uncomment get_tsf
      rt2x00: Remove check for rf word 0
      rt2x00: Add various new USB IDs for rt73usb
      rt2x00: Fix RF offset

Jiri Slaby (1):
      ipw2200, fix ipw io functions

Johannes Berg (10):
      mac80211: disallow moving netns
      mac80211: fix aggregation for hardware with ampdu queues
      mac80211: split IBSS/managed code
      genetlink: introduce pre/post methods
      nl80211: lock rtnl around all operations
      cfg80211/mac80211: fill qual.qual value/adjust max_qual.qual
      mac80211: add missing kernel-doc
      nl80211: remove admin requirement from station get
      cfg80211: clean up signal type
      mac80211/cfg80211: move iwrange handler to cfg80211

John W. Linville (2):
      airo: correct improper initialization of local variable
      iwlagn: default to MAX_UCODE_BEACON_INTERVAL in iwl_adjust_beacon_interval

Jouni Malinen (2):
      nl80211: Optional IEs into scan request
      nl80211: Provide access to STA TX/RX packet counters

Randy Dunlap (1):
      wireless: fix for CONFIG_NL80211=n

Reinette Chatre (2):
      iwlwifi: use singlethread workqueue
      iwlwifi: Fix and rework Kconfig file

Roel Kluin (3):
      wavelan: Test arraysize before an element of the array.
      p54: misplaced parentheses
      b43: Fix LO calibration txctl reg value

Senthil Balasubramanian (1):
      ath9k: Add open loop control support

Sujith (16):
      ath9k: Store the correct max TX power level
      ath9k: Fix rd_ext EEPROM capability for AR9285
      ath9k: Enable Fractional N mode
      ath9k: Enable TSF Out of Range Interrupt
      ath9k: Initialize AGC calibration properly
      ath9k: Fix bug in disabling MIB counters
      ath9k: Fix incorrect noise floor reading for 4k EEPROM
      ath9k: Decrease minimum NF threshold
      mac80211: Extend the rate control API with an update callback
      ath9k: Program the RTC registers correctly
      ath9k: Fix HW wait timeout
      ath9k: Fix antenna assignment bug in TX status processing
      ath9k: Initialize channel change time
      ath9k: Remove a few unused capability macros
      ath9k: Remove ath_txq_depth and get the queue depth directly
      ath9k: Use beacon interval directly

Vasanthakumar Thiagarajan (2):
      mac80211: Make sure non-HT connection when IEEE80211_STA_TKIP_WEP_USED is set
      ath9k: Fix PTK/GTK handshake timeout

Wu, Fengguang (1):
      iwlwifi: report correct and detailed values about requested txpower

 drivers/net/wireless/airo.c                        |    3 +-
 drivers/net/wireless/ath5k/base.c                  |   84 +-
 drivers/net/wireless/ath5k/base.h                  |    1 +
 drivers/net/wireless/ath9k/ani.c                   |    7 +-
 drivers/net/wireless/ath9k/beacon.c                |    3 +
 drivers/net/wireless/ath9k/calib.c                 |   66 +-
 drivers/net/wireless/ath9k/calib.h                 |    2 +-
 drivers/net/wireless/ath9k/eeprom.c                |  234 +++-
 drivers/net/wireless/ath9k/eeprom.h                |   34 +-
 drivers/net/wireless/ath9k/hw.c                    |  106 +-
 drivers/net/wireless/ath9k/hw.h                    |   20 +-
 drivers/net/wireless/ath9k/mac.c                   |   30 +-
 drivers/net/wireless/ath9k/main.c                  |   36 +-
 drivers/net/wireless/ath9k/pci.c                   |    3 +-
 drivers/net/wireless/ath9k/phy.c                   |   19 +-
 drivers/net/wireless/ath9k/phy.h                   |   29 +
 drivers/net/wireless/ath9k/rc.c                    |    7 +-
 drivers/net/wireless/ath9k/recv.c                  |    1 -
 drivers/net/wireless/ath9k/reg.h                   |   12 +-
 drivers/net/wireless/ath9k/regd.c                  |   28 +-
 drivers/net/wireless/ath9k/regd.h                  |    9 -
 drivers/net/wireless/ath9k/xmit.c                  |   28 +-
 drivers/net/wireless/b43/lo.c                      |    2 +-
 drivers/net/wireless/hostap/hostap.h               |    2 +-
 drivers/net/wireless/hostap/hostap_80211.h         |    2 +-
 drivers/net/wireless/hostap/hostap_80211_rx.c      |   88 +-
 drivers/net/wireless/hostap/hostap_80211_tx.c      |   51 +-
 drivers/net/wireless/hostap/hostap_ap.c            |  138 +-
 drivers/net/wireless/hostap/hostap_ap.h            |    6 +-
 drivers/net/wireless/hostap/hostap_hw.c            |   24 +-
 drivers/net/wireless/hostap/hostap_info.c          |    1 +
 drivers/net/wireless/hostap/hostap_ioctl.c         |    1 +
 drivers/net/wireless/hostap/hostap_main.c          |   38 +-
 drivers/net/wireless/ipw2x00/Kconfig               |    2 +-
 .../net/wireless/ipw2x00}/ieee80211.h              |    3 +
 drivers/net/wireless/ipw2x00/ipw2100.c             |   12 +-
 drivers/net/wireless/ipw2x00/ipw2100.h             |    8 +-
 drivers/net/wireless/ipw2x00/ipw2200.c             |  116 +-
 drivers/net/wireless/ipw2x00/ipw2200.h             |    7 +-
 drivers/net/wireless/ipw2x00/libipw_geo.c          |    2 +-
 drivers/net/wireless/ipw2x00/libipw_module.c       |   17 +-
 drivers/net/wireless/ipw2x00/libipw_rx.c           |    5 +-
 drivers/net/wireless/ipw2x00/libipw_tx.c           |    2 +-
 drivers/net/wireless/ipw2x00/libipw_wx.c           |   27 +-
 drivers/net/wireless/iwlwifi/Kconfig               |   56 +-
 drivers/net/wireless/iwlwifi/Makefile              |    4 +-
 drivers/net/wireless/iwlwifi/iwl-agn.c             |   13 +-
 drivers/net/wireless/iwlwifi/iwl-core.c            |   10 +-
 drivers/net/wireless/iwlwifi/iwl-core.h            |    2 +-
 drivers/net/wireless/iwlwifi/iwl-dev.h             |    4 +-
 drivers/net/wireless/iwlwifi/iwl3945-base.c        |    2 +-
 drivers/net/wireless/libertas/defs.h               |    1 +
 drivers/net/wireless/libertas/if_sdio.c            |    6 +
 drivers/net/wireless/p54/p54common.c               |    4 +-
 drivers/net/wireless/rt2x00/rt2400pci.c            |    3 -
 drivers/net/wireless/rt2x00/rt2400pci.h            |    4 +-
 drivers/net/wireless/rt2x00/rt2500pci.c            |    3 -
 drivers/net/wireless/rt2x00/rt2500pci.h            |    4 +-
 drivers/net/wireless/rt2x00/rt2500usb.c            |    3 -
 drivers/net/wireless/rt2x00/rt2500usb.h            |    4 +-
 drivers/net/wireless/rt2x00/rt2x00debug.c          |   10 +-
 drivers/net/wireless/rt2x00/rt61pci.c              |    3 -
 drivers/net/wireless/rt2x00/rt61pci.h              |    4 +-
 drivers/net/wireless/rt2x00/rt73usb.c              |   19 +-
 drivers/net/wireless/rt2x00/rt73usb.h              |    4 +-
 drivers/net/wireless/wavelan.c                     |    3 +-
 include/linux/nl80211.h                            |    5 +
 include/net/cfg80211.h                             |   23 +-
 include/net/genetlink.h                            |   47 +-
 include/net/mac80211.h                             |   18 +-
 include/net/wireless.h                             |    3 +
 net/mac80211/Makefile                              |    1 +
 net/mac80211/agg-rx.c                              |    6 +-
 net/mac80211/agg-tx.c                              |  191 ++-
 net/mac80211/cfg.c                                 |   49 +-
 net/mac80211/debugfs_netdev.c                      |   48 +-
 net/mac80211/ht.c                                  |   19 +-
 net/mac80211/ibss.c                                |  888 +++++++++++
 net/mac80211/ieee80211_i.h                         |  138 ++-
 net/mac80211/iface.c                               |   77 +-
 net/mac80211/key.c                                 |    2 +-
 net/mac80211/main.c                                |   24 +-
 net/mac80211/mlme.c                                | 1648 +++++---------------
 net/mac80211/rate.h                                |   12 +
 net/mac80211/rx.c                                  |   37 +-
 net/mac80211/scan.c                                |   57 +-
 net/mac80211/spectmgmt.c                           |   26 +-
 net/mac80211/sta_info.c                            |   15 +-
 net/mac80211/sta_info.h                            |    5 +-
 net/mac80211/tx.c                                  |   29 +-
 net/mac80211/util.c                                |  254 +++-
 net/mac80211/wext.c                                |  262 ++--
 net/mac80211/wme.c                                 |  161 +--
 net/mac80211/wme.h                                 |    6 -
 net/netlink/genetlink.c                            |   19 +-
 net/wireless/core.h                                |    3 +
 net/wireless/nl80211.c                             |  124 +-
 net/wireless/nl80211.h                             |    4 +
 net/wireless/scan.c                                |   61 +-
 net/wireless/sysfs.c                               |    7 +
 net/wireless/wext-compat.c                         |   97 ++
 101 files changed, 3315 insertions(+), 2533 deletions(-)
 rename {include/net => drivers/net/wireless/ipw2x00}/ieee80211.h (99%)
 create mode 100644 net/mac80211/ibss.c

Omnibus patch is available here:

	http://www.kernel.org/pub/linux/kernel/people/linville/wireless-next-2.6-2009-02-23.patch.bz2

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-24  6:31   ` Johannes Berg
  0 siblings, 0 replies; 18+ messages in thread
From: Johannes Berg @ 2009-02-24  6:31 UTC (permalink / raw)
  To: John W. Linville; +Cc: davem, linux-wireless, netdev

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

On Mon, 2009-02-23 at 14:26 -0500, John W. Linville wrote:

> Johannes Berg (10):
>       mac80211: disallow moving netns
>       mac80211: fix aggregation for hardware with ampdu queues
>       mac80211: split IBSS/managed code
>       genetlink: introduce pre/post methods

Hold off on this please, the genetlink patch here introduced a problem
with locking and I'm going to rework/fix that.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-24  6:31   ` Johannes Berg
  0 siblings, 0 replies; 18+ messages in thread
From: Johannes Berg @ 2009-02-24  6:31 UTC (permalink / raw)
  To: John W. Linville
  Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

On Mon, 2009-02-23 at 14:26 -0500, John W. Linville wrote:

> Johannes Berg (10):
>       mac80211: disallow moving netns
>       mac80211: fix aggregation for hardware with ampdu queues
>       mac80211: split IBSS/managed code
>       genetlink: introduce pre/post methods

Hold off on this please, the genetlink patch here introduced a problem
with locking and I'm going to rework/fix that.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
  2009-02-24  6:31   ` Johannes Berg
  (?)
@ 2009-02-25  7:55   ` David Miller
  2009-02-26  8:36       ` Johannes Berg
  -1 siblings, 1 reply; 18+ messages in thread
From: David Miller @ 2009-02-25  7:55 UTC (permalink / raw)
  To: johannes; +Cc: linville, linux-wireless, netdev

From: Johannes Berg <johannes@sipsolutions.net>
Date: Mon, 23 Feb 2009 22:31:53 -0800

> On Mon, 2009-02-23 at 14:26 -0500, John W. Linville wrote:
> 
> > Johannes Berg (10):
> >       mac80211: disallow moving netns
> >       mac80211: fix aggregation for hardware with ampdu queues
> >       mac80211: split IBSS/managed code
> >       genetlink: introduce pre/post methods
> 
> Hold off on this please, the genetlink patch here introduced a problem
> with locking and I'm going to rework/fix that.

Ok.

In fact it's better this way, since now John can send me the pull
request after the net-2.6 --> net-next-2.6 merge conflicts are
resolved.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-26  8:36       ` Johannes Berg
  0 siblings, 0 replies; 18+ messages in thread
From: Johannes Berg @ 2009-02-26  8:36 UTC (permalink / raw)
  To: David Miller; +Cc: linville, linux-wireless, netdev

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

On Tue, 2009-02-24 at 23:55 -0800, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Mon, 23 Feb 2009 22:31:53 -0800
> 
> > On Mon, 2009-02-23 at 14:26 -0500, John W. Linville wrote:
> > 
> > > Johannes Berg (10):
> > >       mac80211: disallow moving netns
> > >       mac80211: fix aggregation for hardware with ampdu queues
> > >       mac80211: split IBSS/managed code
> > >       genetlink: introduce pre/post methods
> > 
> > Hold off on this please, the genetlink patch here introduced a problem
> > with locking and I'm going to rework/fix that.
> 
> Ok.
> 
> In fact it's better this way, since now John can send me the pull
> request after the net-2.6 --> net-next-2.6 merge conflicts are
> resolved.

Now I just have to get around to fixing it, it's proving to be harder
than I thought, and I don't have much time right now.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-26  8:36       ` Johannes Berg
  0 siblings, 0 replies; 18+ messages in thread
From: Johannes Berg @ 2009-02-26  8:36 UTC (permalink / raw)
  To: David Miller
  Cc: linville-2XuSBdqkA4R54TAoqtyWWQ,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On Tue, 2009-02-24 at 23:55 -0800, David Miller wrote:
> From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
> Date: Mon, 23 Feb 2009 22:31:53 -0800
> 
> > On Mon, 2009-02-23 at 14:26 -0500, John W. Linville wrote:
> > 
> > > Johannes Berg (10):
> > >       mac80211: disallow moving netns
> > >       mac80211: fix aggregation for hardware with ampdu queues
> > >       mac80211: split IBSS/managed code
> > >       genetlink: introduce pre/post methods
> > 
> > Hold off on this please, the genetlink patch here introduced a problem
> > with locking and I'm going to rework/fix that.
> 
> Ok.
> 
> In fact it's better this way, since now John can send me the pull
> request after the net-2.6 --> net-next-2.6 merge conflicts are
> resolved.

Now I just have to get around to fixing it, it's proving to be harder
than I thought, and I don't have much time right now.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-26 16:13         ` John W. Linville
  0 siblings, 0 replies; 18+ messages in thread
From: John W. Linville @ 2009-02-26 16:13 UTC (permalink / raw)
  To: Johannes Berg; +Cc: David Miller, linux-wireless, netdev

On Thu, Feb 26, 2009 at 12:36:00AM -0800, Johannes Berg wrote:
> On Tue, 2009-02-24 at 23:55 -0800, David Miller wrote:
> > From: Johannes Berg <johannes@sipsolutions.net>
> > Date: Mon, 23 Feb 2009 22:31:53 -0800
> > 
> > > On Mon, 2009-02-23 at 14:26 -0500, John W. Linville wrote:
> > > 
> > > > Johannes Berg (10):
> > > >       mac80211: disallow moving netns
> > > >       mac80211: fix aggregation for hardware with ampdu queues
> > > >       mac80211: split IBSS/managed code
> > > >       genetlink: introduce pre/post methods
> > > 
> > > Hold off on this please, the genetlink patch here introduced a problem
> > > with locking and I'm going to rework/fix that.
> > 
> > Ok.
> > 
> > In fact it's better this way, since now John can send me the pull
> > request after the net-2.6 --> net-next-2.6 merge conflicts are
> > resolved.
> 
> Now I just have to get around to fixing it, it's proving to be harder
> than I thought, and I don't have much time right now.

I suppose I could just drop that one.  IIRC there was another patch
from you that depended upon that one as well?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-26 16:13         ` John W. Linville
  0 siblings, 0 replies; 18+ messages in thread
From: John W. Linville @ 2009-02-26 16:13 UTC (permalink / raw)
  To: Johannes Berg
  Cc: David Miller, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA

On Thu, Feb 26, 2009 at 12:36:00AM -0800, Johannes Berg wrote:
> On Tue, 2009-02-24 at 23:55 -0800, David Miller wrote:
> > From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
> > Date: Mon, 23 Feb 2009 22:31:53 -0800
> > 
> > > On Mon, 2009-02-23 at 14:26 -0500, John W. Linville wrote:
> > > 
> > > > Johannes Berg (10):
> > > >       mac80211: disallow moving netns
> > > >       mac80211: fix aggregation for hardware with ampdu queues
> > > >       mac80211: split IBSS/managed code
> > > >       genetlink: introduce pre/post methods
> > > 
> > > Hold off on this please, the genetlink patch here introduced a problem
> > > with locking and I'm going to rework/fix that.
> > 
> > Ok.
> > 
> > In fact it's better this way, since now John can send me the pull
> > request after the net-2.6 --> net-next-2.6 merge conflicts are
> > resolved.
> 
> Now I just have to get around to fixing it, it's proving to be harder
> than I thought, and I don't have much time right now.

I suppose I could just drop that one.  IIRC there was another patch
from you that depended upon that one as well?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-26 16:47           ` Johannes Berg
  0 siblings, 0 replies; 18+ messages in thread
From: Johannes Berg @ 2009-02-26 16:47 UTC (permalink / raw)
  To: John W. Linville; +Cc: David Miller, linux-wireless, netdev

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On Thu, 2009-02-26 at 11:13 -0500, John W. Linville wrote:

> > Now I just have to get around to fixing it, it's proving to be harder
> > than I thought, and I don't have much time right now.
> 
> I suppose I could just drop that one.  IIRC there was another patch
> from you that depended upon that one as well?

Yes, that's true, but then we'll be back at the wext vs. nl80211
deadlock problem...

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-26 16:47           ` Johannes Berg
  0 siblings, 0 replies; 18+ messages in thread
From: Johannes Berg @ 2009-02-26 16:47 UTC (permalink / raw)
  To: John W. Linville
  Cc: David Miller, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On Thu, 2009-02-26 at 11:13 -0500, John W. Linville wrote:

> > Now I just have to get around to fixing it, it's proving to be harder
> > than I thought, and I don't have much time right now.
> 
> I suppose I could just drop that one.  IIRC there was another patch
> from you that depended upon that one as well?

Yes, that's true, but then we'll be back at the wext vs. nl80211
deadlock problem...

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-27  1:37           ` Johannes Berg
  0 siblings, 0 replies; 18+ messages in thread
From: Johannes Berg @ 2009-02-27  1:37 UTC (permalink / raw)
  To: John W. Linville; +Cc: David Miller, linux-wireless, netdev, mcgrof

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

On Thu, 2009-02-26 at 11:13 -0500, John W. Linville wrote:

> > Now I just have to get around to fixing it, it's proving to be harder
> > than I thought, and I don't have much time right now.
> 
> I suppose I could just drop that one.  IIRC there was another patch
> from you that depended upon that one as well?

Ok, so I looked into this, and it turns out that it's harder to fix than
I thought. Fixing the genl code to call the pre_dumpit at the right
place is hard and requires netlink (not genl) changes. I'm not in a
position to do such changes right now, so I would suggest to revert it,
and for now take the easy way of restructuring nl80211 to take, in each
operation, the rtnl before any other locks instead of trying to do this
generically.

Luis, would you be up to that? Basically go from

        mutex_lock(&cfg80211_mtx)
        ...
        rtnl_lock()
        ...
        rtnl_unlock()
        ...
        mutex_unlock(&cfg80211_mtx)
        
to
        
        rtnl_lock()
        ...
        mutex_lock(&cfg80211_mtx)
        ...
        mutex_unlock(&cfg80211_mtx)
        ...
        rtnl_unlock()
        
everywhere.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-27  1:37           ` Johannes Berg
  0 siblings, 0 replies; 18+ messages in thread
From: Johannes Berg @ 2009-02-27  1:37 UTC (permalink / raw)
  To: John W. Linville
  Cc: David Miller, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA, mcgrof

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

On Thu, 2009-02-26 at 11:13 -0500, John W. Linville wrote:

> > Now I just have to get around to fixing it, it's proving to be harder
> > than I thought, and I don't have much time right now.
> 
> I suppose I could just drop that one.  IIRC there was another patch
> from you that depended upon that one as well?

Ok, so I looked into this, and it turns out that it's harder to fix than
I thought. Fixing the genl code to call the pre_dumpit at the right
place is hard and requires netlink (not genl) changes. I'm not in a
position to do such changes right now, so I would suggest to revert it,
and for now take the easy way of restructuring nl80211 to take, in each
operation, the rtnl before any other locks instead of trying to do this
generically.

Luis, would you be up to that? Basically go from

        mutex_lock(&cfg80211_mtx)
        ...
        rtnl_lock()
        ...
        rtnl_unlock()
        ...
        mutex_unlock(&cfg80211_mtx)
        
to
        
        rtnl_lock()
        ...
        mutex_lock(&cfg80211_mtx)
        ...
        mutex_unlock(&cfg80211_mtx)
        ...
        rtnl_unlock()
        
everywhere.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-27  3:18             ` Luis R. Rodriguez
  0 siblings, 0 replies; 18+ messages in thread
From: Luis R. Rodriguez @ 2009-02-27  3:18 UTC (permalink / raw)
  To: Johannes Berg; +Cc: John W. Linville, David Miller, linux-wireless, netdev

On Thu, Feb 26, 2009 at 5:37 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Thu, 2009-02-26 at 11:13 -0500, John W. Linville wrote:
>
>> > Now I just have to get around to fixing it, it's proving to be har=
der
>> > than I thought, and I don't have much time right now.
>>
>> I suppose I could just drop that one. =C2=A0IIRC there was another p=
atch
>> from you that depended upon that one as well?
>
> Ok, so I looked into this, and it turns out that it's harder to fix t=
han
> I thought. Fixing the genl code to call the pre_dumpit at the right
> place is hard and requires netlink (not genl) changes. I'm not in a
> position to do such changes right now, so I would suggest to revert i=
t,
> and for now take the easy way of restructuring nl80211 to take, in ea=
ch
> operation, the rtnl before any other locks instead of trying to do th=
is
> generically.
>
> Luis, would you be up to that? Basically go from
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0mutex_lock(&cfg80211_mtx)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0...
> =C2=A0 =C2=A0 =C2=A0 =C2=A0rtnl_lock()
> =C2=A0 =C2=A0 =C2=A0 =C2=A0...
> =C2=A0 =C2=A0 =C2=A0 =C2=A0rtnl_unlock()
> =C2=A0 =C2=A0 =C2=A0 =C2=A0...
> =C2=A0 =C2=A0 =C2=A0 =C2=A0mutex_unlock(&cfg80211_mtx)
>
> to
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0rtnl_lock()
> =C2=A0 =C2=A0 =C2=A0 =C2=A0...
> =C2=A0 =C2=A0 =C2=A0 =C2=A0mutex_lock(&cfg80211_mtx)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0...
> =C2=A0 =C2=A0 =C2=A0 =C2=A0mutex_unlock(&cfg80211_mtx)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0...
> =C2=A0 =C2=A0 =C2=A0 =C2=A0rtnl_unlock()
>
> everywhere.

Sure, I'll give it a shot tomorrow unless someone else gets to it first=
=2E

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-02-27  3:18             ` Luis R. Rodriguez
  0 siblings, 0 replies; 18+ messages in thread
From: Luis R. Rodriguez @ 2009-02-27  3:18 UTC (permalink / raw)
  To: Johannes Berg
  Cc: John W. Linville, David Miller,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA

On Thu, Feb 26, 2009 at 5:37 PM, Johannes Berg
<johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> On Thu, 2009-02-26 at 11:13 -0500, John W. Linville wrote:
>
>> > Now I just have to get around to fixing it, it's proving to be harder
>> > than I thought, and I don't have much time right now.
>>
>> I suppose I could just drop that one.  IIRC there was another patch
>> from you that depended upon that one as well?
>
> Ok, so I looked into this, and it turns out that it's harder to fix than
> I thought. Fixing the genl code to call the pre_dumpit at the right
> place is hard and requires netlink (not genl) changes. I'm not in a
> position to do such changes right now, so I would suggest to revert it,
> and for now take the easy way of restructuring nl80211 to take, in each
> operation, the rtnl before any other locks instead of trying to do this
> generically.
>
> Luis, would you be up to that? Basically go from
>
>        mutex_lock(&cfg80211_mtx)
>        ...
>        rtnl_lock()
>        ...
>        rtnl_unlock()
>        ...
>        mutex_unlock(&cfg80211_mtx)
>
> to
>
>        rtnl_lock()
>        ...
>        mutex_lock(&cfg80211_mtx)
>        ...
>        mutex_unlock(&cfg80211_mtx)
>        ...
>        rtnl_unlock()
>
> everywhere.

Sure, I'll give it a shot tomorrow unless someone else gets to it first.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
  2009-02-23 19:26 pull request: wireless-next-2.6 2009-02-23 John W. Linville
  2009-02-24  6:31   ` Johannes Berg
@ 2009-02-27 20:40 ` John W. Linville
  1 sibling, 0 replies; 18+ messages in thread
From: John W. Linville @ 2009-02-27 20:40 UTC (permalink / raw)
  To: davem; +Cc: linux-wireless, netdev

Consider this withdrawn.  I'm sending a new request momentarily.

John

On Mon, Feb 23, 2009 at 02:26:59PM -0500, John W. Linville wrote:
> Dave,
> 
> Here is a big batch of changes intended for 2.6.30.  They run the usual
> gamut of wireless driver and mac80211 changes...
> 
> There is an ugly one from me.  It is a kluge but it prevents a crash on
> my Lenovo T400.  I bisected the crash down to "mac80211: use cfg80211s
> BSS infrastructure", which is already in net-next-2.6.  Still, if it is
> too ugly then let me know and I'll reformulate without it.
> 
> Please let me know if there are problems!
> 
> Thanks,
> 
> John
> 
> ---
> 
> Individual patches are available here:
> 
> 	http://www.kernel.org/pub/linux/kernel/people/linville/wireless-next-2.6/
> 
> ---
> 
> The following changes since commit ce16c5337ab0d165f95c88aa857207efd7c01139:
>   Eric W. Biederman (1):
>         netns: Remove net_alive
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6.git master
> 
> Bing Zhao (1):
>       libertas: fix power save issue in libertas_sdio module
> 
> Bob Copeland (10):
>       ath9k: remove write-only current_rd_inuse
>       ath9k: save a few calls to ath9k_regd_get_eepromRD
>       ath9k: convert isWwrSKU macro into C code
>       ath9k: remove ath9k_regd_get_rd()
>       ath9k: remove prototype for ath9k_regd_get_current_country
>       ath9k: move common regulatory code out of if() branches
>       ath5k: don't mask off interrupt bits
>       ath5k: use spin_lock_irqsave for beacon lock
>       ath5k: move beacon processing to a tasklet
>       ath5k: compute rts/cts duration after computing full pktlen
> 
> Dan Williams (4):
>       hostap: convert usage of net/ieee80211.h to linux/ieee80211.h
>       make net/ieee80211.h private to ipw2x00
>       cfg80211: age scan results on resume
>       ipw2x00: age scan results on resume
> 
> Helmut Schaa (1):
>       iwlagn: clean up error path in iwl_pci_probe
> 
> Ivo van Doorn (4):
>       rt2x00: uncomment get_tsf
>       rt2x00: Remove check for rf word 0
>       rt2x00: Add various new USB IDs for rt73usb
>       rt2x00: Fix RF offset
> 
> Jiri Slaby (1):
>       ipw2200, fix ipw io functions
> 
> Johannes Berg (10):
>       mac80211: disallow moving netns
>       mac80211: fix aggregation for hardware with ampdu queues
>       mac80211: split IBSS/managed code
>       genetlink: introduce pre/post methods
>       nl80211: lock rtnl around all operations
>       cfg80211/mac80211: fill qual.qual value/adjust max_qual.qual
>       mac80211: add missing kernel-doc
>       nl80211: remove admin requirement from station get
>       cfg80211: clean up signal type
>       mac80211/cfg80211: move iwrange handler to cfg80211
> 
> John W. Linville (2):
>       airo: correct improper initialization of local variable
>       iwlagn: default to MAX_UCODE_BEACON_INTERVAL in iwl_adjust_beacon_interval
> 
> Jouni Malinen (2):
>       nl80211: Optional IEs into scan request
>       nl80211: Provide access to STA TX/RX packet counters
> 
> Randy Dunlap (1):
>       wireless: fix for CONFIG_NL80211=n
> 
> Reinette Chatre (2):
>       iwlwifi: use singlethread workqueue
>       iwlwifi: Fix and rework Kconfig file
> 
> Roel Kluin (3):
>       wavelan: Test arraysize before an element of the array.
>       p54: misplaced parentheses
>       b43: Fix LO calibration txctl reg value
> 
> Senthil Balasubramanian (1):
>       ath9k: Add open loop control support
> 
> Sujith (16):
>       ath9k: Store the correct max TX power level
>       ath9k: Fix rd_ext EEPROM capability for AR9285
>       ath9k: Enable Fractional N mode
>       ath9k: Enable TSF Out of Range Interrupt
>       ath9k: Initialize AGC calibration properly
>       ath9k: Fix bug in disabling MIB counters
>       ath9k: Fix incorrect noise floor reading for 4k EEPROM
>       ath9k: Decrease minimum NF threshold
>       mac80211: Extend the rate control API with an update callback
>       ath9k: Program the RTC registers correctly
>       ath9k: Fix HW wait timeout
>       ath9k: Fix antenna assignment bug in TX status processing
>       ath9k: Initialize channel change time
>       ath9k: Remove a few unused capability macros
>       ath9k: Remove ath_txq_depth and get the queue depth directly
>       ath9k: Use beacon interval directly
> 
> Vasanthakumar Thiagarajan (2):
>       mac80211: Make sure non-HT connection when IEEE80211_STA_TKIP_WEP_USED is set
>       ath9k: Fix PTK/GTK handshake timeout
> 
> Wu, Fengguang (1):
>       iwlwifi: report correct and detailed values about requested txpower
> 
>  drivers/net/wireless/airo.c                        |    3 +-
>  drivers/net/wireless/ath5k/base.c                  |   84 +-
>  drivers/net/wireless/ath5k/base.h                  |    1 +
>  drivers/net/wireless/ath9k/ani.c                   |    7 +-
>  drivers/net/wireless/ath9k/beacon.c                |    3 +
>  drivers/net/wireless/ath9k/calib.c                 |   66 +-
>  drivers/net/wireless/ath9k/calib.h                 |    2 +-
>  drivers/net/wireless/ath9k/eeprom.c                |  234 +++-
>  drivers/net/wireless/ath9k/eeprom.h                |   34 +-
>  drivers/net/wireless/ath9k/hw.c                    |  106 +-
>  drivers/net/wireless/ath9k/hw.h                    |   20 +-
>  drivers/net/wireless/ath9k/mac.c                   |   30 +-
>  drivers/net/wireless/ath9k/main.c                  |   36 +-
>  drivers/net/wireless/ath9k/pci.c                   |    3 +-
>  drivers/net/wireless/ath9k/phy.c                   |   19 +-
>  drivers/net/wireless/ath9k/phy.h                   |   29 +
>  drivers/net/wireless/ath9k/rc.c                    |    7 +-
>  drivers/net/wireless/ath9k/recv.c                  |    1 -
>  drivers/net/wireless/ath9k/reg.h                   |   12 +-
>  drivers/net/wireless/ath9k/regd.c                  |   28 +-
>  drivers/net/wireless/ath9k/regd.h                  |    9 -
>  drivers/net/wireless/ath9k/xmit.c                  |   28 +-
>  drivers/net/wireless/b43/lo.c                      |    2 +-
>  drivers/net/wireless/hostap/hostap.h               |    2 +-
>  drivers/net/wireless/hostap/hostap_80211.h         |    2 +-
>  drivers/net/wireless/hostap/hostap_80211_rx.c      |   88 +-
>  drivers/net/wireless/hostap/hostap_80211_tx.c      |   51 +-
>  drivers/net/wireless/hostap/hostap_ap.c            |  138 +-
>  drivers/net/wireless/hostap/hostap_ap.h            |    6 +-
>  drivers/net/wireless/hostap/hostap_hw.c            |   24 +-
>  drivers/net/wireless/hostap/hostap_info.c          |    1 +
>  drivers/net/wireless/hostap/hostap_ioctl.c         |    1 +
>  drivers/net/wireless/hostap/hostap_main.c          |   38 +-
>  drivers/net/wireless/ipw2x00/Kconfig               |    2 +-
>  .../net/wireless/ipw2x00}/ieee80211.h              |    3 +
>  drivers/net/wireless/ipw2x00/ipw2100.c             |   12 +-
>  drivers/net/wireless/ipw2x00/ipw2100.h             |    8 +-
>  drivers/net/wireless/ipw2x00/ipw2200.c             |  116 +-
>  drivers/net/wireless/ipw2x00/ipw2200.h             |    7 +-
>  drivers/net/wireless/ipw2x00/libipw_geo.c          |    2 +-
>  drivers/net/wireless/ipw2x00/libipw_module.c       |   17 +-
>  drivers/net/wireless/ipw2x00/libipw_rx.c           |    5 +-
>  drivers/net/wireless/ipw2x00/libipw_tx.c           |    2 +-
>  drivers/net/wireless/ipw2x00/libipw_wx.c           |   27 +-
>  drivers/net/wireless/iwlwifi/Kconfig               |   56 +-
>  drivers/net/wireless/iwlwifi/Makefile              |    4 +-
>  drivers/net/wireless/iwlwifi/iwl-agn.c             |   13 +-
>  drivers/net/wireless/iwlwifi/iwl-core.c            |   10 +-
>  drivers/net/wireless/iwlwifi/iwl-core.h            |    2 +-
>  drivers/net/wireless/iwlwifi/iwl-dev.h             |    4 +-
>  drivers/net/wireless/iwlwifi/iwl3945-base.c        |    2 +-
>  drivers/net/wireless/libertas/defs.h               |    1 +
>  drivers/net/wireless/libertas/if_sdio.c            |    6 +
>  drivers/net/wireless/p54/p54common.c               |    4 +-
>  drivers/net/wireless/rt2x00/rt2400pci.c            |    3 -
>  drivers/net/wireless/rt2x00/rt2400pci.h            |    4 +-
>  drivers/net/wireless/rt2x00/rt2500pci.c            |    3 -
>  drivers/net/wireless/rt2x00/rt2500pci.h            |    4 +-
>  drivers/net/wireless/rt2x00/rt2500usb.c            |    3 -
>  drivers/net/wireless/rt2x00/rt2500usb.h            |    4 +-
>  drivers/net/wireless/rt2x00/rt2x00debug.c          |   10 +-
>  drivers/net/wireless/rt2x00/rt61pci.c              |    3 -
>  drivers/net/wireless/rt2x00/rt61pci.h              |    4 +-
>  drivers/net/wireless/rt2x00/rt73usb.c              |   19 +-
>  drivers/net/wireless/rt2x00/rt73usb.h              |    4 +-
>  drivers/net/wireless/wavelan.c                     |    3 +-
>  include/linux/nl80211.h                            |    5 +
>  include/net/cfg80211.h                             |   23 +-
>  include/net/genetlink.h                            |   47 +-
>  include/net/mac80211.h                             |   18 +-
>  include/net/wireless.h                             |    3 +
>  net/mac80211/Makefile                              |    1 +
>  net/mac80211/agg-rx.c                              |    6 +-
>  net/mac80211/agg-tx.c                              |  191 ++-
>  net/mac80211/cfg.c                                 |   49 +-
>  net/mac80211/debugfs_netdev.c                      |   48 +-
>  net/mac80211/ht.c                                  |   19 +-
>  net/mac80211/ibss.c                                |  888 +++++++++++
>  net/mac80211/ieee80211_i.h                         |  138 ++-
>  net/mac80211/iface.c                               |   77 +-
>  net/mac80211/key.c                                 |    2 +-
>  net/mac80211/main.c                                |   24 +-
>  net/mac80211/mlme.c                                | 1648 +++++---------------
>  net/mac80211/rate.h                                |   12 +
>  net/mac80211/rx.c                                  |   37 +-
>  net/mac80211/scan.c                                |   57 +-
>  net/mac80211/spectmgmt.c                           |   26 +-
>  net/mac80211/sta_info.c                            |   15 +-
>  net/mac80211/sta_info.h                            |    5 +-
>  net/mac80211/tx.c                                  |   29 +-
>  net/mac80211/util.c                                |  254 +++-
>  net/mac80211/wext.c                                |  262 ++--
>  net/mac80211/wme.c                                 |  161 +--
>  net/mac80211/wme.h                                 |    6 -
>  net/netlink/genetlink.c                            |   19 +-
>  net/wireless/core.h                                |    3 +
>  net/wireless/nl80211.c                             |  124 +-
>  net/wireless/nl80211.h                             |    4 +
>  net/wireless/scan.c                                |   61 +-
>  net/wireless/sysfs.c                               |    7 +
>  net/wireless/wext-compat.c                         |   97 ++
>  101 files changed, 3315 insertions(+), 2533 deletions(-)
>  rename {include/net => drivers/net/wireless/ipw2x00}/ieee80211.h (99%)
>  create mode 100644 net/mac80211/ibss.c
> 
> Omnibus patch is available here:
> 
> 	http://www.kernel.org/pub/linux/kernel/people/linville/wireless-next-2.6-2009-02-23.patch.bz2
> 
> -- 
> John W. Linville		Someday the world will need a hero, and you
> linville@tuxdriver.com			might be all we have.  Be ready.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
  2009-02-27  3:18             ` Luis R. Rodriguez
  (?)
@ 2009-03-11 11:49             ` Johannes Berg
  2009-03-11 16:27                 ` Luis R. Rodriguez
  -1 siblings, 1 reply; 18+ messages in thread
From: Johannes Berg @ 2009-03-11 11:49 UTC (permalink / raw)
  To: Luis R. Rodriguez; +Cc: John W. Linville, David Miller, linux-wireless, netdev

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

On Thu, 2009-02-26 at 19:18 -0800, Luis R. Rodriguez wrote:

> >        mutex_lock(&cfg80211_mtx)
> >        ...
> >        rtnl_lock()
> >        ...
> >        rtnl_unlock()
> >        ...
> >        mutex_unlock(&cfg80211_mtx)
> >
> > to
> >
> >        rtnl_lock()
> >        ...
> >        mutex_lock(&cfg80211_mtx)
> >        ...
> >        mutex_unlock(&cfg80211_mtx)
> >        ...
> >        rtnl_unlock()
> >
> > everywhere.
> 
> Sure, I'll give it a shot tomorrow unless someone else gets to it first.

Did you get a chance to look at this? Otherwise I'll just do it later
today.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-03-11 16:27                 ` Luis R. Rodriguez
  0 siblings, 0 replies; 18+ messages in thread
From: Luis R. Rodriguez @ 2009-03-11 16:27 UTC (permalink / raw)
  To: Johannes Berg; +Cc: John W. Linville, David Miller, linux-wireless, netdev

On Wed, Mar 11, 2009 at 4:49 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Thu, 2009-02-26 at 19:18 -0800, Luis R. Rodriguez wrote:
>
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0mutex_lock(&cfg80211_mtx)
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0...
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0rtnl_lock()
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0...
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0rtnl_unlock()
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0...
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0mutex_unlock(&cfg80211_mtx)
>> >
>> > to
>> >
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0rtnl_lock()
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0...
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0mutex_lock(&cfg80211_mtx)
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0...
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0mutex_unlock(&cfg80211_mtx)
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0...
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0rtnl_unlock()
>> >
>> > everywhere.
>>
>> Sure, I'll give it a shot tomorrow unless someone else gets to it fi=
rst.
>
> Did you get a chance to look at this? Otherwise I'll just do it later
> today.

Unfortunately not, please do.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: pull request: wireless-next-2.6 2009-02-23
@ 2009-03-11 16:27                 ` Luis R. Rodriguez
  0 siblings, 0 replies; 18+ messages in thread
From: Luis R. Rodriguez @ 2009-03-11 16:27 UTC (permalink / raw)
  To: Johannes Berg
  Cc: John W. Linville, David Miller,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA

On Wed, Mar 11, 2009 at 4:49 AM, Johannes Berg
<johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> On Thu, 2009-02-26 at 19:18 -0800, Luis R. Rodriguez wrote:
>
>> >        mutex_lock(&cfg80211_mtx)
>> >        ...
>> >        rtnl_lock()
>> >        ...
>> >        rtnl_unlock()
>> >        ...
>> >        mutex_unlock(&cfg80211_mtx)
>> >
>> > to
>> >
>> >        rtnl_lock()
>> >        ...
>> >        mutex_lock(&cfg80211_mtx)
>> >        ...
>> >        mutex_unlock(&cfg80211_mtx)
>> >        ...
>> >        rtnl_unlock()
>> >
>> > everywhere.
>>
>> Sure, I'll give it a shot tomorrow unless someone else gets to it first.
>
> Did you get a chance to look at this? Otherwise I'll just do it later
> today.

Unfortunately not, please do.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2009-03-11 16:27 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-23 19:26 pull request: wireless-next-2.6 2009-02-23 John W. Linville
2009-02-24  6:31 ` Johannes Berg
2009-02-24  6:31   ` Johannes Berg
2009-02-25  7:55   ` David Miller
2009-02-26  8:36     ` Johannes Berg
2009-02-26  8:36       ` Johannes Berg
2009-02-26 16:13       ` John W. Linville
2009-02-26 16:13         ` John W. Linville
2009-02-26 16:47         ` Johannes Berg
2009-02-26 16:47           ` Johannes Berg
2009-02-27  1:37         ` Johannes Berg
2009-02-27  1:37           ` Johannes Berg
2009-02-27  3:18           ` Luis R. Rodriguez
2009-02-27  3:18             ` Luis R. Rodriguez
2009-03-11 11:49             ` Johannes Berg
2009-03-11 16:27               ` Luis R. Rodriguez
2009-03-11 16:27                 ` Luis R. Rodriguez
2009-02-27 20:40 ` John W. Linville

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.