From: "Drew Moseley" <drew.moseley@gmail.com>
To: raj.khem@gmail.com, ch@denx.de
Cc: dragos.panait@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] rng-tools: Change "Requires" to "WantedBy" for dev-hwrng.device
Date: Mon, 15 Aug 2022 14:29:58 -0400 [thread overview]
Message-ID: <43f17af6-eb16-efd3-ce23-374ea6791c52@gmail.com> (raw)
In-Reply-To: <20220815182503.2007534-1-drew@moseleynet.net>
Hi Khem,
It looks like you recently removed both the dependency on hwrng and
systemd-udev-settle. Do you think this change will be useful?
Claudius, any thoughts here?
Drew
On 8/15/22 2:25 PM, drew.moseley@gmail.com wrote:
> From: Drew Moseley <drew@moseleynet.net>
>
> The previous change to remove the dependency on systemd-udev-settle
> caused boot delays at least on qemu. It seems that change required
> a hwrng device but that's not necessarily available on all platforms.
>
> This changes the "Requires" to a "WantedBy" as modeled after the
> version of this file on Ubuntu 20.04.
>
> Signed-off-by: Drew Moseley <drew@moseleynet.net>
> ---
> meta/recipes-support/rng-tools/rng-tools/rng-tools.service | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> index 0f50890dcb..b013d95932 100644
> --- a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> +++ b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> @@ -3,8 +3,6 @@ Description=Hardware RNG Entropy Gatherer Daemon
> DefaultDependencies=no
> After=systemd-udev-settle.service
> Before=sysinit.target shutdown.target
> -Requires=dev-hwrng.device
> -After=dev-hwrng.device
> Conflicts=shutdown.target
>
> [Service]
> @@ -32,3 +30,4 @@ SystemCallFilter=@system-service
>
> [Install]
> WantedBy=sysinit.target
> +WantedBy=dev-hwrng.device
--
mailto:drew@moseleynet.net
next prev parent reply other threads:[~2022-08-15 18:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 8:08 [PATCH] rng-tools: add systemd-udev-settle wants to service Claudius Heine
2022-02-02 12:38 ` [OE-core] " Kyle Russell
2022-02-02 13:08 ` Claudius Heine
2022-02-02 16:26 ` Kyle Russell
2022-02-03 8:35 ` Claudius Heine
2022-02-03 14:12 ` Kyle Russell
2022-07-21 15:17 ` Drew Moseley
2022-07-21 15:29 ` Khem Raj
2022-07-22 20:42 ` Drew Moseley
2022-07-23 0:30 ` [OE-core] " Khem Raj
2022-07-23 7:03 ` Claudius Heine
2022-07-26 13:17 ` [OE-core][PATCH] rng-tools: Replace obsolete "wants systemd-udev-settle" drew.moseley
2022-08-01 18:44 ` Drew Moseley
2022-08-02 7:24 ` Claudius Heine
2022-08-02 7:47 ` Khem Raj
2022-08-04 15:09 ` [OE-core][PATCH v2] " drew.moseley
2022-08-12 12:59 ` Dragos-Marian Panait
2022-08-12 15:20 ` Drew Moseley
2022-08-15 18:25 ` [OE-core][PATCH] rng-tools: Change "Requires" to "WantedBy" for dev-hwrng.device drew.moseley
2022-08-15 18:29 ` Drew Moseley [this message]
2022-08-15 18:47 ` Khem Raj
2022-08-18 17:12 ` Alexander Kanavin
2022-08-19 9:36 ` Claudius Heine
2022-08-19 12:50 ` Dragos-Marian Panait
2022-08-19 14:34 ` Drew Moseley
2022-08-19 15:07 ` Dragos-Marian Panait
2022-08-19 15:13 ` Drew Moseley
2022-08-19 15:21 ` Alexander Kanavin
2022-08-19 16:24 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43f17af6-eb16-efd3-ce23-374ea6791c52@gmail.com \
--to=drew.moseley@gmail.com \
--cc=ch@denx.de \
--cc=dragos.panait@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.