Re: [OE-core][PATCH] rng-tools: Change "Requires" to "WantedBy" for dev-hwrng.device

From: Alexander Kanavin <alex.kanavin@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Drew Moseley <drew.moseley@gmail.com>,
	Claudius Heine <ch@denx.de>,
	Dragos-Marian Panait <dragos.panait@windriver.com>,
	OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core][PATCH] rng-tools: Change "Requires" to "WantedBy" for dev-hwrng.device
Date: Thu, 18 Aug 2022 19:12:02 +0200	[thread overview]
Message-ID: <CANNYZj_g=Rc0PUUH5xb=o=WmPJEFhERNAmtD8kR7-VeZQz5suA@mail.gmail.com> (raw)
In-Reply-To: <CAMKF1spqYbHNQ7nWbPiM8jmy=pZNM3h7UvRhPfCRaYORuo7qDw@mail.gmail.com>

I am definitely seeing a serious regression where qemu images get
stuck for 4 minutes on boot waiting for /dev/hwrng, so if this is
fixing the issue, I'd appreciate getting it in!

Alex

On Mon, 15 Aug 2022 at 20:48, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Aug 15, 2022 at 11:30 AM Drew Moseley <drew.moseley@gmail.com> wrote:
> >
> > Hi Khem,
> >
> > It looks like you recently removed both the dependency on hwrng and
> > systemd-udev-settle.  Do you think this change will be useful?
>
> Depending on udev-settle certainly seems an overkill so that should go.
> the change you have made will now ensure that this service starts when
> dev-hwrng device is created
> but loses the order of starting the service. So it may still race with
> device creation.
>
> >
> > Claudius, any thoughts here?
> >
> >
> > Drew
> >
> >
> >
> > On 8/15/22 2:25 PM, drew.moseley@gmail.com wrote:
> > > From: Drew Moseley <drew@moseleynet.net>
> > >
> > > The previous change to remove the dependency on systemd-udev-settle
> > > caused boot delays at least on qemu. It seems that change required
> > > a hwrng device but that's not necessarily available on all platforms.
> > >
> > > This changes the "Requires" to a "WantedBy" as modeled after the
> > > version of this file on Ubuntu 20.04.
> > >
> > > Signed-off-by: Drew Moseley <drew@moseleynet.net>
> > > ---
> > >   meta/recipes-support/rng-tools/rng-tools/rng-tools.service | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> > > index 0f50890dcb..b013d95932 100644
> > > --- a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> > > +++ b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
> > > @@ -3,8 +3,6 @@ Description=Hardware RNG Entropy Gatherer Daemon
> > >   DefaultDependencies=no
> > >   After=systemd-udev-settle.service
> > >   Before=sysinit.target shutdown.target
> > > -Requires=dev-hwrng.device
> > > -After=dev-hwrng.device
> > >   Conflicts=shutdown.target
> > >
> > >   [Service]
> > > @@ -32,3 +30,4 @@ SystemCallFilter=@system-service
> > >
> > >   [Install]
> > >   WantedBy=sysinit.target
> > > +WantedBy=dev-hwrng.device
> >
> > --
> > mailto:drew@moseleynet.net
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#169360): https://lists.openembedded.org/g/openembedded-core/message/169360
> Mute This Topic: https://lists.openembedded.org/mt/93042904/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>