From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v4 5/9] ARM: shmobile: marzen: Enable DU device in DT
Date: Sun, 26 Oct 2014 12:49:05 +0000 [thread overview]
Message-ID: <4408127.zKOodmhEQT@avalon> (raw)
In-Reply-To: <1414152241-5390-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Sergei,
Thank you for the review.
On Friday 24 October 2014 16:36:38 Sergei Shtylyov wrote:
> On 10/24/2014 4:03 PM, Laurent Pinchart wrote:
> > Specify the DU output topology, enable the DU device and configure the
> > related pins.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > arch/arm/boot/dts/r8a7779-marzen.dts | 81 ++++++++++++++++++++++++++++++
> > 1 file changed, 81 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts
> > b/arch/arm/boot/dts/r8a7779-marzen.dts index 9e1b859190ca..64a5d634edc1
> > 100644
> > --- a/arch/arm/boot/dts/r8a7779-marzen.dts
> > +++ b/arch/arm/boot/dts/r8a7779-marzen.dts
> > @@ -69,6 +69,76 @@
> > gpios = <&gpio4 31 GPIO_ACTIVE_HIGH>;
> > };
> > };
> > +
> > + vga-encoder {
> > + compatible = "adi,adv7123";
>
> [...]
>
> > + lvds-enc {
>
> Using "lvds-encoder" would have been more consistent.
I'll fix that.
> > + compatible = "thine,thc63lvdm83d";
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ports {
> > + port@0 {
>
> Hm, I don't see the "reg" prop, where is it?
In arch/arm/boot/dts/r8a7779.dtsi.
> > + lvds_enc_in: endpoint {
> > + remote-endpoint = <&du_out_rgb1>;
> > + };
> > + };
> > + port@1 {
> > + lvds_connector: endpoint {
> > + };
> > + };
> > + };
> > + };
> > +};
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-10-26 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 12:03 [PATCH v4 5/9] ARM: shmobile: marzen: Enable DU device in DT Laurent Pinchart
2014-10-24 12:36 ` Sergei Shtylyov
2014-10-26 12:49 ` Laurent Pinchart [this message]
2014-10-26 13:04 ` Sergei Shtylyov
2014-10-26 13:16 ` Laurent Pinchart
2014-10-27 1:23 ` Simon Horman
2014-10-27 9:18 ` Geert Uytterhoeven
2014-10-27 9:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4408127.zKOodmhEQT@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.